Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003676Doomseeker[All Projects] Epicpublic2019-07-12 18:242021-12-30 11:11
ReporterWubTheCaptain 
Assigned To 
PrioritynoneSeveritytweakReproducibilityN/A
StatusacknowledgedResolutionopen 
PlatformOSOS Version
Product Version1.2 
Target VersionFixed in Version 
Summary0003676: There are button/graphic inconsistencies in the UI (0003636)
Description0003636:0020628:

Quote from WubTheCaptain
Then there's even more off-topic irrelevant UI inconsistencies, such as missing icons next to "Close" buttons that can be found in "About Doomseeker" but not in "Create Game". Agh! I have issues to report tomorrow.

Honestly, the issue in OP is resolved or very close to it. Any UI issues I'd report somewhere. Zalewa, please feel free to merge this imho for testing. We'll polish it soon in other reported issues, I hope.
Attached Filespng file icon 2020-01-30-141415_maim.png [^] (2,610 bytes) 2020-01-30 14:19


png file icon 2020-01-30-141431_maim.png [^] (4,352 bytes) 2020-01-30 14:19


png file icon 2020-01-30-141441_maim.png [^] (2,117 bytes) 2020-01-30 14:19


png file icon 2020-01-30-141459_maim.png [^] (5,033 bytes) 2020-01-30 14:20


png file icon 2020-01-30-141509_maim.png [^] (7,784 bytes) 2020-01-30 14:20


png file icon 2020-01-30-141522_maim.png [^] (3,295 bytes) 2020-01-30 14:20


png file icon 2020-01-30-141539_maim.png [^] (4,330 bytes) 2020-01-30 14:21


png file icon 2020-01-30-141557_maim.png [^] (9,129 bytes) 2020-01-30 14:21


png file icon 2020-01-30-141606_maim.png [^] (7,868 bytes) 2020-01-30 14:21


png file icon 2020-01-30-141621_maim.png [^] (5,742 bytes) 2020-01-30 14:22


png file icon 2020-01-30-141638_maim.png [^] (14,659 bytes) 2020-01-30 14:22


png file icon 2020-01-30-141649_maim.png [^] (8,763 bytes) 2020-01-30 14:22


png file icon 2020-01-30-141713_maim.png [^] (5,185 bytes) 2020-01-30 14:23


png file icon 2020-01-30-141726_maim.png [^] (3,696 bytes) 2020-01-30 14:23


png file icon 2020-01-30-141743_maim.png [^] (2,517 bytes) 2020-01-30 14:23


png file icon 2020-01-30-141821_maim.png [^] (7,903 bytes) 2020-01-30 14:24


png file icon 2020-01-30-141838_maim.png [^] (4,081 bytes) 2020-01-30 14:24


png file icon 2020-01-30-141852_maim.png [^] (7,398 bytes) 2020-01-30 14:24


png file icon 2020-01-30-143050_maim.png [^] (14,970 bytes) 2020-01-30 14:31


png file icon 2020-01-30-143307_maim.png [^] (4,064 bytes) 2020-01-30 14:33


png file icon 2020-01-30-143359_maim.png [^] (14,569 bytes) 2020-01-30 14:34


png file icon 2020-01-30-143438_maim.png [^] (5,879 bytes) 2020-01-30 14:35


png file icon 2020-01-30-144027_maim.png [^] (12,692 bytes) 2020-01-30 14:40


png file icon 2020-01-30-144128_maim.png [^] (6,110 bytes) 2020-01-30 14:41


png file icon 2020-01-30-144154_maim.png [^] (5,276 bytes) 2020-01-30 14:42


png file icon 2020-01-30-144252_maim.png [^] (13,201 bytes) 2020-01-30 14:43


png file icon 2020-01-30-144307_maim.png [^] (8,666 bytes) 2020-01-30 14:43


png file icon 2020-01-30-144334_maim.png [^] (7,671 bytes) 2020-01-30 14:43


png file icon 2020-01-30-144407_maim.png [^] (8,096 bytes) 2020-01-30 14:44


png file icon 2020-01-30-144430_maim.png [^] (7,825 bytes) 2020-01-30 14:44


png file icon 2020-01-30-144741_maim.png [^] (3,558 bytes) 2020-01-30 14:48


png file icon 2020-01-30-145221_maim.png [^] (14,885 bytes) 2020-01-30 14:52


png file icon 2020-01-30-145530_maim.png [^] (21,322 bytes) 2020-01-30 14:55


png file icon 2020-01-30-145808_maim.png [^] (5,203 bytes) 2020-01-30 14:58


png file icon 2020-01-30-145822_maim.png [^] (5,301 bytes) 2020-01-30 14:58


png file icon 2020-06-26-051103_maim.png [^] (21,456 bytes) 2020-06-26 05:11


png file icon 2020-06-26-052221_maim.png [^] (3,384 bytes) 2020-06-26 05:22


png file icon qt5-fusion-style-qdialogbuttonbox-reference.png [^] (21,004 bytes) 2020-06-26 23:12

- Relationships
related to 0003636closedZalewa Create Game box - adjust UI elements to Host, Offline and Remote modes 
related to 0003753new UI design guidelines are missing 

-  Notes
User avatar (0020874)
WubTheCaptain (developer)
2019-07-12 18:25
edited on: 2019-07-12 18:26

Reporting this as epic category new issue, because it seems I've already forgotten in the past to report each issue individually. This is to remind me I should report those new issues.

User avatar (0021164)
WubTheCaptain (developer)
2020-01-30 14:28
edited on: 2020-01-30 15:10

The attached screenshots are from Doomseeker 1.3.1, from various parts of the program. Notable things:
  • "Close" doesn't always have the cross icon.
  • "Cancel" doesn't always have the cross icon.
  • "Clear" doesn't always have the cross icon.
  • Many "Close" buttons are (natively) just "OK" with an arrow in Qt and some places (error messages), instead of a "Close" button.
  • "Remove" is sometimes called "Delete".
  • "UPDATE!" and "Download" may be different.
  • "Add defaults" button may be aligned differently with the other buttons.
  • Mixed capitalization.
  • Password prompts may be missing the small "Clear" (?) button.
  • Idgames URL being configurable (why?) but Wad-Archives URL not.
  • "Copy to clipboard" and "Copy all to clipboard".
  • Some settings being presented as questions (with a question mark) rather than... not.
  • Different font typefaces and sizes used in "close" dialogs (Program Args. vs JSON library license).
  • Using a cross icon in place of a minus icon, and vice versa.
  • "Program arguments" window title not being prefixed with "Doomseeker -" (not pictured).
  • "Doomseeker - Copy Text" being used as a window title (not pictured), with "JSON library license" text in the window itself. (Should be "Doomseeker – JSON library license" or simply "JSON library license".)
  • The pencil icon in Doomseeker not matching the pencil icon used on the tracker (not pictured). 😀


User avatar (0021472)
WubTheCaptain (developer)
2020-06-26 05:10
edited on: 2020-06-26 05:14

  • Different dialogs have inconsistent geometry. E.g. some widgets may be X-positioned at 9, some at 0, some at 1, etc.
  • Buttons are not often of equal width – sometimes acceptable –, but worse is when they don't have equal padding (ignoring translations). E.g. compare btnUpdatesDiscard and btnUpdatesDownloadAndInstall in mainwindow.ui (or nearly any other example given here).


User avatar (0021473)
WubTheCaptain (developer)
2020-06-26 05:24

  • Create Game dialog mocks QWizard horizontal rule badly. (Likely to be redesigned with 0003480, though.)
User avatar (0021482)
WubTheCaptain (developer)
2020-06-26 23:11
edited on: 2020-06-26 23:11

  • Buttons without icons might be 23 pixels tall, with icons 24 pixels tall.

Honestly, a lot of these are issues with Qt itself.

User avatar (0021483)
Blzut3 (administrator)
2020-06-26 23:21

Yeah one thing to keep in mind is that we aren't one of those that reject the operating system theme and substitute our own. (Something I absolutely despise.) So there's always going to be some level of inconsistency since we support multiple platforms, which each support multiple themes (light and dark for example). Now that isn't to say that we haven't made errors, and there may even be ways that we can ask Qt what the correct decision is. Just be mindful that some things may be out of our control.
User avatar (0022014)
WubTheCaptain (developer)
2021-12-27 18:29

Target 1.3.3? Because of cleaning up inconsistent language (0003942) too.
User avatar (0022019)
Zalewa (developer)
2021-12-27 22:56

Quote from WubTheCaptain
Target 1.3.3? Because of cleaning up inconsistent language (0003942) too.

Maybe. Or at least partially. There's lots of stuff to go through here and going just through the texts requires lots of effort.

Quote
"Close" doesn't always have the cross icon.
"Cancel" doesn't always have the cross icon.
"Clear" doesn't always have the cross icon.

The system applies the icon when the button is created by the Qt's button box, but some of those buttons are added manually by us and only share the same text with the button box's. On Windows there are no icons on those buttons whatsoever. The theme you're using seems to icon the buttons partially only.

Quote
Many "Close" buttons are (natively) just "OK" with an arrow in Qt and some places (error messages), instead of a "Close" button.

This is fine (??)

Quote
window title not being prefixed with "Doomseeker -"


Inadvertendly I pointed this out in comment 0003942:0022012 too.

Quote
Different dialogs have inconsistent geometry. E.g. some widgets may be X-positioned at 9, some at 0, some at 1, etc.

I think that the config dialog indeed has too much padding but what do you mean with the X-positioning at 9 vs at 0?
User avatar (0022021)
Zalewa (developer)
2021-12-27 23:39

Double padding in the config box removed:https://bitbucket.org/Doomseeker/doomseeker/commits/d15f11eb1a231a9534d0402136c57ae52c1c8678 [^]
User avatar (0022023)
WubTheCaptain (developer)
2021-12-28 10:05
edited on: 2021-12-28 10:06

Quote from Zalewa
The system applies the icon when the button is created by the Qt's button box, but some of those buttons are added manually by us and only share the same text with the button box's.

So I guess my point was to say we don't use Qt's button box everywhere, where the Qt button box can be used as a reference ("Cancel", "OK", etc). Consistent theming and easy localization. Some end up having to be translated manually by us. I don't understand why this is so, right now.
src/core/translations/ca_ES.ts:        <source>Cancel</source>
src/core/translations/ca_ES.ts:        <translation>Cancelar</translation>

Quote from Zalewa
but what do you mean with the X-positioning at 9 vs at 0?

I can't remember anymore, sorry. Maybe this:
$ grep -r "<x>0</x>" src/ | wc -l
101
$ grep -r "<x>1</x>" src/ | wc -l
21
$ grep -r "<x>9</x>" src/ | wc -l
0

The "9" may have been the double-padding you mentioned, and me measuring with a measuring tool in an image editor from screenshots of the program.

User avatar (0022048)
Zalewa (developer)
2021-12-29 14:04

Removed the question marks from the checkboxes in the IRC chat logs options:https://bitbucket.org/Doomseeker/doomseeker/commits/15c8fc7fbd65c309dd39f88b5997e593529ee1f2 [^]
User avatar (0022051)
Zalewa (developer)
2021-12-29 15:03

Also removed the padding around the dockable widgets and the server list, making everything touch the borders of the window. Personally I think it makes the UI neater and cleaner, but depending on the user's personal preferences and the OS theme this may be viewed by others as either an improvement or a degradation. In any case, there's always `git revert`

https://bitbucket.org/Doomseeker/doomseeker/commits/37c76232f79dfa60a04f79a7017832464b624aae [^]
User avatar (0022052)
WubTheCaptain (developer)
2021-12-30 11:11

Quote from Zalewa
Also removed the padding around the dockable widgets and the server list, making everything touch the borders of the window.

I personally think this is a regression too, particularly for the server filter.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2019-07-12 18:24 WubTheCaptain New Issue
2019-07-12 18:25 WubTheCaptain Relationship added related to 0003636
2019-07-12 18:25 WubTheCaptain Note Added: 0020874
2019-07-12 18:26 WubTheCaptain Note Edited: 0020874 View Revisions
2019-07-12 18:26 WubTheCaptain Note Edited: 0020874 View Revisions
2019-07-12 18:27 WubTheCaptain Reproducibility always => N/A
2020-01-30 14:14 WubTheCaptain Assigned To => WubTheCaptain
2020-01-30 14:14 WubTheCaptain Status new => assigned
2020-01-30 14:19 WubTheCaptain File Added: 2020-01-30-141415_maim.png
2020-01-30 14:19 WubTheCaptain File Added: 2020-01-30-141431_maim.png
2020-01-30 14:19 WubTheCaptain File Added: 2020-01-30-141441_maim.png
2020-01-30 14:20 WubTheCaptain File Added: 2020-01-30-141459_maim.png
2020-01-30 14:20 WubTheCaptain File Added: 2020-01-30-141509_maim.png
2020-01-30 14:20 WubTheCaptain File Added: 2020-01-30-141522_maim.png
2020-01-30 14:21 WubTheCaptain File Added: 2020-01-30-141539_maim.png
2020-01-30 14:21 WubTheCaptain File Added: 2020-01-30-141557_maim.png
2020-01-30 14:21 WubTheCaptain File Added: 2020-01-30-141606_maim.png
2020-01-30 14:22 WubTheCaptain File Added: 2020-01-30-141621_maim.png
2020-01-30 14:22 WubTheCaptain File Added: 2020-01-30-141638_maim.png
2020-01-30 14:22 WubTheCaptain File Added: 2020-01-30-141649_maim.png
2020-01-30 14:23 WubTheCaptain File Added: 2020-01-30-141713_maim.png
2020-01-30 14:23 WubTheCaptain File Added: 2020-01-30-141726_maim.png
2020-01-30 14:23 WubTheCaptain File Added: 2020-01-30-141743_maim.png
2020-01-30 14:24 WubTheCaptain File Added: 2020-01-30-141821_maim.png
2020-01-30 14:24 WubTheCaptain File Added: 2020-01-30-141838_maim.png
2020-01-30 14:24 WubTheCaptain File Added: 2020-01-30-141852_maim.png
2020-01-30 14:28 WubTheCaptain Note Added: 0021164
2020-01-30 14:28 WubTheCaptain Assigned To WubTheCaptain =>
2020-01-30 14:28 WubTheCaptain Status assigned => acknowledged
2020-01-30 14:29 WubTheCaptain Note Edited: 0021164 View Revisions
2020-01-30 14:29 WubTheCaptain Note Edited: 0021164 View Revisions
2020-01-30 14:31 WubTheCaptain File Added: 2020-01-30-143050_maim.png
2020-01-30 14:33 WubTheCaptain File Added: 2020-01-30-143307_maim.png
2020-01-30 14:34 WubTheCaptain File Added: 2020-01-30-143359_maim.png
2020-01-30 14:35 WubTheCaptain File Added: 2020-01-30-143438_maim.png
2020-01-30 14:39 WubTheCaptain Priority low => none
2020-01-30 14:39 WubTheCaptain Severity minor => tweak
2020-01-30 14:40 WubTheCaptain File Added: 2020-01-30-144027_maim.png
2020-01-30 14:41 WubTheCaptain File Added: 2020-01-30-144128_maim.png
2020-01-30 14:42 WubTheCaptain File Added: 2020-01-30-144154_maim.png
2020-01-30 14:43 WubTheCaptain File Added: 2020-01-30-144252_maim.png
2020-01-30 14:43 WubTheCaptain File Added: 2020-01-30-144307_maim.png
2020-01-30 14:43 WubTheCaptain File Added: 2020-01-30-144334_maim.png
2020-01-30 14:44 WubTheCaptain File Added: 2020-01-30-144407_maim.png
2020-01-30 14:44 WubTheCaptain File Added: 2020-01-30-144430_maim.png
2020-01-30 14:46 WubTheCaptain Note Edited: 0021164 View Revisions
2020-01-30 14:48 WubTheCaptain File Added: 2020-01-30-144741_maim.png
2020-01-30 14:51 WubTheCaptain Note Edited: 0021164 View Revisions
2020-01-30 14:52 WubTheCaptain File Added: 2020-01-30-145221_maim.png
2020-01-30 14:54 WubTheCaptain Note Edited: 0021164 View Revisions
2020-01-30 14:55 WubTheCaptain File Added: 2020-01-30-145530_maim.png
2020-01-30 14:56 WubTheCaptain Note Edited: 0021164 View Revisions
2020-01-30 14:56 WubTheCaptain Note Edited: 0021164 View Revisions
2020-01-30 14:56 WubTheCaptain Note Edited: 0021164 View Revisions
2020-01-30 14:58 WubTheCaptain File Added: 2020-01-30-145808_maim.png
2020-01-30 14:58 WubTheCaptain File Added: 2020-01-30-145822_maim.png
2020-01-30 14:59 WubTheCaptain Note Edited: 0021164 View Revisions
2020-01-30 15:01 WubTheCaptain Note Edited: 0021164 View Revisions
2020-01-30 15:02 WubTheCaptain Note Edited: 0021164 View Revisions
2020-01-30 15:02 WubTheCaptain Note Edited: 0021164 View Revisions
2020-01-30 15:06 WubTheCaptain Note Edited: 0021164 View Revisions
2020-01-30 15:09 WubTheCaptain Note Edited: 0021164 View Revisions
2020-01-30 15:10 WubTheCaptain Note Edited: 0021164 View Revisions
2020-01-30 15:18 WubTheCaptain Relationship added related to 0003753
2020-06-26 05:10 WubTheCaptain Note Added: 0021472
2020-06-26 05:11 WubTheCaptain File Added: 2020-06-26-051103_maim.png
2020-06-26 05:14 WubTheCaptain Note Edited: 0021472 View Revisions
2020-06-26 05:22 WubTheCaptain File Added: 2020-06-26-052221_maim.png
2020-06-26 05:24 WubTheCaptain Note Added: 0021473
2020-06-26 23:11 WubTheCaptain Note Added: 0021482
2020-06-26 23:11 WubTheCaptain Note Edited: 0021482 View Revisions
2020-06-26 23:12 WubTheCaptain File Added: qt5-fusion-style-qdialogbuttonbox-reference.png
2020-06-26 23:21 Blzut3 Note Added: 0021483
2021-12-27 18:29 WubTheCaptain Note Added: 0022014
2021-12-27 22:56 Zalewa Note Added: 0022019
2021-12-27 23:39 Zalewa Note Added: 0022021
2021-12-28 10:05 WubTheCaptain Note Added: 0022023
2021-12-28 10:06 WubTheCaptain Note Edited: 0022023 View Revisions
2021-12-29 14:04 Zalewa Note Added: 0022048
2021-12-29 15:03 Zalewa Note Added: 0022051
2021-12-30 11:11 WubTheCaptain Note Added: 0022052






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2022 MantisBT Team
Powered by Mantis Bugtracker