Anonymous | Login | Signup for a new account | 2023-03-20 09:45 UTC | ![]() |
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0003676 | Doomseeker | [All Projects] Epic | public | 2019-07-12 18:24 | 2023-02-19 14:13 | ||||
Reporter | WubTheCaptain | ||||||||
Assigned To | Zalewa | ||||||||
Priority | none | Severity | tweak | Reproducibility | N/A | ||||
Status | resolved | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | 1.2 | ||||||||
Target Version | 1.4.0 | Fixed in Version | 1.4.0 | ||||||
Summary | 0003676: There are button/graphic inconsistencies in the UI (0003636) | ||||||||
Description | 0003636:0020628:Quote from WubTheCaptain | ||||||||
Attached Files | ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() | ||||||||
![]() |
||||||||||||||||||||||||||||||||||||
|
![]() |
|
WubTheCaptain (reporter) 2019-07-12 18:25 edited on: 2019-07-12 18:26 |
Reporting this as epic category new issue, because it seems I've already forgotten in the past to report each issue individually. This is to remind me I should report those new issues. |
WubTheCaptain (reporter) 2020-01-30 14:28 edited on: 2020-01-30 15:10 |
The attached screenshots are from Doomseeker 1.3.1, from various parts of the program. Notable things:
|
WubTheCaptain (reporter) 2020-06-26 05:10 edited on: 2020-06-26 05:14 |
|
WubTheCaptain (reporter) 2020-06-26 05:24 |
|
WubTheCaptain (reporter) 2020-06-26 23:11 edited on: 2020-06-26 23:11 |
Honestly, a lot of these are issues with Qt itself. |
Blzut3 (administrator) 2020-06-26 23:21 |
Yeah one thing to keep in mind is that we aren't one of those that reject the operating system theme and substitute our own. (Something I absolutely despise.) So there's always going to be some level of inconsistency since we support multiple platforms, which each support multiple themes (light and dark for example). Now that isn't to say that we haven't made errors, and there may even be ways that we can ask Qt what the correct decision is. Just be mindful that some things may be out of our control. |
WubTheCaptain (reporter) 2021-12-27 18:29 |
Target 1.3.3? Because of cleaning up inconsistent language (0003942) too. |
Zalewa (developer) 2021-12-27 22:56 |
Quote from WubTheCaptain Maybe. Or at least partially. There's lots of stuff to go through here and going just through the texts requires lots of effort. Quote The system applies the icon when the button is created by the Qt's button box, but some of those buttons are added manually by us and only share the same text with the button box's. On Windows there are no icons on those buttons whatsoever. The theme you're using seems to icon the buttons partially only. Quote This is fine (??) Quote Inadvertendly I pointed this out in comment 0003942:0022012 too. Quote I think that the config dialog indeed has too much padding but what do you mean with the X-positioning at 9 vs at 0? |
Zalewa (developer) 2021-12-27 23:39 |
Double padding in the config box removed:https://bitbucket.org/Doomseeker/doomseeker/commits/d15f11eb1a231a9534d0402136c57ae52c1c8678 [^] |
WubTheCaptain (reporter) 2021-12-28 10:05 edited on: 2021-12-28 10:06 |
Quote from Zalewa So I guess my point was to say we don't use Qt's button box everywhere, where the Qt button box can be used as a reference ("Cancel", "OK", etc). Consistent theming and easy localization. Some end up having to be translated manually by us. I don't understand why this is so, right now. src/core/translations/ca_ES.ts: <source>Cancel</source> src/core/translations/ca_ES.ts: <translation>Cancelar</translation> Quote from Zalewa I can't remember anymore, sorry. Maybe this: $ grep -r "<x>0</x>" src/ | wc -l 101 $ grep -r "<x>1</x>" src/ | wc -l 21 $ grep -r "<x>9</x>" src/ | wc -l 0 The "9" may have been the double-padding you mentioned, and me measuring with a measuring tool in an image editor from screenshots of the program. |
Zalewa (developer) 2021-12-29 14:04 |
Removed the question marks from the checkboxes in the IRC chat logs options:https://bitbucket.org/Doomseeker/doomseeker/commits/15c8fc7fbd65c309dd39f88b5997e593529ee1f2 [^] |
Zalewa (developer) 2021-12-29 15:03 |
Also removed the padding around the dockable widgets and the server list, making everything touch the borders of the window. Personally I think it makes the UI neater and cleaner, but depending on the user's personal preferences and the OS theme this may be viewed by others as either an improvement or a degradation. In any case, there's always `git revert` https://bitbucket.org/Doomseeker/doomseeker/commits/37c76232f79dfa60a04f79a7017832464b624aae [^] |
WubTheCaptain (reporter) 2021-12-30 11:11 |
Quote from Zalewa I personally think this is a regression too, particularly for the server filter. |
Zalewa (developer) 2022-12-30 21:36 |
Considerable amount of commits today to clean up the inconsistencies: - IP2C updater buttons use natural capitalization. - All "Browse" buttons will now use the open icon and show "Browse" tooltip or text. - 'D' icon will now appear on all "Default" buttons. - Use the "remove" word instead of "delete". - The Hide/Reveal push button in the server passwords config replaced with a checkbox, because other places have checkboxes too. - Icon/theme inconsistencies with "Close", "Cancel", "OK" resolved by using the standard buttons everywhere. Note that these buttons may still appear next to custom buttons with custom icons, which is intended. - Use a broom icon on "Clear" buttons instead of the red X, or use the "edit-clear" icon as defined by freedesktop if available. - Use natural capitalization on buttons. I might've missed some, though. - Both "Add defaults"/Add/Remove layouts will now appear the same. - Say Doomseeker in the Program args help box. |
Zalewa (developer) 2022-12-30 22:44 edited on: 2022-12-30 22:44 |
The remaining issues:Quote from WubTheCaptain This problem starts in the "About Qt" dialog which is produced 100% by Qt and has the "OK" button instead of "Close". Then, the default button for the critical, warning and info message boxes is also "OK", not "Close". I think that the "OK" and "Close" buttons can be considered as synonymous when the dialog box has only one button, and ambiguous if they both are in the dialog box (this case doesn't occur, however). So, I'm not especially aggravated that there's an "OK" button that does the same thing as "Close" would do. However, the inconsistency is still noticeable when you compare the "Program args", our own "About" and "About Qt" boxes where the first 2 have "Close" while the Qt box has "OK". If we feel particularly pedantic I can change the "Close" button in both of those cases to "OK", so that at least we have some consistency around the help dialogs. Another thing is with the positioning of the buttons. It can be either centered or laid out with the OS preferences (right-aligned). I actually don't know if there are any design guidelines out there explaining when you should prefer one layout over the another, but Doomseeker is certainly not consistent here. I don't think we have any case where the centrally laid out buttons would give any advantage, so maybe I should just right-align them everywhere? In places where they are currently centrally aligned, that is. Quote from WubTheCaptain In the IRC connect box, IRC network definition and the nickserv password input, right? I'll take care of that. Then again there was the idea 0003289, which with everyone moving to Discord doesn't look so out-of-the-question anymore. Quote from WubTheCaptain Just in case. It was actually wrong to not permit the same for Wad Archive, but Wad Archive is dead and gone, so problem has resolved itself on its own. Quote from WubTheCaptain Actually there is a small semantic difference between those two buttons. Both of them could have the word "all", but I don't view this difference as a particular problem. Quote from WubTheCaptain Where? There's only one case where the minus icon is used: in the pinned servers config box. Do you mean that the "minus" should mean "remove"? Well, perhaps, but Doomseeker uses the red X for that, and I don't think I'll be changing that. There was an inconsistency with the red X also being used for the "Clear" buttons, but those buttons will now have the "edit-clear" icon or the broom icon. Quote from WubTheCaptain I'll assume this is a joke. Quote from WubTheCaptain Not sure if there are still dialogs that do that, but the differences in the margin between the widgets may be intentional. Quote from WubTheCaptain Yeah, these two are aggravating, but the problem may not be solvable easily without risking doing something wrong for some system theme that is out there. Still, there are some potential fixes for that that I could try out. It seems that the extra padding can be added by overriding the application style (https://stackoverflow.com/a/20532712/1089357). Alternatively, it's also possible to increase the minimum width of those buttons so that they grow some padding, but that's also risky among the various themes where finding the right width value might not be easy. The vertical height 1 pixel discrepancy is something that I also see on Windows (particularly in the "Create game" box) but I have an idea on how to fix that without risking breaking the varying themes layouts. However, the fix I have in mind would need to be applied for each affected case individually and carefully. I'll try these things out and check if improvement can be achieved, but the text padding thing may be something that we'll have to give up on. Anything else? |
WubTheCaptain (reporter) 2022-12-31 00:20 edited on: 2022-12-31 00:21 |
Quote from Zalewa This consistency is arguably nicer, but I notice Qt also has a standard button "Reset" or "Restore Defaults" available. Quote from ZalewaQuote from WubTheCaptain Yes. |
WubTheCaptain (reporter) 2022-12-31 00:20 edited on: 2022-12-31 03:11 |
0004077 I think I should've reported another issue for the following newly discovered things, but let's make a note. I see it wasn't mentioned here previously, but looking at src/core/gui/mainwindow.ui in Qt Designer, I see the button has a green checkmark for "Download & Install". Four issues with this:
|
WubTheCaptain (reporter) 2022-12-31 00:30 |
Looking again at qt5-fusion-style-qdialogbuttonbox-reference.png, the capitalization is all over the place in Qt, so I should not bother about capitalization. |
WubTheCaptain (reporter) 2022-12-31 03:12 |
New issues (children): 0004073, 0004074, 0004075, 0004076, 0004077. |
WubTheCaptain (reporter) 2022-12-31 04:07 |
Quote from Zalewa Fixing the issue may have created unexpected issues from user behavior adjusting to the new changes: 0004072, 0004078. |
Zalewa (developer) 2022-12-31 11:20 |
Quote from WubTheCaptain Judging by this screen alone: it's not all over the place. The buttons on this screen have their text capitalized in accordance to the title capitalization rules in English. This article explains them succintly:https://www.grammarly.com/blog/capitalization-in-the-titles/ [^] Now our own approach is to whether we consider the text in buttons as titles or not. Microsoft's design guide says to use the sentence-style capitalization in the buttons (https://learn.microsoft.com/en-us/windows/win32/uxguide/ctrl-command-buttons). Qt changes the capitalization depending on the language (qt-2022-12-31-1207_englishbuttons.jpg, qt-2022-12-31-1208_polishbuttons.jpg), which still sticks to the rules of title capitalization in both languages. We, however, have a luxury to ignore what Qt thinks about texts in buttons because there isn't a case where we would use a multi-word standard button. Also I prefer the Microsoft guideline here because when the buttons (or menu actions) get lengthy words their title capitalization begins to look ridiculous. Also I missed the "Set Game" button previously:https://bitbucket.org/Doomseeker/doomseeker/commits/92adb9948dc5b673b818c3d978056e67f131481f [^] |
Zalewa (developer) 2023-01-03 19:53 edited on: 2023-01-03 20:02 |
Missed the "Remote Console" context menu action:https://bitbucket.org/Doomseeker/doomseeker/commits/1c8cc0b62d2a12cecf12ce440d31b22d190c0b83 [^] |
Zalewa (developer) 2023-01-05 12:31 |
Beta package for Windows available at the beta auto-update channel and at: https://devbuilds.drdteam.org/doomseeker/doomseeker-1.3.3~beta-230105-1140_windows.zip [^] Can someone find something that I missed? |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | No one explicitly supports this issue yet. |
Opponents: | No one explicitly opposes this issue yet. |
![]() |
|||
Date Modified | Username | Field | Change |
2019-07-12 18:24 | WubTheCaptain | New Issue | |
2019-07-12 18:25 | WubTheCaptain | Relationship added | related to 0003636 |
2019-07-12 18:25 | WubTheCaptain | Note Added: 0020874 | |
2019-07-12 18:26 | WubTheCaptain | Note Edited: 0020874 | View Revisions |
2019-07-12 18:26 | WubTheCaptain | Note Edited: 0020874 | View Revisions |
2019-07-12 18:27 | WubTheCaptain | Reproducibility | always => N/A |
2020-01-30 14:14 | WubTheCaptain | Assigned To | => WubTheCaptain |
2020-01-30 14:14 | WubTheCaptain | Status | new => assigned |
2020-01-30 14:19 | WubTheCaptain | File Added: 2020-01-30-141415_maim.png | |
2020-01-30 14:19 | WubTheCaptain | File Added: 2020-01-30-141431_maim.png | |
2020-01-30 14:19 | WubTheCaptain | File Added: 2020-01-30-141441_maim.png | |
2020-01-30 14:20 | WubTheCaptain | File Added: 2020-01-30-141459_maim.png | |
2020-01-30 14:20 | WubTheCaptain | File Added: 2020-01-30-141509_maim.png | |
2020-01-30 14:20 | WubTheCaptain | File Added: 2020-01-30-141522_maim.png | |
2020-01-30 14:21 | WubTheCaptain | File Added: 2020-01-30-141539_maim.png | |
2020-01-30 14:21 | WubTheCaptain | File Added: 2020-01-30-141557_maim.png | |
2020-01-30 14:21 | WubTheCaptain | File Added: 2020-01-30-141606_maim.png | |
2020-01-30 14:22 | WubTheCaptain | File Added: 2020-01-30-141621_maim.png | |
2020-01-30 14:22 | WubTheCaptain | File Added: 2020-01-30-141638_maim.png | |
2020-01-30 14:22 | WubTheCaptain | File Added: 2020-01-30-141649_maim.png | |
2020-01-30 14:23 | WubTheCaptain | File Added: 2020-01-30-141713_maim.png | |
2020-01-30 14:23 | WubTheCaptain | File Added: 2020-01-30-141726_maim.png | |
2020-01-30 14:23 | WubTheCaptain | File Added: 2020-01-30-141743_maim.png | |
2020-01-30 14:24 | WubTheCaptain | File Added: 2020-01-30-141821_maim.png | |
2020-01-30 14:24 | WubTheCaptain | File Added: 2020-01-30-141838_maim.png | |
2020-01-30 14:24 | WubTheCaptain | File Added: 2020-01-30-141852_maim.png | |
2020-01-30 14:28 | WubTheCaptain | Note Added: 0021164 | |
2020-01-30 14:28 | WubTheCaptain | Assigned To | WubTheCaptain => |
2020-01-30 14:28 | WubTheCaptain | Status | assigned => acknowledged |
2020-01-30 14:29 | WubTheCaptain | Note Edited: 0021164 | View Revisions |
2020-01-30 14:29 | WubTheCaptain | Note Edited: 0021164 | View Revisions |
2020-01-30 14:31 | WubTheCaptain | File Added: 2020-01-30-143050_maim.png | |
2020-01-30 14:33 | WubTheCaptain | File Added: 2020-01-30-143307_maim.png | |
2020-01-30 14:34 | WubTheCaptain | File Added: 2020-01-30-143359_maim.png | |
2020-01-30 14:35 | WubTheCaptain | File Added: 2020-01-30-143438_maim.png | |
2020-01-30 14:39 | WubTheCaptain | Priority | low => none |
2020-01-30 14:39 | WubTheCaptain | Severity | minor => tweak |
2020-01-30 14:40 | WubTheCaptain | File Added: 2020-01-30-144027_maim.png | |
2020-01-30 14:41 | WubTheCaptain | File Added: 2020-01-30-144128_maim.png | |
2020-01-30 14:42 | WubTheCaptain | File Added: 2020-01-30-144154_maim.png | |
2020-01-30 14:43 | WubTheCaptain | File Added: 2020-01-30-144252_maim.png | |
2020-01-30 14:43 | WubTheCaptain | File Added: 2020-01-30-144307_maim.png | |
2020-01-30 14:43 | WubTheCaptain | File Added: 2020-01-30-144334_maim.png | |
2020-01-30 14:44 | WubTheCaptain | File Added: 2020-01-30-144407_maim.png | |
2020-01-30 14:44 | WubTheCaptain | File Added: 2020-01-30-144430_maim.png | |
2020-01-30 14:46 | WubTheCaptain | Note Edited: 0021164 | View Revisions |
2020-01-30 14:48 | WubTheCaptain | File Added: 2020-01-30-144741_maim.png | |
2020-01-30 14:51 | WubTheCaptain | Note Edited: 0021164 | View Revisions |
2020-01-30 14:52 | WubTheCaptain | File Added: 2020-01-30-145221_maim.png | |
2020-01-30 14:54 | WubTheCaptain | Note Edited: 0021164 | View Revisions |
2020-01-30 14:55 | WubTheCaptain | File Added: 2020-01-30-145530_maim.png | |
2020-01-30 14:56 | WubTheCaptain | Note Edited: 0021164 | View Revisions |
2020-01-30 14:56 | WubTheCaptain | Note Edited: 0021164 | View Revisions |
2020-01-30 14:56 | WubTheCaptain | Note Edited: 0021164 | View Revisions |
2020-01-30 14:58 | WubTheCaptain | File Added: 2020-01-30-145808_maim.png | |
2020-01-30 14:58 | WubTheCaptain | File Added: 2020-01-30-145822_maim.png | |
2020-01-30 14:59 | WubTheCaptain | Note Edited: 0021164 | View Revisions |
2020-01-30 15:01 | WubTheCaptain | Note Edited: 0021164 | View Revisions |
2020-01-30 15:02 | WubTheCaptain | Note Edited: 0021164 | View Revisions |
2020-01-30 15:02 | WubTheCaptain | Note Edited: 0021164 | View Revisions |
2020-01-30 15:06 | WubTheCaptain | Note Edited: 0021164 | View Revisions |
2020-01-30 15:09 | WubTheCaptain | Note Edited: 0021164 | View Revisions |
2020-01-30 15:10 | WubTheCaptain | Note Edited: 0021164 | View Revisions |
2020-01-30 15:18 | WubTheCaptain | Relationship added | related to 0003753 |
2020-06-26 05:10 | WubTheCaptain | Note Added: 0021472 | |
2020-06-26 05:11 | WubTheCaptain | File Added: 2020-06-26-051103_maim.png | |
2020-06-26 05:14 | WubTheCaptain | Note Edited: 0021472 | View Revisions |
2020-06-26 05:22 | WubTheCaptain | File Added: 2020-06-26-052221_maim.png | |
2020-06-26 05:24 | WubTheCaptain | Note Added: 0021473 | |
2020-06-26 23:11 | WubTheCaptain | Note Added: 0021482 | |
2020-06-26 23:11 | WubTheCaptain | Note Edited: 0021482 | View Revisions |
2020-06-26 23:12 | WubTheCaptain | File Added: qt5-fusion-style-qdialogbuttonbox-reference.png | |
2020-06-26 23:21 | Blzut3 | Note Added: 0021483 | |
2021-12-27 18:29 | WubTheCaptain | Note Added: 0022014 | |
2021-12-27 22:56 | Zalewa | Note Added: 0022019 | |
2021-12-27 23:39 | Zalewa | Note Added: 0022021 | |
2021-12-28 10:05 | WubTheCaptain | Note Added: 0022023 | |
2021-12-28 10:06 | WubTheCaptain | Note Edited: 0022023 | View Revisions |
2021-12-29 14:04 | Zalewa | Note Added: 0022048 | |
2021-12-29 15:03 | Zalewa | Note Added: 0022051 | |
2021-12-30 11:11 | WubTheCaptain | Note Added: 0022052 | |
2022-09-10 14:37 | Zalewa | Target Version | => 1.4.0 |
2022-12-29 22:32 | Zalewa | Assigned To | => Zalewa |
2022-12-29 22:32 | Zalewa | Status | acknowledged => assigned |
2022-12-30 21:36 | Zalewa | Note Added: 0022578 | |
2022-12-30 22:44 | Zalewa | Note Added: 0022579 | |
2022-12-30 22:44 | Zalewa | Status | assigned => feedback |
2022-12-30 22:44 | Zalewa | Note Edited: 0022579 | View Revisions |
2022-12-31 00:20 | WubTheCaptain | Note Added: 0022581 | |
2022-12-31 00:20 | WubTheCaptain | Status | feedback => assigned |
2022-12-31 00:20 | WubTheCaptain | Note Added: 0022582 | |
2022-12-31 00:21 | WubTheCaptain | Note Edited: 0022581 | View Revisions |
2022-12-31 00:25 | WubTheCaptain | Note Edited: 0022582 | View Revisions |
2022-12-31 00:25 | WubTheCaptain | Note Edited: 0022582 | View Revisions |
2022-12-31 00:27 | WubTheCaptain | Note Edited: 0022582 | View Revisions |
2022-12-31 00:30 | WubTheCaptain | Note Added: 0022583 | |
2022-12-31 03:11 | WubTheCaptain | Note Edited: 0022582 | View Revisions |
2022-12-31 03:12 | WubTheCaptain | Note Added: 0022593 | |
2022-12-31 04:07 | WubTheCaptain | Note Added: 0022600 | |
2022-12-31 11:09 | Zalewa | File Added: qt-2022-12-31-1207_englishbuttons.jpg | |
2022-12-31 11:09 | Zalewa | File Added: qt-2022-12-31-1208_polishbuttons.jpg | |
2022-12-31 11:20 | Zalewa | Note Added: 0022609 | |
2022-12-31 11:20 | Zalewa | Status | assigned => needs review |
2022-12-31 11:21 | Zalewa | Relationship added | parent of 0004074 |
2022-12-31 11:22 | Zalewa | Relationship added | parent of 0004075 |
2022-12-31 11:23 | Zalewa | Relationship added | parent of 0004073 |
2022-12-31 11:24 | Zalewa | Relationship added | parent of 0004076 |
2022-12-31 11:24 | Zalewa | Relationship added | parent of 0004077 |
2023-01-03 19:53 | Zalewa | Note Added: 0022627 | |
2023-01-03 20:02 | Zalewa | Note Edited: 0022627 | View Revisions |
2023-01-05 12:31 | Zalewa | Note Added: 0022663 | |
2023-01-05 12:31 | Zalewa | Status | needs review => needs testing |
2023-02-19 14:13 | Zalewa | Status | needs testing => resolved |
2023-02-19 14:13 | Zalewa | Fixed in Version | => 1.4.0 |
2023-02-19 14:13 | Zalewa | Resolution | open => fixed |
Copyright © 2000 - 2023 MantisBT Team |