|Anonymous | Login | Signup for a new account||2023-02-06 17:10 UTC|
|My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0004072||Doomseeker||UI||public||2022-12-31 02:30||2023-01-15 22:24|
|Target Version||1.4.0||Fixed in Version|
|Summary||0004072: Ambiguous "Clear" button Create Game|
|Description||The left-aligned "Clear" button in Create Game window is meant to clear the "Additional WADs and files" list, but it could be misunderstood for a reset button to clear all fields in the window (e.g. server name). If the WAD list is empty when the user presses the button for the first time in their life ever, the user may misunderstand that the button is functionally broken and does nothing ever.|
There's no tooltip on hover to explain what the button does.
|Steps To Reproduce||Create game (Ctrl + S). Fill in a server name, make sure the additional WADs and files list is empty. Press "Clear". Nothing happens (it would clear the additional WADs list in this case).|
$ git describe --tags 1.3.3-111-gc21f2267
|Attached Files|| 2022-12-31-022439_maim.png [^] (54,672 bytes) 2022-12-31 02:30
ds_2022-12-31-1149_creategame.jpg [^] (85,365 bytes) 2022-12-31 10:49
ds-20230115-left-align-buttons.png [^] (5,729 bytes) 2023-01-15 22:22
edited on: 2022-12-31 03:30
Honestly, I had to ask: Does this "Clear" button even need to exist as is? Pressing "Ctrl + A" in the list selects all the list items, so does click the topmost list item + Shift-click the lowest one, then remove. The only thing missing is that right clicking the list doesn't present an option to select all list items.
If something else, I'd much rather prefer a full "Reset" button in the very bottom left that resets everything in the window to default, fresh values.
|Heck, you can even mouse click-drag in the empty space of the list to select multiple WADS/files with a mouse.|
edited on: 2022-12-31 03:40
If the existing "Clear" button should continue to exist, sure, but I'd like to have the whole additional files widget grouped on a darker background (like the Rules tab does) please.
|Related to 0004078, caused me (an user) to misunderstand what "Clear" buttons generally do. One clears textboxes, another doesn't.|
I altered the layout so that the buttons pertaining this list are laid out vertically:https://bitbucket.org/Doomseeker/doomseeker/commits/5c9f5729c7c672670c0e357feb83e83194b8a016 [^]
Quote from WubTheCaptain
The darker background depends on the OS theme. Windows 10 doesn't do that.
The elements in the Rules tab are placed inside a group box. I first tried to do the same here, but the group box requires some padding to look fine, and this extra padding was squashing the list too much. It didn't look good. Laying out the buttons vertically to the side of the list should achieve the same grouping effect without stealing the precious real estate.
I've also made the list respond to the delete, minus and plus keyboard keys.
Beta package for Windows available at the beta auto-update channel and at:
Please test if the buttons are fine now.
I had to remove the forced left text-align of the buttons because it was producing really awkward-looking buttons in some themes (see KDE theme in ds-20230115-left-align-buttons.png, Mate theme was even worse).
|Only registered users can voice their support. Click here to register, or here to log in.|
|Supporters:||No one explicitly supports this issue yet.|
|Opponents:||No one explicitly opposes this issue yet.|
|2022-12-31 02:30||WubTheCaptain||New Issue|
|2022-12-31 02:30||WubTheCaptain||File Added: 2022-12-31-022439_maim.png|
|2022-12-31 03:30||WubTheCaptain||Note Added: 0022595|
|2022-12-31 03:30||WubTheCaptain||Note Edited: 0022595||View Revisions|
|2022-12-31 03:32||WubTheCaptain||Note Added: 0022596|
|2022-12-31 03:38||WubTheCaptain||Note Added: 0022597|
|2022-12-31 03:38||WubTheCaptain||Note Edited: 0022597||View Revisions|
|2022-12-31 03:40||WubTheCaptain||Note Edited: 0022597||View Revisions|
|2022-12-31 04:21||WubTheCaptain||Note Added: 0022603|
|2022-12-31 10:49||Zalewa||File Added: ds_2022-12-31-1149_creategame.jpg|
|2022-12-31 10:54||Zalewa||Note Added: 0022608|
|2022-12-31 10:54||Zalewa||Assigned To||=> Zalewa|
|2022-12-31 10:54||Zalewa||Status||new => needs review|
|2022-12-31 10:54||Zalewa||Target Version||=> 1.4.0|
|2023-01-05 12:22||Zalewa||Note Added: 0022653|
|2023-01-05 12:22||Zalewa||Status||needs review => needs testing|
|2023-01-15 22:22||Zalewa||File Added: ds-20230115-left-align-buttons.png|
|2023-01-15 22:24||Zalewa||Note Added: 0022701|
Questions or other issues? Contact Us.
|Copyright © 2000 - 2023 MantisBT Team|