MantisBT - Doomseeker
View Issue Details
0003676Doomseeker[All Projects] Epicpublic2019-07-12 18:242024-11-03 19:10
WubTheCaptain 
Zalewa 
nonetweakN/A
closedfixed 
1.2 
1.4.01.4.0 
0003676: There are button/graphic inconsistencies in the UI (/tracker/view.php?id=3636)
0003636:0020628:

Quote from WubTheCaptain
Then there's even more off-topic irrelevant UI inconsistencies, such as missing icons next to "Close" buttons that can be found in "About Doomseeker" but not in "Create Game". Agh! I have issues to report tomorrow.

Honestly, the issue in OP is resolved or very close to it. Any UI issues I'd report somewhere. Zalewa, please feel free to merge this imho for testing. We'll polish it soon in other reported issues, I hope.
No tags attached.
related to 0003636closed Zalewa Create Game box - adjust UI elements to Host, Offline and Remote modes 
parent of 0004074closed Zalewa Inconsistent colon punctuation in Create Game → Rules tab 
parent of 0004075closed Zalewa Many small inconsistencies and ambiguities Create Game's Zandronum tab 
parent of 0004073closed Zalewa Unnatural text capitalization "Broadcast to Master" in Create Game 
parent of 0004076closed Zalewa "Allow the game to choose port." label ends in punctuation 
parent of 0004077closed Zalewa Update notifications in the main window are inconsistent with the rest of the UI 
related to 0003753new  UI design guidelines are missing 
png 2020-01-30-141415_maim.png (2,610) 2020-01-30 14:19
https://zandronum.com/tracker/file_download.php?file_id=2523&type=bug
png

png 2020-01-30-141431_maim.png (4,352) 2020-01-30 14:19
https://zandronum.com/tracker/file_download.php?file_id=2524&type=bug
png

png 2020-01-30-141441_maim.png (2,117) 2020-01-30 14:19
https://zandronum.com/tracker/file_download.php?file_id=2525&type=bug
png

png 2020-01-30-141459_maim.png (5,033) 2020-01-30 14:20
https://zandronum.com/tracker/file_download.php?file_id=2526&type=bug
png

png 2020-01-30-141509_maim.png (7,784) 2020-01-30 14:20
https://zandronum.com/tracker/file_download.php?file_id=2527&type=bug
png

png 2020-01-30-141522_maim.png (3,295) 2020-01-30 14:20
https://zandronum.com/tracker/file_download.php?file_id=2528&type=bug
png

png 2020-01-30-141539_maim.png (4,330) 2020-01-30 14:21
https://zandronum.com/tracker/file_download.php?file_id=2529&type=bug
png

png 2020-01-30-141557_maim.png (9,129) 2020-01-30 14:21
https://zandronum.com/tracker/file_download.php?file_id=2530&type=bug
png

png 2020-01-30-141606_maim.png (7,868) 2020-01-30 14:21
https://zandronum.com/tracker/file_download.php?file_id=2531&type=bug
png

png 2020-01-30-141621_maim.png (5,742) 2020-01-30 14:22
https://zandronum.com/tracker/file_download.php?file_id=2532&type=bug
png

png 2020-01-30-141638_maim.png (14,659) 2020-01-30 14:22
https://zandronum.com/tracker/file_download.php?file_id=2533&type=bug
png

png 2020-01-30-141649_maim.png (8,763) 2020-01-30 14:22
https://zandronum.com/tracker/file_download.php?file_id=2534&type=bug
png

png 2020-01-30-141713_maim.png (5,185) 2020-01-30 14:23
https://zandronum.com/tracker/file_download.php?file_id=2535&type=bug
png

png 2020-01-30-141726_maim.png (3,696) 2020-01-30 14:23
https://zandronum.com/tracker/file_download.php?file_id=2536&type=bug
png

png 2020-01-30-141743_maim.png (2,517) 2020-01-30 14:23
https://zandronum.com/tracker/file_download.php?file_id=2537&type=bug
png

png 2020-01-30-141821_maim.png (7,903) 2020-01-30 14:24
https://zandronum.com/tracker/file_download.php?file_id=2538&type=bug
png

png 2020-01-30-141838_maim.png (4,081) 2020-01-30 14:24
https://zandronum.com/tracker/file_download.php?file_id=2539&type=bug
png

png 2020-01-30-141852_maim.png (7,398) 2020-01-30 14:24
https://zandronum.com/tracker/file_download.php?file_id=2540&type=bug
png

png 2020-01-30-143050_maim.png (14,970) 2020-01-30 14:31
https://zandronum.com/tracker/file_download.php?file_id=2541&type=bug
png

png 2020-01-30-143307_maim.png (4,064) 2020-01-30 14:33
https://zandronum.com/tracker/file_download.php?file_id=2542&type=bug
png

png 2020-01-30-143359_maim.png (14,569) 2020-01-30 14:34
https://zandronum.com/tracker/file_download.php?file_id=2543&type=bug
png

png 2020-01-30-143438_maim.png (5,879) 2020-01-30 14:35
https://zandronum.com/tracker/file_download.php?file_id=2544&type=bug
png

png 2020-01-30-144027_maim.png (12,692) 2020-01-30 14:40
https://zandronum.com/tracker/file_download.php?file_id=2545&type=bug
png

png 2020-01-30-144128_maim.png (6,110) 2020-01-30 14:41
https://zandronum.com/tracker/file_download.php?file_id=2546&type=bug
png

png 2020-01-30-144154_maim.png (5,276) 2020-01-30 14:42
https://zandronum.com/tracker/file_download.php?file_id=2547&type=bug
png

png 2020-01-30-144252_maim.png (13,201) 2020-01-30 14:43
https://zandronum.com/tracker/file_download.php?file_id=2548&type=bug
png

png 2020-01-30-144307_maim.png (8,666) 2020-01-30 14:43
https://zandronum.com/tracker/file_download.php?file_id=2549&type=bug
png

png 2020-01-30-144334_maim.png (7,671) 2020-01-30 14:43
https://zandronum.com/tracker/file_download.php?file_id=2550&type=bug
png

png 2020-01-30-144407_maim.png (8,096) 2020-01-30 14:44
https://zandronum.com/tracker/file_download.php?file_id=2551&type=bug
png

png 2020-01-30-144430_maim.png (7,825) 2020-01-30 14:44
https://zandronum.com/tracker/file_download.php?file_id=2552&type=bug
png

png 2020-01-30-144741_maim.png (3,558) 2020-01-30 14:48
https://zandronum.com/tracker/file_download.php?file_id=2553&type=bug
png

png 2020-01-30-145221_maim.png (14,885) 2020-01-30 14:52
https://zandronum.com/tracker/file_download.php?file_id=2554&type=bug
png

png 2020-01-30-145530_maim.png (21,322) 2020-01-30 14:55
https://zandronum.com/tracker/file_download.php?file_id=2555&type=bug
png

png 2020-01-30-145808_maim.png (5,203) 2020-01-30 14:58
https://zandronum.com/tracker/file_download.php?file_id=2556&type=bug
png

png 2020-01-30-145822_maim.png (5,301) 2020-01-30 14:58
https://zandronum.com/tracker/file_download.php?file_id=2557&type=bug
png

png 2020-06-26-051103_maim.png (21,456) 2020-06-26 05:11
https://zandronum.com/tracker/file_download.php?file_id=2616&type=bug
png

png 2020-06-26-052221_maim.png (3,384) 2020-06-26 05:22
https://zandronum.com/tracker/file_download.php?file_id=2617&type=bug
png

png qt5-fusion-style-qdialogbuttonbox-reference.png (21,004) 2020-06-26 23:12
https://zandronum.com/tracker/file_download.php?file_id=2626&type=bug
png

jpg qt-2022-12-31-1207_englishbuttons.jpg (7,939) 2022-12-31 11:09
https://zandronum.com/tracker/file_download.php?file_id=2815&type=bug
jpg

jpg qt-2022-12-31-1208_polishbuttons.jpg (9,464) 2022-12-31 11:09
https://zandronum.com/tracker/file_download.php?file_id=2816&type=bug
jpg
Issue History
2019-07-12 18:24WubTheCaptainNew Issue
2019-07-12 18:25WubTheCaptainRelationship addedrelated to 0003636
2019-07-12 18:25WubTheCaptainNote Added: 0020874
2019-07-12 18:26WubTheCaptainNote Edited: 0020874bug_revision_view_page.php?bugnote_id=20874#r12713
2019-07-12 18:26WubTheCaptainNote Edited: 0020874bug_revision_view_page.php?bugnote_id=20874#r12714
2019-07-12 18:27WubTheCaptainReproducibilityalways => N/A
2020-01-30 14:14WubTheCaptainAssigned To => WubTheCaptain
2020-01-30 14:14WubTheCaptainStatusnew => assigned
2020-01-30 14:19WubTheCaptainFile Added: 2020-01-30-141415_maim.png
2020-01-30 14:19WubTheCaptainFile Added: 2020-01-30-141431_maim.png
2020-01-30 14:19WubTheCaptainFile Added: 2020-01-30-141441_maim.png
2020-01-30 14:20WubTheCaptainFile Added: 2020-01-30-141459_maim.png
2020-01-30 14:20WubTheCaptainFile Added: 2020-01-30-141509_maim.png
2020-01-30 14:20WubTheCaptainFile Added: 2020-01-30-141522_maim.png
2020-01-30 14:21WubTheCaptainFile Added: 2020-01-30-141539_maim.png
2020-01-30 14:21WubTheCaptainFile Added: 2020-01-30-141557_maim.png
2020-01-30 14:21WubTheCaptainFile Added: 2020-01-30-141606_maim.png
2020-01-30 14:22WubTheCaptainFile Added: 2020-01-30-141621_maim.png
2020-01-30 14:22WubTheCaptainFile Added: 2020-01-30-141638_maim.png
2020-01-30 14:22WubTheCaptainFile Added: 2020-01-30-141649_maim.png
2020-01-30 14:23WubTheCaptainFile Added: 2020-01-30-141713_maim.png
2020-01-30 14:23WubTheCaptainFile Added: 2020-01-30-141726_maim.png
2020-01-30 14:23WubTheCaptainFile Added: 2020-01-30-141743_maim.png
2020-01-30 14:24WubTheCaptainFile Added: 2020-01-30-141821_maim.png
2020-01-30 14:24WubTheCaptainFile Added: 2020-01-30-141838_maim.png
2020-01-30 14:24WubTheCaptainFile Added: 2020-01-30-141852_maim.png
2020-01-30 14:28WubTheCaptainNote Added: 0021164
2020-01-30 14:28WubTheCaptainAssigned ToWubTheCaptain =>
2020-01-30 14:28WubTheCaptainStatusassigned => acknowledged
2020-01-30 14:29WubTheCaptainNote Edited: 0021164bug_revision_view_page.php?bugnote_id=21164#r12982
2020-01-30 14:29WubTheCaptainNote Edited: 0021164bug_revision_view_page.php?bugnote_id=21164#r12983
2020-01-30 14:31WubTheCaptainFile Added: 2020-01-30-143050_maim.png
2020-01-30 14:33WubTheCaptainFile Added: 2020-01-30-143307_maim.png
2020-01-30 14:34WubTheCaptainFile Added: 2020-01-30-143359_maim.png
2020-01-30 14:35WubTheCaptainFile Added: 2020-01-30-143438_maim.png
2020-01-30 14:39WubTheCaptainPrioritylow => none
2020-01-30 14:39WubTheCaptainSeverityminor => tweak
2020-01-30 14:40WubTheCaptainFile Added: 2020-01-30-144027_maim.png
2020-01-30 14:41WubTheCaptainFile Added: 2020-01-30-144128_maim.png
2020-01-30 14:42WubTheCaptainFile Added: 2020-01-30-144154_maim.png
2020-01-30 14:43WubTheCaptainFile Added: 2020-01-30-144252_maim.png
2020-01-30 14:43WubTheCaptainFile Added: 2020-01-30-144307_maim.png
2020-01-30 14:43WubTheCaptainFile Added: 2020-01-30-144334_maim.png
2020-01-30 14:44WubTheCaptainFile Added: 2020-01-30-144407_maim.png
2020-01-30 14:44WubTheCaptainFile Added: 2020-01-30-144430_maim.png
2020-01-30 14:46WubTheCaptainNote Edited: 0021164bug_revision_view_page.php?bugnote_id=21164#r12984
2020-01-30 14:48WubTheCaptainFile Added: 2020-01-30-144741_maim.png
2020-01-30 14:51WubTheCaptainNote Edited: 0021164bug_revision_view_page.php?bugnote_id=21164#r12985
2020-01-30 14:52WubTheCaptainFile Added: 2020-01-30-145221_maim.png
2020-01-30 14:54WubTheCaptainNote Edited: 0021164bug_revision_view_page.php?bugnote_id=21164#r12986
2020-01-30 14:55WubTheCaptainFile Added: 2020-01-30-145530_maim.png
2020-01-30 14:56WubTheCaptainNote Edited: 0021164bug_revision_view_page.php?bugnote_id=21164#r12987
2020-01-30 14:56WubTheCaptainNote Edited: 0021164bug_revision_view_page.php?bugnote_id=21164#r12988
2020-01-30 14:56WubTheCaptainNote Edited: 0021164bug_revision_view_page.php?bugnote_id=21164#r12989
2020-01-30 14:58WubTheCaptainFile Added: 2020-01-30-145808_maim.png
2020-01-30 14:58WubTheCaptainFile Added: 2020-01-30-145822_maim.png
2020-01-30 14:59WubTheCaptainNote Edited: 0021164bug_revision_view_page.php?bugnote_id=21164#r12990
2020-01-30 15:01WubTheCaptainNote Edited: 0021164bug_revision_view_page.php?bugnote_id=21164#r12991
2020-01-30 15:02WubTheCaptainNote Edited: 0021164bug_revision_view_page.php?bugnote_id=21164#r12992
2020-01-30 15:02WubTheCaptainNote Edited: 0021164bug_revision_view_page.php?bugnote_id=21164#r12993
2020-01-30 15:06WubTheCaptainNote Edited: 0021164bug_revision_view_page.php?bugnote_id=21164#r12994
2020-01-30 15:09WubTheCaptainNote Edited: 0021164bug_revision_view_page.php?bugnote_id=21164#r12995
2020-01-30 15:10WubTheCaptainNote Edited: 0021164bug_revision_view_page.php?bugnote_id=21164#r12996
2020-01-30 15:18WubTheCaptainRelationship addedrelated to 0003753
2020-06-26 05:10WubTheCaptainNote Added: 0021472
2020-06-26 05:11WubTheCaptainFile Added: 2020-06-26-051103_maim.png
2020-06-26 05:14WubTheCaptainNote Edited: 0021472bug_revision_view_page.php?bugnote_id=21472#r13217
2020-06-26 05:22WubTheCaptainFile Added: 2020-06-26-052221_maim.png
2020-06-26 05:24WubTheCaptainNote Added: 0021473
2020-06-26 23:11WubTheCaptainNote Added: 0021482
2020-06-26 23:11WubTheCaptainNote Edited: 0021482bug_revision_view_page.php?bugnote_id=21482#r13237
2020-06-26 23:12WubTheCaptainFile Added: qt5-fusion-style-qdialogbuttonbox-reference.png
2020-06-26 23:21Blzut3Note Added: 0021483
2021-12-27 18:29WubTheCaptainNote Added: 0022014
2021-12-27 22:56ZalewaNote Added: 0022019
2021-12-27 23:39ZalewaNote Added: 0022021
2021-12-28 10:05WubTheCaptainNote Added: 0022023
2021-12-28 10:06WubTheCaptainNote Edited: 0022023bug_revision_view_page.php?bugnote_id=22023#r13518
2021-12-29 14:04ZalewaNote Added: 0022048
2021-12-29 15:03ZalewaNote Added: 0022051
2021-12-30 11:11WubTheCaptainNote Added: 0022052
2022-09-10 14:37ZalewaTarget Version => 1.4.0
2022-12-29 22:32ZalewaAssigned To => Zalewa
2022-12-29 22:32ZalewaStatusacknowledged => assigned
2022-12-30 21:36ZalewaNote Added: 0022578
2022-12-30 22:44ZalewaNote Added: 0022579
2022-12-30 22:44ZalewaStatusassigned => feedback
2022-12-30 22:44ZalewaNote Edited: 0022579bug_revision_view_page.php?bugnote_id=22579#r13825
2022-12-31 00:20WubTheCaptainNote Added: 0022581
2022-12-31 00:20WubTheCaptainStatusfeedback => assigned
2022-12-31 00:20WubTheCaptainNote Added: 0022582
2022-12-31 00:21WubTheCaptainNote Edited: 0022581bug_revision_view_page.php?bugnote_id=22581#r13827
2022-12-31 00:25WubTheCaptainNote Edited: 0022582bug_revision_view_page.php?bugnote_id=22582#r13829
2022-12-31 00:25WubTheCaptainNote Edited: 0022582bug_revision_view_page.php?bugnote_id=22582#r13830
2022-12-31 00:27WubTheCaptainNote Edited: 0022582bug_revision_view_page.php?bugnote_id=22582#r13831
2022-12-31 00:30WubTheCaptainNote Added: 0022583
2022-12-31 03:11WubTheCaptainNote Edited: 0022582bug_revision_view_page.php?bugnote_id=22582#r13841
2022-12-31 03:12WubTheCaptainNote Added: 0022593
2022-12-31 04:07WubTheCaptainNote Added: 0022600
2022-12-31 11:09ZalewaFile Added: qt-2022-12-31-1207_englishbuttons.jpg
2022-12-31 11:09ZalewaFile Added: qt-2022-12-31-1208_polishbuttons.jpg
2022-12-31 11:20ZalewaNote Added: 0022609
2022-12-31 11:20ZalewaStatusassigned => needs review
2022-12-31 11:21ZalewaRelationship addedparent of 0004074
2022-12-31 11:22ZalewaRelationship addedparent of 0004075
2022-12-31 11:23ZalewaRelationship addedparent of 0004073
2022-12-31 11:24ZalewaRelationship addedparent of 0004076
2022-12-31 11:24ZalewaRelationship addedparent of 0004077
2023-01-03 19:53ZalewaNote Added: 0022627
2023-01-03 20:02ZalewaNote Edited: 0022627bug_revision_view_page.php?bugnote_id=22627#r13870
2023-01-05 12:31ZalewaNote Added: 0022663
2023-01-05 12:31ZalewaStatusneeds review => needs testing
2023-02-19 14:13ZalewaStatusneeds testing => resolved
2023-02-19 14:13ZalewaFixed in Version => 1.4.0
2023-02-19 14:13ZalewaResolutionopen => fixed
2024-11-03 19:10ZalewaStatusresolved => closed

Notes
(0020874)
WubTheCaptain   
2019-07-12 18:25   
(edited on: 2019-07-12 18:26)
Reporting this as epic category new issue, because it seems I've already forgotten in the past to report each issue individually. This is to remind me I should report those new issues.

(0021164)
WubTheCaptain   
2020-01-30 14:28   
(edited on: 2020-01-30 15:10)
The attached screenshots are from Doomseeker 1.3.1, from various parts of the program. Notable things:
  • "Close" doesn't always have the cross icon.
  • "Cancel" doesn't always have the cross icon.
  • "Clear" doesn't always have the cross icon.
  • Many "Close" buttons are (natively) just "OK" with an arrow in Qt and some places (error messages), instead of a "Close" button.
  • "Remove" is sometimes called "Delete".
  • "UPDATE!" and "Download" may be different.
  • "Add defaults" button may be aligned differently with the other buttons.
  • Mixed capitalization.
  • Password prompts may be missing the small "Clear" (?) button.
  • Idgames URL being configurable (why?) but Wad-Archives URL not.
  • "Copy to clipboard" and "Copy all to clipboard".
  • Some settings being presented as questions (with a question mark) rather than... not.
  • Different font typefaces and sizes used in "close" dialogs (Program Args. vs JSON library license).
  • Using a cross icon in place of a minus icon, and vice versa.
  • "Program arguments" window title not being prefixed with "Doomseeker -" (not pictured).
  • "Doomseeker - Copy Text" being used as a window title (not pictured), with "JSON library license" text in the window itself. (Should be "Doomseeker – JSON library license" or simply "JSON library license".)
  • The pencil icon in Doomseeker not matching the pencil icon used on the tracker (not pictured). 😀


(0021472)
WubTheCaptain   
2020-06-26 05:10   
(edited on: 2020-06-26 05:14)
  • Different dialogs have inconsistent geometry. E.g. some widgets may be X-positioned at 9, some at 0, some at 1, etc.
  • Buttons are not often of equal width – sometimes acceptable –, but worse is when they don't have equal padding (ignoring translations). E.g. compare btnUpdatesDiscard and btnUpdatesDownloadAndInstall in mainwindow.ui (or nearly any other example given here).


(0021473)
WubTheCaptain   
2020-06-26 05:24   
  • Create Game dialog mocks QWizard horizontal rule badly. (Likely to be redesigned with 0003480, though.)
(0021482)
WubTheCaptain   
2020-06-26 23:11   
  • Buttons without icons might be 23 pixels tall, with icons 24 pixels tall.

Honestly, a lot of these are issues with Qt itself.

(0021483)
Blzut3   
2020-06-26 23:21   
Yeah one thing to keep in mind is that we aren't one of those that reject the operating system theme and substitute our own. (Something I absolutely despise.) So there's always going to be some level of inconsistency since we support multiple platforms, which each support multiple themes (light and dark for example). Now that isn't to say that we haven't made errors, and there may even be ways that we can ask Qt what the correct decision is. Just be mindful that some things may be out of our control.
(0022014)
WubTheCaptain   
2021-12-27 18:29   
Target 1.3.3? Because of cleaning up inconsistent language (0003942) too.
(0022019)
Zalewa   
2021-12-27 22:56   
Quote from WubTheCaptain
Target 1.3.3? Because of cleaning up inconsistent language (0003942) too.

Maybe. Or at least partially. There's lots of stuff to go through here and going just through the texts requires lots of effort.

Quote
"Close" doesn't always have the cross icon.
"Cancel" doesn't always have the cross icon.
"Clear" doesn't always have the cross icon.

The system applies the icon when the button is created by the Qt's button box, but some of those buttons are added manually by us and only share the same text with the button box's. On Windows there are no icons on those buttons whatsoever. The theme you're using seems to icon the buttons partially only.

Quote
Many "Close" buttons are (natively) just "OK" with an arrow in Qt and some places (error messages), instead of a "Close" button.

This is fine (??)

Quote
window title not being prefixed with "Doomseeker -"


Inadvertendly I pointed this out in comment 0003942:0022012 too.

Quote
Different dialogs have inconsistent geometry. E.g. some widgets may be X-positioned at 9, some at 0, some at 1, etc.

I think that the config dialog indeed has too much padding but what do you mean with the X-positioning at 9 vs at 0?
(0022021)
Zalewa   
2021-12-27 23:39   
Double padding in the config box removed:'https://bitbucket.org/Doomseeker/doomseeker/commits/d15f11eb1a231a9534d0402136c57ae52c1c8678 [^]'
(0022023)
WubTheCaptain   
2021-12-28 10:05   
(edited on: 2021-12-28 10:06)
Quote from Zalewa
The system applies the icon when the button is created by the Qt's button box, but some of those buttons are added manually by us and only share the same text with the button box's.

So I guess my point was to say we don't use Qt's button box everywhere, where the Qt button box can be used as a reference ("Cancel", "OK", etc). Consistent theming and easy localization. Some end up having to be translated manually by us. I don't understand why this is so, right now.
src/core/translations/ca_ES.ts:        <source>Cancel</source>
src/core/translations/ca_ES.ts:        <translation>Cancelar</translation>

Quote from Zalewa
but what do you mean with the X-positioning at 9 vs at 0?

I can't remember anymore, sorry. Maybe this:
$ grep -r "<x>0</x>" src/ | wc -l
101
$ grep -r "<x>1</x>" src/ | wc -l
21
$ grep -r "<x>9</x>" src/ | wc -l
0

The "9" may have been the double-padding you mentioned, and me measuring with a measuring tool in an image editor from screenshots of the program.

(0022048)
Zalewa   
2021-12-29 14:04   
Removed the question marks from the checkboxes in the IRC chat logs options:'https://bitbucket.org/Doomseeker/doomseeker/commits/15c8fc7fbd65c309dd39f88b5997e593529ee1f2 [^]'
(0022051)
Zalewa   
2021-12-29 15:03   
Also removed the padding around the dockable widgets and the server list, making everything touch the borders of the window. Personally I think it makes the UI neater and cleaner, but depending on the user's personal preferences and the OS theme this may be viewed by others as either an improvement or a degradation. In any case, there's always `git revert`

'https://bitbucket.org/Doomseeker/doomseeker/commits/37c76232f79dfa60a04f79a7017832464b624aae [^]'
(0022052)
WubTheCaptain   
2021-12-30 11:11   
Quote from Zalewa
Also removed the padding around the dockable widgets and the server list, making everything touch the borders of the window.

I personally think this is a regression too, particularly for the server filter.
(0022578)
Zalewa   
2022-12-30 21:36   
Considerable amount of commits today to clean up the inconsistencies:
- IP2C updater buttons use natural capitalization.
- All "Browse" buttons will now use the open icon and show "Browse" tooltip or text.
- 'D' icon will now appear on all "Default" buttons.
- Use the "remove" word instead of "delete".
- The Hide/Reveal push button in the server passwords config replaced with a checkbox, because other places have checkboxes too.
- Icon/theme inconsistencies with "Close", "Cancel", "OK" resolved by using the standard buttons everywhere. Note that these buttons may still appear next to custom buttons with custom icons, which is intended.
- Use a broom icon on "Clear" buttons instead of the red X, or use the "edit-clear" icon as defined by freedesktop if available.
- Use natural capitalization on buttons. I might've missed some, though.
- Both "Add defaults"/Add/Remove layouts will now appear the same.
- Say Doomseeker in the Program args help box.
(0022579)
Zalewa   
2022-12-30 22:44   
The remaining issues:

Quote from WubTheCaptain
Many "Close" buttons are (natively) just "OK" with an arrow in Qt and some places (error messages), instead of a "Close" button.

This problem starts in the "About Qt" dialog which is produced 100% by Qt and has the "OK" button instead of "Close". Then, the default button for the critical, warning and info message boxes is also "OK", not "Close". I think that the "OK" and "Close" buttons can be considered as synonymous when the dialog box has only one button, and ambiguous if they both are in the dialog box (this case doesn't occur, however). So, I'm not especially aggravated that there's an "OK" button that does the same thing as "Close" would do. However, the inconsistency is still noticeable when you compare the "Program args", our own "About" and "About Qt" boxes where the first 2 have "Close" while the Qt box has "OK". If we feel particularly pedantic I can change the "Close" button in both of those cases to "OK", so that at least we have some consistency around the help dialogs.

Another thing is with the positioning of the buttons. It can be either centered or laid out with the OS preferences (right-aligned). I actually don't know if there are any design guidelines out there explaining when you should prefer one layout over the another, but Doomseeker is certainly not consistent here. I don't think we have any case where the centrally laid out buttons would give any advantage, so maybe I should just right-align them everywhere? In places where they are currently centrally aligned, that is.

Quote from WubTheCaptain
Password prompts may be missing the small "Clear" (?) button.

In the IRC connect box, IRC network definition and the nickserv password input, right? I'll take care of that. Then again there was the idea 0003289, which with everyone moving to Discord doesn't look so out-of-the-question anymore.

Quote from WubTheCaptain
Idgames URL being configurable (why?)

Just in case. It was actually wrong to not permit the same for Wad Archive, but Wad Archive is dead and gone, so problem has resolved itself on its own.

Quote from WubTheCaptain
"Copy to clipboard" and "Copy all to clipboard".

Actually there is a small semantic difference between those two buttons. Both of them could have the word "all", but I don't view this difference as a particular problem.

Quote from WubTheCaptain
Using a cross icon in place of a minus icon, and vice versa.

Where? There's only one case where the minus icon is used: in the pinned servers config box. Do you mean that the "minus" should mean "remove"? Well, perhaps, but Doomseeker uses the red X for that, and I don't think I'll be changing that. There was an inconsistency with the red X also being used for the "Clear" buttons, but those buttons will now have the "edit-clear" icon or the broom icon.

Quote from WubTheCaptain
The pencil icon in Doomseeker not matching the pencil icon used on the tracker (not pictured). 😀

I'll assume this is a joke.

Quote from WubTheCaptain
Different dialogs have inconsistent geometry. E.g. some widgets may be X-positioned at 9, some at 0, some at 1, etc.

Not sure if there are still dialogs that do that, but the differences in the margin between the widgets may be intentional.

Quote from WubTheCaptain
  • Buttons are not often of equal width – sometimes acceptable –, but worse is when they don't have equal padding (ignoring translations). E.g. compare btnUpdatesDiscard and btnUpdatesDownloadAndInstall in mainwindow.ui (or nearly any other example given here).

  • Buttons without icons might be 23 pixels tall, with icons 24 pixels tall.

Yeah, these two are aggravating, but the problem may not be solvable easily without risking doing something wrong for some system theme that is out there. Still, there are some potential fixes for that that I could try out. It seems that the extra padding can be added by overriding the application style (https://stackoverflow.com/a/20532712/1089357). Alternatively, it's also possible to increase the minimum width of those buttons so that they grow some padding, but that's also risky among the various themes where finding the right width value might not be easy. The vertical height 1 pixel discrepancy is something that I also see on Windows (particularly in the "Create game" box) but I have an idea on how to fix that without risking breaking the varying themes layouts. However, the fix I have in mind would need to be applied for each affected case individually and carefully. I'll try these things out and check if improvement can be achieved, but the text padding thing may be something that we'll have to give up on.

Anything else?

(0022581)
WubTheCaptain   
2022-12-31 00:20   
(edited on: 2022-12-31 00:21)
Quote from Zalewa
- 'D' icon will now appear on all "Default" buttons.

This consistency is arguably nicer, but I notice Qt also has a standard button "Reset" or "Restore Defaults" available.
Quote from Zalewa
Quote from WubTheCaptain
The pencil icon in Doomseeker not matching the pencil icon used on the tracker (not pictured). 😀

I'll assume this is a joke.

Yes.

(0022582)
WubTheCaptain   
2022-12-31 00:20   
(edited on: 2022-12-31 03:11)
0004077

I think I should've reported another issue for the following newly discovered things, but let's make a note.
I see it wasn't mentioned here previously, but looking at src/core/gui/mainwindow.ui in Qt Designer, I see the button has a green checkmark for "Download & Install". Four issues with this:
  • Capitalization;
  • The checkmark is inconsistent with another example of a red "Download" button found previously somewhere, or a standard button which looks like a green arrow pointing sideways saying "Update" (in the new IP2C window);
  • This also has a warning triangle next to it, although it's not arguably a warning where such warning triangle is normally used (e.g. "This path doesn't exist.");
  • Ending the "New updates are available:" and "Updates have been downloaded:" to colon punctuation may be inconsistent (e.g. compared to IP2C update dialogs).


(0022583)
WubTheCaptain   
2022-12-31 00:30   
Looking again at qt5-fusion-style-qdialogbuttonbox-reference.png, the capitalization is all over the place in Qt, so I should not bother about capitalization.
(0022593)
WubTheCaptain   
2022-12-31 03:12   
New issues (children): 0004073, 0004074, 0004075, 0004076, 0004077.
(0022600)
WubTheCaptain   
2022-12-31 04:07   
Quote from Zalewa
There was an inconsistency with the red X also being used for the "Clear" buttons, but those buttons will now have the "edit-clear" icon or the broom icon.

Fixing the issue may have created unexpected issues from user behavior adjusting to the new changes: 0004072, 0004078.
(0022609)
Zalewa   
2022-12-31 11:20   
Quote from WubTheCaptain
Looking again at qt5-fusion-style-qdialogbuttonbox-reference.png, the capitalization is all over the place in Qt, so I should not bother about capitalization.

Judging by this screen alone: it's not all over the place. The buttons on this screen have their text capitalized in accordance to the title capitalization rules in English. This article explains them succintly:'https://www.grammarly.com/blog/capitalization-in-the-titles/ [^]'

Now our own approach is to whether we consider the text in buttons as titles or not. Microsoft's design guide says to use the sentence-style capitalization in the buttons (https://learn.microsoft.com/en-us/windows/win32/uxguide/ctrl-command-buttons). Qt changes the capitalization depending on the language (qt-2022-12-31-1207_englishbuttons.jpg, qt-2022-12-31-1208_polishbuttons.jpg), which still sticks to the rules of title capitalization in both languages. We, however, have a luxury to ignore what Qt thinks about texts in buttons because there isn't a case where we would use a multi-word standard button. Also I prefer the Microsoft guideline here because when the buttons (or menu actions) get lengthy words their title capitalization begins to look ridiculous.

Also I missed the "Set Game" button previously:'https://bitbucket.org/Doomseeker/doomseeker/commits/92adb9948dc5b673b818c3d978056e67f131481f [^]'
(0022627)
Zalewa   
2023-01-03 19:53   
(edited on: 2023-01-03 20:02)
Missed the "Remote Console" context menu action:'https://bitbucket.org/Doomseeker/doomseeker/commits/1c8cc0b62d2a12cecf12ce440d31b22d190c0b83 [^]'

(0022663)
Zalewa   
2023-01-05 12:31   
Beta package for Windows available at the beta auto-update channel and at:
'https://devbuilds.drdteam.org/doomseeker/doomseeker-1.3.3~beta-230105-1140_windows.zip [^]'

Can someone find something that I missed?