Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003795Doomseeker[All Projects] Cleanuppublic2020-06-05 07:332021-08-07 16:52
ReporterWubTheCaptain 
Assigned ToBlzut3 
PrioritynoneSeveritytweakReproducibilityalways
StatusclosedResolutionwon't fix 
PlatformOSOS Version
Product Version1.3.1 
Target VersionFixed in Version 
Summary0003795: qt-json isn't a Git submodule
DescriptionI updated qt-json in issue 0003794 manually with patch files.
My issue isn't 0003310 here; my issue is that this patching can be ugly. 272 lines of changes in json.cpp and json.hpp individually making up a patch file, double that if you count the dupe copy in Wadseeker. It could've been easier like updating a Git submodule reference to a qt-json tree at referenced commit.
Quote
It may be better to use Git submodules (or something else) for qt-json
dependency in the future. For now, patching our copy is a quick fix
(without more intrusive changes to the build system).
Attached Files

- Relationships
related to 0003821closedBlzut3 Replacing Eili Reilin's JSON library (qt-json) with JSON support in Qt 

-  Notes
User avatar (0021421)
Blzut3 (administrator)
2020-06-08 04:22

 Not needed if we drop qt-json for Qt 5's JSON support.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2020-06-05 07:33 WubTheCaptain New Issue
2020-06-07 03:40 WubTheCaptain Relationship added related to 0003808
2020-06-07 03:41 WubTheCaptain Relationship deleted related to 0003808
2020-06-08 04:21 Blzut3 Relationship added related to 0003821
2020-06-08 04:22 Blzut3 Note Added: 0021421
2020-06-08 04:22 Blzut3 Status new => resolved
2020-06-08 04:22 Blzut3 Resolution open => won't fix
2020-06-08 04:22 Blzut3 Assigned To => Blzut3
2021-08-07 16:52 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker