Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003821Doomseeker[All Projects] Epicpublic2020-06-08 02:302020-06-08 14:08
ReporterWubTheCaptain 
Assigned To 
PrioritynoneSeverityfeatureReproducibilityN/A
StatusconfirmedResolutionopen 
PlatformOSOS Version
Product Version1.3.1 
Target VersionFixed in Version 
Summary0003821: Replacing Eili Reilin's JSON library (qt-json) with JSON support in Qt
Description0003794:0021408:
Quote from Blzut3
Given that Qt JSON was added years before we added support for Qt5 much less dropped Qt4 support, should we instead have a ticket for switching to Qt 5's own JSON classes?

Maintaining that copy of Eili Reilin's qt-json library has proved burdensome. It seems sensible to me to drop qt-json and switch to Qt5's JSON support.
Additional Informationhttps://doc.qt.io/qt-5/json.html [^]
Attached Files

- Relationships
related to 0003794resolvedWubTheCaptain qt-json is older than aa0930a (stray #include <iostream>) 
related to 0003795resolvedBlzut3 qt-json isn't a Git submodule 
related to 0003796resolvedWubTheCaptain qt-json dependency is duplicated to different files (2nd report) 

-  Notes
User avatar (0021416)
WubTheCaptain (developer)
2020-06-08 02:34

This is theoretically an epic category issue, because the GUI options to display Eili Reilin's JSON library license text would need to be stripped out too. And strip the build system too.
I'm not sure how to categorize a new child issue for that, so here's a note.
User avatar (0021436)
Zalewa (developer)
2020-06-08 13:46

Despite this having no apparent functional benefit, I support this change. Dropping external dependency that can be fully replaced by another dependency we need either way is always good, and in this case the costs should be minimal.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: Pol M Zalewa
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2020-06-08 02:30 WubTheCaptain New Issue
2020-06-08 02:31 WubTheCaptain Relationship added related to 0003794
2020-06-08 02:31 WubTheCaptain Description Updated View Revisions
2020-06-08 02:34 WubTheCaptain Note Added: 0021416
2020-06-08 02:34 WubTheCaptain Category Cleanup => Epic
2020-06-08 02:35 WubTheCaptain Additional Information Updated View Revisions
2020-06-08 04:21 Blzut3 Relationship added related to 0003795
2020-06-08 04:23 Blzut3 Relationship added related to 0003796
2020-06-08 05:37 WubTheCaptain Status new => acknowledged
2020-06-08 13:46 Zalewa Note Added: 0021436
2020-06-08 14:08 WubTheCaptain Status acknowledged => confirmed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2020 MantisBT Team
Powered by Mantis Bugtracker