MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003795Doomseeker[All Projects] Cleanuppublic2020-06-05 07:332021-08-07 16:52
ReporterWubTheCaptain 
Assigned ToBlzut3 
PrioritynoneSeveritytweakReproducibilityalways
StatusclosedResolutionwon't fix 
PlatformOSOS Version
Product Version1.3.1 
Target VersionFixed in Version 
Summary0003795: qt-json isn't a Git submodule
DescriptionI updated qt-json in issue 0003794 manually with patch files.
My issue isn't 0003310 here; my issue is that this patching can be ugly. 272 lines of changes in json.cpp and json.hpp individually making up a patch file, double that if you count the dupe copy in Wadseeker. It could've been easier like updating a Git submodule reference to a qt-json tree at referenced commit.
Quote
It may be better to use Git submodules (or something else) for qt-json
dependency in the future. For now, patching our copy is a quick fix
(without more intrusive changes to the build system).
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0003821closed Blzut3 Replacing Eili Reilin's JSON library (qt-json) with JSON support in Qt 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-06-05 07:33WubTheCaptainNew Issue
2020-06-07 03:40WubTheCaptainRelationship addedrelated to 0003808
2020-06-07 03:41WubTheCaptainRelationship deletedrelated to 0003808
2020-06-08 04:21Blzut3Relationship addedrelated to 0003821
2020-06-08 04:22Blzut3Note Added: 0021421
2020-06-08 04:22Blzut3Statusnew => resolved
2020-06-08 04:22Blzut3Resolutionopen => won't fix
2020-06-08 04:22Blzut3Assigned To => Blzut3
2021-08-07 16:52Blzut3Statusresolved => closed

Notes
(0021421)
Blzut3   
2020-06-08 04:22   
Not needed if we drop qt-json for Qt 5's JSON support.