MantisBT - Doomseeker | ||||||||||
View Issue Details | ||||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | |||||
0003795 | Doomseeker | [All Projects] Cleanup | public | 2020-06-05 07:33 | 2021-08-07 16:52 | |||||
Reporter | WubTheCaptain | |||||||||
Assigned To | Blzut3 | |||||||||
Priority | none | Severity | tweak | Reproducibility | always | |||||
Status | closed | Resolution | won't fix | |||||||
Platform | OS | OS Version | ||||||||
Product Version | 1.3.1 | |||||||||
Target Version | Fixed in Version | |||||||||
Summary | 0003795: qt-json isn't a Git submodule | |||||||||
Description | I updated qt-json in issue 0003794 manually with patch files. My issue isn't 0003310 here; my issue is that this patching can be ugly. 272 lines of changes in json.cpp and json.hpp individually making up a patch file, double that if you count the dupe copy in Wadseeker. It could've been easier like updating a Git submodule reference to a qt-json tree at referenced commit. QuoteIt may be better to use Git submodules (or something else) for qt-json dependency in the future. For now, patching our copy is a quick fix (without more intrusive changes to the build system). | |||||||||
Steps To Reproduce | ||||||||||
Additional Information | ||||||||||
Tags | No tags attached. | |||||||||
Relationships |
| |||||||||
Attached Files | ||||||||||
Issue History | ||||||||||
Date Modified | Username | Field | Change | |||||||
2020-06-05 07:33 | WubTheCaptain | New Issue | ||||||||
2020-06-07 03:40 | WubTheCaptain | Relationship added | related to 0003808 | |||||||
2020-06-07 03:41 | WubTheCaptain | Relationship deleted | related to 0003808 | |||||||
2020-06-08 04:21 | Blzut3 | Relationship added | related to 0003821 | |||||||
2020-06-08 04:22 | Blzut3 | Note Added: 0021421 | ||||||||
2020-06-08 04:22 | Blzut3 | Status | new => resolved | |||||||
2020-06-08 04:22 | Blzut3 | Resolution | open => won't fix | |||||||
2020-06-08 04:22 | Blzut3 | Assigned To | => Blzut3 | |||||||
2021-08-07 16:52 | Blzut3 | Status | resolved => closed |
Notes | |||||
|
|||||
|
|