Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000580Zandronum[All Projects] Bugpublic2011-09-12 20:262018-09-30 22:12
ReporterBorg 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version98d 
Target Version3.0Fixed in Version3.0 
Summary0000580: A_CheckSight() works incorrect with spectators
DescriptionA_CheckSight() sometimes peform a jump (player in sight) when it should not
In code below, A_CheckSight(1) should jump to next frame when there
are no player near by.. but if some player appears in sight, Make state
should be called. Unfortunetly it does not happen always when it should.
I am speaking about clear situation when player is standing near ClipSpawn
and even looking at it.
Additional Informationactor ClipSpawnAmmo
{
Radius 20
Height 26
Speed 5
RenderStyle Translucent
Alpha 0.5
+NOBLOCKMAP
+DROPOFF
states
  {
  Spawn:
    CLIP AAA 5
    CLIP A 1 A_CheckFloor(1)
    wait
    CLIP A 50
    CLIP AAA 350
    CLIP A 10 A_SetTranslucent(0.0)
    goto Make
  Idle:
    CLIP A 10 A_CheckSight(1)
    goto Make
    CLIP A 10
    loop
  Make:
    CLIP A 0 A_PlaySound("misc/spawn",CHAN_BODY)
    CLIP A 0 A_SpawnItem("Clip")
    CLIP A 350 A_SpawnItem("ItemFog")
    CLIP AA 350
    goto Idle
  }
}
Attached Files

- Relationships

-  Notes
User avatar (0002377)
Torr Samaho (administrator)
2012-01-14 16:55

 I cannot exactly see from you description what happens and what you think should happen. Based on the summary I assume that you would like A_CheckSight to ignore spectators, right?
User avatar (0013840)
Borg (reporter)
2015-11-17 22:21

 Can be closed as no longer applicable.
Im using A_Look instead of A_CheckSight with works pefectly.
User avatar (0013848)
Dusk (developer)
2015-11-18 20:31

 Just because you are no longer affected doesn't mean that the problem suddenly ceases to exist.
User avatar (0013849)
Borg (reporter)
2015-11-18 21:32

 Oh well, you are correct..
Question is, if I used A_CheckSight correctly..

Anyway, taking into consideration nearly 4 years of no comments from others,
seems noone else is affected ;)
User avatar (0014076)
Dusk (developer)
2016-01-12 11:55

 Sometimes tickets just fall in limbo... this is definitely a bug though. A_CheckSight shouldn't be reacting to spectators like this.
User avatar (0014079)
cobalt (updater)
2016-01-12 19:12

 Issue addressed by commit 84d9a31fdd2f: Fixed: A_CheckSight would not jump if a spectator was in the line of sight of the calling actor, fixes 580
Committed by Teemu Piippo [Dusk] on Wednesday 31 December 1969 23:59:57

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/thingdef/thingdef_codeptr.cpp | 4 ++++
 2 files changed, 5 insertions(+), 0 deletions(-)
User avatar (0014178)
Ru5tK1ng (updater)
2016-01-24 19:16

 I tested your code with the latest build and it seems to work as you somewhat described. The spawner always spawns 'clips' when a player is in sight. The spawner still goes to it's make state one time eventually, even if there are no players in sight.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2011-09-12 20:26 Borg New Issue
2012-01-14 16:55 Torr Samaho Note Added: 0002377
2012-01-14 16:55 Torr Samaho Status new => feedback
2012-06-09 13:22 Torr Samaho Category General => Bug
2015-11-17 22:21 Borg Note Added: 0013840
2015-11-17 22:21 Borg Status feedback => new
2015-11-18 20:31 Dusk Note Added: 0013848
2015-11-18 21:32 Borg Note Added: 0013849
2016-01-12 11:54 Dusk Assigned To => Dusk
2016-01-12 11:54 Dusk Status new => assigned
2016-01-12 11:55 Dusk Note Added: 0014076
2016-01-12 19:12 cobalt Status assigned => needs testing
2016-01-12 19:12 cobalt Target Version => 3.0
2016-01-12 19:12 cobalt Description Updated View Revisions
2016-01-12 19:12 cobalt Additional Information Updated View Revisions
2016-01-12 19:12 cobalt Note Added: 0014079
2016-01-24 19:16 Ru5tK1ng Note Added: 0014178
2016-01-31 21:45 Ru5tK1ng Status needs testing => resolved
2016-01-31 21:45 Ru5tK1ng Resolution open => fixed
2016-01-31 21:45 Ru5tK1ng Fixed in Version => 3.0
2016-01-31 21:45 Ru5tK1ng Description Updated View Revisions
2016-01-31 21:45 Ru5tK1ng Additional Information Updated View Revisions
2018-09-30 22:12 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker