Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004054Doomseeker[All Projects] Bugpublic2022-11-11 15:142022-11-11 20:02
ReporterWubTheCaptain 
Assigned To 
PrioritylowSeveritytweakReproducibilityalways
StatusnewResolutionopen 
PlatformOSOS Version
Product Version1.3.3 
Target VersionFixed in Version 
Summary0004054: Doomseeker's Git repository doesn't have annotated tags for releases (only lightweight tags)
DescriptionDoomseeker's Git repository doesn't have annotated tags for releases. Only lightweight tags have been historically added to releases, which are meant for "private or temporary object labels".

Quote from git-tag(1)
Annotated tags are meant for release while lightweight tags are meant for private or temporary object labels. For this reason, some git commands for naming objects (like git describe) will ignore lightweight tags by default.


This caused me an issue when I was trying to git describe a version I was using for testing another issue, and received an error.
Steps To Reproduce
$ git describe
fatal: No annotated tags can describe 'd7638cb2d2811d215db44b981592bb1c8aab630b'.
However, there were unannotated tags: try --tags.
$ git describe --tags
1.3.3-49-gd7638cb2

$ git tag
0.10b
0.11.1b
0.11b
0.12.1b
0.12.2b
0.12b
0.1a
0.2a
0.3a
0.4b
0.5b
0.6b
0.7b
0.8.1b
0.8.1b-p1
0.8.1b-p2
0.8.1b-p3
0.8b
0.9b
1.0
1.1
1.1-p1
1.2
1.3
1.3.1
1.3.2
1.3.3
Additional Informationhttps://git-scm.com/book/en/v2/Git-Basics-Tagging [^]

I actually noticed this in January 2022, but didn't consider its impact: 0003959:0022107
Attached Files

- Relationships

-  Notes
User avatar (0022489)
WubTheCaptain (reporter)
2022-11-11 15:14

I think the existing lightweight tags should be converted to annotated tags, to fix this issue. OpenPGP signatures are optional.
User avatar (0022491)
WubTheCaptain (reporter)
2022-11-11 15:26

I would also use the "v" prefix for annotated tags, e.g. v1.3.3. It's what git.git does:https://git.kernel.org/pub/scm/git/git.git/refs/ [^]
User avatar (0022495)
Zalewa (developer)
2022-11-11 20:01
edited on: 2022-11-11 20:02

We could use the tags to improve the versioning mechanism for the various components, so that I won't have to manually bump everything up. `git describe` is the tool for the job. But this requires proper naming scheme for the tags, and tagging each component separately. This would also incur some more complexity to the builder and the source code exporter, as of course the exported source cannot rely on `git describe` to do the job. I've done things like that before.


Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2022-11-11 15:14 WubTheCaptain New Issue
2022-11-11 15:14 WubTheCaptain Note Added: 0022489
2022-11-11 15:26 WubTheCaptain Note Added: 0022491
2022-11-11 20:01 Zalewa Note Added: 0022495
2022-11-11 20:02 Zalewa Note Edited: 0022495 View Revisions






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2022 MantisBT Team
Powered by Mantis Bugtracker