MantisBT - Doomseeker
View Issue Details
0004054Doomseeker[All Projects] Bugpublic2022-11-11 15:142024-11-03 18:55
WubTheCaptain 
Zalewa 
lowtweakalways
closedduplicate 
1.3.3 
1.5.01.4.1 
0004054: Doomseeker's Git repository doesn't have annotated tags for releases (only lightweight tags)
Doomseeker's Git repository doesn't have annotated tags for releases. Only lightweight tags have been historically added to releases, which are meant for "private or temporary object labels".

Quote from git-tag(1)
Annotated tags are meant for release while lightweight tags are meant for private or temporary object labels. For this reason, some git commands for naming objects (like git describe) will ignore lightweight tags by default.


This caused me an issue when I was trying to git describe a version I was using for testing another issue, and received an error.
$ git describe
fatal: No annotated tags can describe 'd7638cb2d2811d215db44b981592bb1c8aab630b'.
However, there were unannotated tags: try --tags.
$ git describe --tags
1.3.3-49-gd7638cb2

$ git tag
0.10b
0.11.1b
0.11b
0.12.1b
0.12.2b
0.12b
0.1a
0.2a
0.3a
0.4b
0.5b
0.6b
0.7b
0.8.1b
0.8.1b-p1
0.8.1b-p2
0.8.1b-p3
0.8b
0.9b
1.0
1.1
1.1-p1
1.2
1.3
1.3.1
1.3.2
1.3.3
'https://git-scm.com/book/en/v2/Git-Basics-Tagging [^]'

I actually noticed this in January 2022, but didn't consider its impact: 0003959:0022107
No tags attached.
duplicate of 0003971closed Zalewa No annotated Git tags are available (since the repository migration from Mercurial to Git) 
Issue History
2022-11-11 15:14WubTheCaptainNew Issue
2022-11-11 15:14WubTheCaptainNote Added: 0022489
2022-11-11 15:26WubTheCaptainNote Added: 0022491
2022-11-11 20:01ZalewaNote Added: 0022495
2022-11-11 20:02ZalewaNote Edited: 0022495bug_revision_view_page.php?bugnote_id=22495#r13765
2023-01-25 22:20ZalewaTarget Version => 1.5.0
2023-02-20 20:28ZalewaStatusnew => confirmed
2023-02-25 21:30ZalewaNote Added: 0022786
2023-02-25 21:30ZalewaRelationship addedduplicate of 0003971
2023-02-25 21:30ZalewaStatusconfirmed => resolved
2023-02-25 21:30ZalewaFixed in Version => 1.4.1
2023-02-25 21:30ZalewaResolutionopen => duplicate
2023-02-25 21:30ZalewaAssigned To => Zalewa
2024-11-03 18:55ZalewaStatusresolved => closed

Notes
(0022489)
WubTheCaptain   
2022-11-11 15:14   
I think the existing lightweight tags should be converted to annotated tags, to fix this issue. OpenPGP signatures are optional.
(0022491)
WubTheCaptain   
2022-11-11 15:26   
I would also use the "v" prefix for annotated tags, e.g. v1.3.3. It's what git.git does:'https://git.kernel.org/pub/scm/git/git.git/refs/ [^]'
(0022495)
Zalewa   
2022-11-11 20:01   
(edited on: 2022-11-11 20:02)
We could use the tags to improve the versioning mechanism for the various components, so that I won't have to manually bump everything up. `git describe` is the tool for the job. But this requires proper naming scheme for the tags, and tagging each component separately. This would also incur some more complexity to the builder and the source code exporter, as of course the exported source cannot rely on `git describe` to do the job. I've done things like that before.

(0022786)
Zalewa   
2023-02-25 21:30   
I just noticed this is a duplicate of 0003971. Closing it and will use 0003971 to track the problem because of precedence.