Zandronum Chat on our Discord Server Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003900Doomseeker[All Projects] Cleanuppublic2021-08-16 18:362021-08-17 22:09
ReporterWubTheCaptain 
Assigned To 
PrioritynoneSeveritytrivialReproducibilityalways
StatusacknowledgedResolutionopen 
PlatformOSOS Version
Product Version1.4 
Target VersionFixed in Version 
Summary0003900: Translations have remnant strings of now removed Eeli Reilin's QtJson library
DescriptionCommit fc903e1 removed QtJson library in favor of Qt's own Json classes. Translated strings were not removed.
Steps To Reproduce
$ grep -r "Eeli Reilin" .
./src/core/translations/ca_ES.ts:        <source>JSON library on BSD License (c) Eeli Reilin 2011 
:</source>
./src/core/translations/ca_ES.ts:        <translation>biblioteca JSON sota llicència BSD (c) Eeli 
Reilin 2011:</translation>
./src/core/translations/pl_PL.ts:        <source>JSON library on BSD License (c) Eeli Reilin 2011 
:</source>
./src/core/translations/pl_PL.ts:        <translation>Bibloteka JSON na licencji BSD (c) Eeli Reilin 
2011:</translation>
./src/core/translations/es_ES.ts:        <source>JSON library on BSD License (c) Eeli Reilin 2011 
:</source>
./src/core/translations/es_ES.ts:        <translation>biblioteca JSON bajo licencia BSD (c) Eeli 
Reilin 2011 :</translation>

Attached Files

- Relationships
child of 0003821needs testingBlzut3 Replacing Eili Reilin's JSON library (qt-json) with JSON support in Qt 

-  Notes
User avatar (0021741)
Blzut3 (administrator)
2021-08-17 00:44

Zalewa/Pol M, I believe this issue basically takes care of itself when you guys update the translations?
User avatar (0021743)
Zalewa (developer)
2021-08-17 06:28

These lines don't create any actual problems. The update procedure may mark them as "obsolete" by giving them an attribute with such name, but I can't recall right now if it ever removes anything. We can remove them from the ts files but, as I said, for the end program they are invisible.
User avatar (0021747)
Pol M (developer)
2021-08-17 22:09

As zalewa comments, these are harmless and don't need to be modified. Once there are actual changes to the translation these will be flagged as obsolete, but the build is completely unaffected whether the flag exists or not. I vote on not doing anything about it.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2021-08-16 18:36 WubTheCaptain New Issue
2021-08-16 18:36 WubTheCaptain Relationship added child of 0003824
2021-08-16 18:36 WubTheCaptain Relationship deleted child of 0003824
2021-08-16 18:36 WubTheCaptain Relationship added child of 0003821
2021-08-16 18:38 WubTheCaptain Summary Translations have remnants of removed Eeli Reilin's QtJson library => Translations have remnant strings of now removed Eeli Reilin's QtJson library
2021-08-17 00:44 Blzut3 Note Added: 0021741
2021-08-17 03:56 WubTheCaptain Status new => acknowledged
2021-08-17 06:28 Zalewa Note Added: 0021743
2021-08-17 22:09 Pol M Note Added: 0021747






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2021 MantisBT Team
Powered by Mantis Bugtracker