MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003900Doomseeker[All Projects] Cleanuppublic2021-08-16 18:362022-05-31 01:40
ReporterWubTheCaptain 
Assigned ToPol M 
PrioritynoneSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.3.3 
Target Version1.3.3Fixed in Version1.3.3 
Summary0003900: Translations have remnant strings of now removed Eeli Reilin's QtJson library
DescriptionCommit fc903e1 removed QtJson library in favor of Qt's own Json classes. Translated strings were not removed.
Steps To Reproduce
$ grep -r "Eeli Reilin" .
./src/core/translations/ca_ES.ts:        <source>JSON library on BSD License (c) Eeli Reilin 2011 
:</source>
./src/core/translations/ca_ES.ts:        <translation>biblioteca JSON sota llicència BSD (c) Eeli 
Reilin 2011:</translation>
./src/core/translations/pl_PL.ts:        <source>JSON library on BSD License (c) Eeli Reilin 2011 
:</source>
./src/core/translations/pl_PL.ts:        <translation>Bibloteka JSON na licencji BSD (c) Eeli Reilin 
2011:</translation>
./src/core/translations/es_ES.ts:        <source>JSON library on BSD License (c) Eeli Reilin 2011 
:</source>
./src/core/translations/es_ES.ts:        <translation>biblioteca JSON bajo licencia BSD (c) Eeli 
Reilin 2011 :</translation>

Additional Information
TagsNo tags attached.
Relationships
child of 0003821closed Blzut3 Replacing Eili Reilin's JSON library (qt-json) with JSON support in Qt 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-08-16 18:36WubTheCaptainNew Issue
2021-08-16 18:36WubTheCaptainRelationship addedchild of 0003824
2021-08-16 18:36WubTheCaptainRelationship deletedchild of 0003824
2021-08-16 18:36WubTheCaptainRelationship addedchild of 0003821
2021-08-16 18:38WubTheCaptainSummaryTranslations have remnants of removed Eeli Reilin's QtJson library => Translations have remnant strings of now removed Eeli Reilin's QtJson library
2021-08-17 00:44Blzut3Note Added: 0021741
2021-08-17 03:56WubTheCaptainStatusnew => acknowledged
2021-08-17 06:28ZalewaNote Added: 0021743
2021-08-17 22:09Pol MNote Added: 0021747
2021-12-27 14:50ZalewaAssigned To => Zalewa
2021-12-27 14:50ZalewaStatusacknowledged => assigned
2021-12-27 14:51ZalewaNote Added: 0022011
2021-12-27 18:29ZalewaAssigned ToZalewa => Pol M
2021-12-27 18:30ZalewaNote Added: 0022015
2022-01-16 15:38Pol MNote Added: 0022079
2022-01-16 15:38Pol MStatusassigned => needs review
2022-01-17 02:35WubTheCaptainStatusneeds review => resolved
2022-01-17 02:35WubTheCaptainFixed in Version => 1.3.3
2022-01-17 02:35WubTheCaptainResolutionopen => fixed
2022-01-17 02:35WubTheCaptainTarget Version => 1.3.3
2022-05-31 01:40WubTheCaptainStatusresolved => closed

Notes
(0021741)
Blzut3   
2021-08-17 00:44   
Zalewa/Pol M, I believe this issue basically takes care of itself when you guys update the translations?
(0021743)
Zalewa   
2021-08-17 06:28   
These lines don't create any actual problems. The update procedure may mark them as "obsolete" by giving them an attribute with such name, but I can't recall right now if it ever removes anything. We can remove them from the ts files but, as I said, for the end program they are invisible.
(0021747)
Pol M   
2021-08-17 22:09   
As zalewa comments, these are harmless and don't need to be modified. Once there are actual changes to the translation these will be flagged as obsolete, but the build is completely unaffected whether the flag exists or not. I vote on not doing anything about it.
(0022011)
Zalewa   
2021-12-27 14:51   
I will clean the obsoletes in the Polish translation in one go after I'm done with the language improvements.
(0022015)
Zalewa   
2021-12-27 18:30   
Removed all vanished/obsolete texts from the Polish translation. I can't touch the Catalan and Spanish ones before Pol updates them because the linguist tool actually uses those to provide tips for new translations if they're sufficiently similar.

'https://bitbucket.org/Doomseeker/doomseeker/commits/e2883afdb755ab537ad8e523cf9e7d47662acaef [^]'
(0022079)
Pol M   
2022-01-16 15:38   
'https://bitbucket.org/Doomseeker/doomseeker/pull-requests/7/translatations-spanish-catalan [^]'