Anonymous | Login | Signup for a new account | 2024-04-19 22:51 UTC |
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0003595 | Doomseeker | [All Projects] Documentation | public | 2019-01-06 07:25 | 2019-07-30 10:13 | ||||
Reporter | WubTheCaptain | ||||||||
Assigned To | Zalewa | ||||||||
Priority | normal | Severity | feature | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | 1.2 | ||||||||
Target Version | 1.3 | Fixed in Version | 1.3 | ||||||
Summary | 0003595: Contributor documentation is not yet available | ||||||||
Description | People will not likely find their way from the source distribution how to contribute to Doomseeker & Wadseeker. I propose adding some text to README or creating a CONTRIBUTING file with this information, and more. | ||||||||
Attached Files | 0001-Add-a-README-file-for-developers.patch [^] (6,308 bytes) 2019-06-23 02:22 [Show Content]
0002-README-dev-Add-linebreaks-etc-to-hg-clone-line.patch [^] (1,163 bytes) 2019-06-23 08:20 [Show Content] 0003-README-dev-Remove-section-on-unit-tests.patch [^] (1,052 bytes) 2019-06-23 08:20 [Show Content] | ||||||||
Relationships | ||||||||||||||||||||||||||
|
Notes | |
(0020304) WubTheCaptain (reporter) 2019-01-06 07:25 |
Probably a link to our issue tracker, at least. |
(0020311) Pol M (developer) 2019-01-16 00:06 |
In ticket 3444 Zalewa makes some great points that should be included ^-^ |
(0020809) WubTheCaptain (reporter) 2019-06-23 02:22 |
Patch by me, attached. |
(0020810) WubTheCaptain (reporter) 2019-06-23 02:29 edited on: 2019-06-23 02:29 |
Quote Spoilers for references included:
This patch makes mentions to things which other tickets should consider with implementation. I'll try to find their relationships. |
(0020812) Zalewa (developer) 2019-06-23 07:08 edited on: 2019-06-23 07:09 |
It's straight to the point, just the way I like it. Two remarks from me: 1. The .md format should maintain usability in the plain-text format as much as possible. This is achieved here, however I'd still like to nitpick about the `hg clone` line. Personally I prefer when command lines stand out in a way that makes them easy to copy and paste, especially if the command is short and fits within the column limit.
2. The unit testing engine is not entirely useless. Yes, it's crude and doesn't automagically translate #define macros to test cases and fixtures, but it does its job if you know how to use it. Its pro point is that it's straight-forward. Everything to know about it is in the code and it doesn't need any obscure rituals to use. It's partially why I've been delaying its replacement for so long. |
(0020813) WubTheCaptain (reporter) 2019-06-23 08:22 |
The first one is a fair point, although with CommonMark your exact example wouldn't do what you intended: the backticks would be visible. I addressed this in patch 0002, attached. As for your second point, I've decided to remove the section on unit tests (for now). |
(0020814) Zalewa (developer) 2019-06-23 09:34 |
Merged the patches as-is: 1.'https://bitbucket.org/Doomseeker/doomseeker/commits/44341d508b961e43c7d0fca1ffb21d5158ed1281 [^]' 2.'https://bitbucket.org/Doomseeker/doomseeker/commits/c9b9dcee3b4db3a9b5f353ba47349f15f9e51211 [^]' 3.'https://bitbucket.org/Doomseeker/doomseeker/commits/21392ebbfa73a797f61a01d0cd91569d5f53434f [^]' The end result is:'https://bitbucket.org/Doomseeker/doomseeker/src/default/README-dev.md [^]' Looks good to me. Resolve? |
(0020815) WubTheCaptain (reporter) 2019-06-23 09:40 edited on: 2019-06-23 09:41 |
I have personally used commonmark.js dingus as a reference for rendering, and thus don't really care for rendering issues which may be apparent on Bitbucket. (Maybe Bitbucket will improve or switch their renderer in the future.) |
(0020816) WubTheCaptain (reporter) 2019-06-23 09:42 |
We'll probably mention this in the changelog later. |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | No one explicitly supports this issue yet. |
Opponents: | No one explicitly opposes this issue yet. |
Issue History | |||
Date Modified | Username | Field | Change |
2019-01-06 07:25 | WubTheCaptain | New Issue | |
2019-01-06 07:25 | WubTheCaptain | Note Added: 0020304 | |
2019-01-06 07:26 | WubTheCaptain | Relationship added | child of 0003594 |
2019-01-06 07:26 | WubTheCaptain | Assigned To | => WubTheCaptain |
2019-01-06 07:26 | WubTheCaptain | Status | new => acknowledged |
2019-01-06 07:26 | WubTheCaptain | Relationship added | child of 0003591 |
2019-01-06 07:27 | WubTheCaptain | Relationship replaced | parent of 0003591 |
2019-01-06 07:29 | WubTheCaptain | Status | acknowledged => confirmed |
2019-01-06 07:29 | WubTheCaptain | Target Version | => 1.3 |
2019-01-16 00:06 | Pol M | Note Added: 0020311 | |
2019-02-05 18:16 | Pol M | Note Added: 0020336 | |
2019-02-05 18:16 | Pol M | Note Deleted: 0020336 | |
2019-06-22 22:18 | WubTheCaptain | Status | confirmed => assigned |
2019-06-23 02:22 | WubTheCaptain | File Added: 0001-Add-a-README-file-for-developers.patch | |
2019-06-23 02:22 | WubTheCaptain | Note Added: 0020809 | |
2019-06-23 02:22 | WubTheCaptain | Status | assigned => needs review |
2019-06-23 02:29 | WubTheCaptain | Note Added: 0020810 | |
2019-06-23 02:29 | WubTheCaptain | Note Edited: 0020810 | View Revisions |
2019-06-23 02:29 | WubTheCaptain | Note Edited: 0020810 | View Revisions |
2019-06-23 02:33 | WubTheCaptain | Relationship added | related to 0003237 |
2019-06-23 02:33 | WubTheCaptain | Relationship added | related to 0003533 |
2019-06-23 02:36 | WubTheCaptain | Relationship added | related to 0003514 |
2019-06-23 07:08 | Zalewa | Note Added: 0020812 | |
2019-06-23 07:09 | Zalewa | Note Edited: 0020812 | View Revisions |
2019-06-23 08:12 | WubTheCaptain | Status | needs review => assigned |
2019-06-23 08:20 | WubTheCaptain | File Added: 0002-README-dev-Add-linebreaks-etc-to-hg-clone-line.patch | |
2019-06-23 08:20 | WubTheCaptain | File Added: 0003-README-dev-Remove-section-on-unit-tests.patch | |
2019-06-23 08:22 | WubTheCaptain | Note Added: 0020813 | |
2019-06-23 08:22 | WubTheCaptain | Status | assigned => needs review |
2019-06-23 08:28 | WubTheCaptain | Assigned To | WubTheCaptain => Zalewa |
2019-06-23 09:34 | Zalewa | Note Added: 0020814 | |
2019-06-23 09:40 | WubTheCaptain | Note Added: 0020815 | |
2019-06-23 09:40 | WubTheCaptain | Status | needs review => resolved |
2019-06-23 09:40 | WubTheCaptain | Fixed in Version | => 1.3 |
2019-06-23 09:40 | WubTheCaptain | Resolution | open => fixed |
2019-06-23 09:41 | WubTheCaptain | Note Edited: 0020815 | View Revisions |
2019-06-23 09:42 | WubTheCaptain | Note Added: 0020816 | |
2019-07-30 10:13 | WubTheCaptain | Status | resolved => closed |
Copyright © 2000 - 2024 MantisBT Team |