Notes |
|
|
Probably a link to our issue tracker, at least. |
|
|
(0020311)
|
Pol M
|
2019-01-16 00:06
|
|
In ticket 3444 Zalewa makes some great points that should be included ^-^ |
|
|
|
|
|
|
Quote Patch by me, attached.
Spoilers for references included:
- Russian Overkill
- Doom II maps, monster names, etc.
- Push
This patch makes mentions to things which other tickets should consider with implementation. I'll try to find their relationships.
|
|
|
(0020812)
|
Zalewa
|
2019-06-23 07:08
(edited on: 2019-06-23 07:09) |
|
It's straight to the point, just the way I like it.
Two remarks from me:
1. The .md format should maintain usability in the plain-text format as much as possible. This is achieved here, however I'd still like to nitpick about the `hg clone` line. Personally I prefer when command lines stand out in a way that makes them easy to copy and paste, especially if the command is short and fits within the column limit.
+A typical way to get started is to clone the Mercurial repository, using a
+Mercurial client from command line.
+
+ `hg clone'https://bitbucket.org/Doomseeker/doomseeker [^]'`.
+
+Refer to the manual of your client for information on interfacing
+with Mercurial.
2. The unit testing engine is not entirely useless. Yes, it's crude and doesn't automagically translate #define macros to test cases and fixtures, but it does its job if you know how to use it. Its pro point is that it's straight-forward. Everything to know about it is in the code and it doesn't need any obscure rituals to use. It's partially why I've been delaying its replacement for so long.
|
|
|
|
The first one is a fair point, although with CommonMark your exact example wouldn't do what you intended: the backticks would be visible. I addressed this in patch 0002, attached.
As for your second point, I've decided to remove the section on unit tests (for now). |
|
|
(0020814)
|
Zalewa
|
2019-06-23 09:34
|
|
|
|
(0020815)
|
WubTheCaptain
|
2019-06-23 09:40
(edited on: 2019-06-23 09:41) |
|
I have personally used commonmark.js dingus as a reference for rendering, and thus don't really care for rendering issues which may be apparent on Bitbucket. (Maybe Bitbucket will improve or switch their renderer in the future.)
|
|
|
|
We'll probably mention this in the changelog later. |
|