0002320: Leaving server through offline skirmish doesn't disconnect client first causing it to leave player behind

Notes
(0012755) Edward-san (developer) 2015-06-18 14:26 edited on: 2015-06-18 14:27	Fixed:'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/6452d6aabf1dd6b81242c9178ec45c260b2abeed [^]' . p.s. I'll do the merge with 3.0 when this is accepted.

(0012760) Dusk (developer) 2015-06-20 13:28 edited on: 2015-06-20 13:29	Shouldn't we instead use CLIENT_QuitNetworkGame inside NETWORK_SetState if we're going from client to offline mode?

(0012762) Edward-san (developer) 2015-06-20 16:14	actually, CLIENT_QuitNetworkGame calls NETWORK_SetState, so in 3.0 it could be thinkable to clean up all these NETWORK_SetState calls after CLIENT_QuitNetworkGame.

(0013496) Edward-san (developer) 2015-09-12 20:37	Ported the fix to the new repository:'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/0fdc7d3e50141025c3de2fdf7dba6a925636a39c [^]'

(0013578) cobalt (updater) 2015-10-04 09:35	Issue addressed by commit 721ff8fbb948: - Fixed: Online clients trying to run an offline skirmish were not disconnected properly (addresses 2320). Committed by Edoardo Prezioso [edward-san] on Saturday 12 September 2015 22:35:54 Changes in files: docs/zandronum-history.txt \| 1 + src/m_options.cpp \| 4 ++++ 2 files changed, 5 insertions(+), 0 deletions(-)

(0013635) Ru5tK1ng (updater) 2015-10-10 00:28	Tested with alpha-150831-1814 and the client consistently disconnected correctly via offline skirmish.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2015-06-18 13:20	unknownna	New Issue
2015-06-18 13:20	unknownna	File Added: Screenshot_Doom_20150618_150948.png
2015-06-18 13:20	unknownna	Status	new => confirmed
2015-06-18 14:17	Edward-san	Assigned To	=> Edward-san
2015-06-18 14:17	Edward-san	Status	confirmed => assigned
2015-06-18 14:26	Edward-san	Note Added: 0012755
2015-06-18 14:26	Edward-san	Status	assigned => needs review
2015-06-18 14:27	Edward-san	Note Edited: 0012755	View Revisions
2015-06-18 14:29	Edward-san	Target Version	=> 2.1
2015-06-20 13:28	Dusk	Note Added: 0012760
2015-06-20 13:29	Dusk	Note Edited: 0012760	View Revisions
2015-06-20 16:14	Edward-san	Note Added: 0012762
2015-06-24 22:44	Dusk	Target Version	2.1 => 2.2
2015-09-12 20:37	Edward-san	Note Added: 0013496
2015-10-04 09:35	cobalt	Status	needs review => needs testing
2015-10-04 09:35	cobalt	Steps to Reproduce Updated	View Revisions
2015-10-04 09:35	cobalt	Note Added: 0013578
2015-10-10 00:28	Ru5tK1ng	Note Added: 0013635
2015-10-10 00:29	Ru5tK1ng	Status	needs testing => resolved
2015-10-10 00:29	Ru5tK1ng	Resolution	open => fixed
2015-10-10 00:29	Ru5tK1ng	Fixed in Version	=> 3.0
2015-10-10 00:29	Ru5tK1ng	Steps to Reproduce Updated	View Revisions
2018-09-30 22:17	Blzut3	Status	resolved => closed

Relationships