MantisBT - Zandronum
View Issue Details
0002320Zandronum[All Projects] Bugpublic2015-06-18 13:202018-09-30 22:17
unknownna 
Edward-san 
normaltrivialalways
closedfixed 
2.0 
2.23.0 
0002320: Leaving server through offline skirmish doesn't disconnect client first causing it to leave player behind
See attached screenshot. If a client disconnects from the server by starting an offline skirmish, the client doesn't disconnect properly.
1. zandronum -iwad doom2.wad -host
2. zandronum -iwad doom2.wad -connect localhost
3. zandronum -iwad doom2.wad -connect localhost
4. Join the game with client A.
5. Start an offline skirmish with Client A.
No tags attached.
png Screenshot_Doom_20150618_150948.png (54,978) 2015-06-18 13:20
/tracker/file_download.php?file_id=1565&type=bug
png
Issue History
2015-06-18 13:20unknownnaNew Issue
2015-06-18 13:20unknownnaFile Added: Screenshot_Doom_20150618_150948.png
2015-06-18 13:20unknownnaStatusnew => confirmed
2015-06-18 14:17Edward-sanAssigned To => Edward-san
2015-06-18 14:17Edward-sanStatusconfirmed => assigned
2015-06-18 14:26Edward-sanNote Added: 0012755
2015-06-18 14:26Edward-sanStatusassigned => needs review
2015-06-18 14:27Edward-sanNote Edited: 0012755bug_revision_view_page.php?bugnote_id=12755#r7505
2015-06-18 14:29Edward-sanTarget Version => 2.1
2015-06-20 13:28DuskNote Added: 0012760
2015-06-20 13:29DuskNote Edited: 0012760bug_revision_view_page.php?bugnote_id=12760#r7507
2015-06-20 16:14Edward-sanNote Added: 0012762
2015-06-24 22:44DuskTarget Version2.1 => 2.2
2015-09-12 20:37Edward-sanNote Added: 0013496
2015-10-04 09:35cobaltStatusneeds review => needs testing
2015-10-04 09:35cobaltSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8079#r8079
2015-10-04 09:35cobaltNote Added: 0013578
2015-10-10 00:28Ru5tK1ngNote Added: 0013635
2015-10-10 00:29Ru5tK1ngStatusneeds testing => resolved
2015-10-10 00:29Ru5tK1ngResolutionopen => fixed
2015-10-10 00:29Ru5tK1ngFixed in Version => 3.0
2015-10-10 00:29Ru5tK1ngSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8118#r8118
2018-09-30 22:17Blzut3Statusresolved => closed

Notes
(0012755)
Edward-san   
2015-06-18 14:26   
(edited on: 2015-06-18 14:27)
Fixed:'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/6452d6aabf1dd6b81242c9178ec45c260b2abeed [^]' .

p.s. I'll do the merge with 3.0 when this is accepted.

(0012760)
Dusk   
2015-06-20 13:28   
(edited on: 2015-06-20 13:29)
Shouldn't we instead use CLIENT_QuitNetworkGame inside NETWORK_SetState if we're going from client to offline mode?

(0012762)
Edward-san   
2015-06-20 16:14   
actually, CLIENT_QuitNetworkGame calls NETWORK_SetState, so in 3.0 it could be thinkable to clean up all these NETWORK_SetState calls after CLIENT_QuitNetworkGame.
(0013496)
Edward-san   
2015-09-12 20:37   
Ported the fix to the new repository:'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/0fdc7d3e50141025c3de2fdf7dba6a925636a39c [^]'
(0013578)
cobalt   
2015-10-04 09:35   
Issue addressed by commit 721ff8fbb948: - Fixed: Online clients trying to run an offline skirmish were not disconnected properly (addresses 2320).
Committed by Edoardo Prezioso [edward-san] on Saturday 12 September 2015 22:35:54

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/m_options.cpp | 4 ++++
 2 files changed, 5 insertions(+), 0 deletions(-)

(0013635)
Ru5tK1ng   
2015-10-10 00:28   
Tested with alpha-150831-1814 and the client consistently disconnected correctly via offline skirmish.