0000724: DesignatedTeams ruined self inflicted damage for monsters

Chat on our Discord Server Get the latest version: 3.2.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000724

Zandronum

[All Projects] Bug

public

2012-03-26 22:33

2018-09-30 19:54

Reporter

Blzut3

Assigned To

Blzut3

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

1.0-beta

Target Version

Fixed in Version

1.0

Summary

0000724: DesignatedTeams ruined self inflicted damage for monsters

Description

Start map23 of Doom II and watch the Mancubus be immune to his own damage.

Additional Information

There's on thing I'm not sure about on this changeset. IsTeammate explicitly checks for this == other in Skulltag, but not in ZDoom. This check was added before DesignatedTeam so I'm playing it safe and checking the condition in p_interaction.cpp instead. If you know what the check is for in Skulltag I could fix it by making this == other return false in both.

Attached Files

desigteamfix.7z [^] (606 bytes) 2012-03-26 22:33

Relationships

Notes
(0002907) Torr Samaho (administrator) 2012-03-27 00:32 edited on: 2012-03-27 00:36	For the record, the "this == other" check in Skulltag is extremely old. It's already in 96f (or at least in the source I have that is labeled as 96f). Independently of the technical reasons why this check it there, I think it's very reasonable to consider oneself as one's teammate.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2012-03-26 22:33	Blzut3	New Issue
2012-03-26 22:33	Blzut3	File Added: desigteamfix.7z
2012-03-26 22:35	Blzut3	Assigned To	=> Blzut3
2012-03-26 22:35	Blzut3	Status	new => assigned
2012-03-27 00:32	Torr Samaho	Note Added: 0002907
2012-03-27 00:36	Torr Samaho	Note Edited: 0002907	View Revisions
2012-04-01 21:14	Blzut3	Status	assigned => resolved
2012-04-01 21:14	Blzut3	Fixed in Version	=> 1.0
2012-04-01 21:14	Blzut3	Resolution	open => fixed
2012-06-09 13:22	Torr Samaho	Category	General => Bug
2018-09-30 19:54	Blzut3	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.