MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000724Zandronum[All Projects] Bugpublic2012-03-26 22:332018-09-30 19:54
ReporterBlzut3 
Assigned ToBlzut3 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.0-beta 
Target VersionFixed in Version1.0 
Summary0000724: DesignatedTeams ruined self inflicted damage for monsters
DescriptionStart map23 of Doom II and watch the Mancubus be immune to his own damage.
Steps To Reproduce
Additional InformationThere's on thing I'm not sure about on this changeset. IsTeammate explicitly checks for this == other in Skulltag, but not in ZDoom. This check was added before DesignatedTeam so I'm playing it safe and checking the condition in p_interaction.cpp instead. If you know what the check is for in Skulltag I could fix it by making this == other return false in both.
TagsNo tags attached.
Relationships
Attached Files7z desigteamfix.7z (606) 2012-03-26 22:33
/tracker/file_download.php?file_id=470&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-03-26 22:33Blzut3New Issue
2012-03-26 22:33Blzut3File Added: desigteamfix.7z
2012-03-26 22:35Blzut3Assigned To => Blzut3
2012-03-26 22:35Blzut3Statusnew => assigned
2012-03-27 00:32Torr SamahoNote Added: 0002907
2012-03-27 00:36Torr SamahoNote Edited: 0002907bug_revision_view_page.php?bugnote_id=2907#r1483
2012-04-01 21:14Blzut3Statusassigned => resolved
2012-04-01 21:14Blzut3Fixed in Version => 1.0
2012-04-01 21:14Blzut3Resolutionopen => fixed
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2018-09-30 19:54Blzut3Statusresolved => closed

Notes
(0002907)
Torr Samaho   
2012-03-27 00:32   
(edited on: 2012-03-27 00:36)
For the record, the "this == other" check in Skulltag is extremely old. It's already in 96f (or at least in the source I have that is labeled as 96f).

Independently of the technical reasons why this check it there, I think it's very reasonable to consider oneself as one's teammate.