Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000537Zandronum[All Projects] Suggestionpublic2011-07-28 20:422018-09-30 22:42
ReporterDecay 
Assigned ToWatermelon 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.2 
Target Version2.0Fixed in Version 
Summary0000537: New compat flag: sv_bloodbrightness
DescriptionAs ST gets better with oldschool with each new release, I noticed a lot of competitive players complain about the lack of blood brightness on ST. I did a quick search on the forums and noticed a request similar to this was No'd prior to 97b. I think that it isn't an unreasonable request to have a compat flag that enforces a blood brightness that is higher than the current default (half). This flag would be off by default, allowing customization of blood brightness (sv_bloodbrightness 0). Most likely this would be activated only on competitive servers.
Additional InformationSorry if it's a duplicate, but I did run a quick check and found none.
Attached Files

- Relationships

-  Notes
User avatar (0002261)
Evo (reporter)
2011-10-17 15:04

 Nice suggestion. Something high but not as taxing as vanilla would be the sweet spot.
User avatar (0002265)
Qent (updater)
2011-10-19 02:03
edited on: 2012-01-09 01:56

 Is this already possible with mods, e.g. the flashbang effect in AOW2?

EDIT: Turns out it is sort of, but not really, and there are other issues.
User avatar (0006379)
Watermelon (developer)
2013-06-08 05:31

 Thoughts on adding this as a compatflag, or dmflag?
User avatar (0007218)
Qent (updater)
2013-09-18 17:04
edited on: 2013-09-18 17:10

 This cannot be a flag at all because it should have a floating point value.

Actually I'm not exactly sure what this should do. It could be interpreted as a minimum blood_fade_scalar which would be 0.0 for cooperative servers, 0.5 on most newschool servers, and 1.0 on oldschool servers.

I would still like to have this, though.
User avatar (0007235)
Toxicity (reporter)
2013-09-19 00:31

 I agree, it should be a scalar.
User avatar (0008710)
Watermelon (developer)
2014-05-05 22:31

 Since this would be a default flag for vanilla compat, it would either be on (forcing 1.0) or off (user value used).

Thoughts on still going ahead with this?
User avatar (0008731)
Watermelon (developer)
2014-05-07 17:15

 'https://bitbucket.org/ChrisKOmg/zandronum/commits/986af484a0c97dfebea81ea4d2e3e8a25db246d0 [^]'
User avatar (0008749)
Torr Samaho (administrator)
2014-05-09 06:29

 Pulled, rebased and reordered the history entries. Note: zandronum-history.txt first lists the additions (+), then the fixes (-) and then the misc stuff (!).
User avatar (0008784)
Dusk (developer)
2014-05-11 20:33

 I really don't think this should be a compatibility flag. What are we being compatible with here? We are introducing a server-imposed restriction, so I think this should be a dmflag instead.
User avatar (0008786)
Watermelon (developer)
2014-05-11 21:27
Quote
<Dusk> i think we've kind of forgotten what compat flags are
<Dusk> they exist for making old wads function like they are expected
<Dusk> old wads/wads that were made for older ports


I think this is a pretty reasonable quote.

Thoughts on migrating anything that sneaked into the compat section into za_dmflags?
User avatar (0008789)
StrikerMan780 (reporter)
2014-05-12 21:36

 or za_osflags / osflags (oldschool flags?)
User avatar (0008802)
Dusk (developer)
2014-05-17 21:43

 Not directly related to the matter at hand but I think the following compatflags should also be made dmflags:
compat_instantrespawn -> sv_instantrespawn
compat_disabletaunts -> sv_notaunts
compat_disablestealthmonsters -> sv_nostealthmonsters
compat_nocrosshair -> sv_nocrosshair
compat_noland -> sv_noland
User avatar (0008808)
Konar6 (reporter)
2014-05-18 10:07

 I oppose mass messing around with dmflags. This should have been accounted for when these flags were being implemented IMHO. Compatibility should be preserved now. What would we gain by switching them all around? There would be confusion and extra work, i.e. would this imply that I'd have to manually review all the dmflags in 160+ server configs I have? (I guess it's already happening with those zadmflags...?)
User avatar (0008809)
Dusk (developer)
2014-05-18 11:57
edited on: 2014-05-18 11:58

 The flagsets are already being moved around and existing configurations doing "dmflags 1234567" are already invalidated. Hosts will have to recheck server configs in any case so now I think we have a one-time opportunity to fix naming/category errors in these flagsets.
User avatar (0008888)
Arco (updater)
2014-06-07 22:53

 Works correctly.
User avatar (0008899)
Dusk (developer)
2014-06-08 01:28

 Reopening, my concerns weren't addressed yet. I still think this should be a dmflag.
User avatar (0008902)
Torr Samaho (administrator)
2014-06-08 07:43

 I think this fits in both categories, i.e. compat and dm, but is probably a little better suited for the dmflags. So, feel free to make a patch that moves it to zadmflags and I'll pull it.
User avatar (0008912)
Dusk (developer)
2014-06-08 12:24

 'https://bitbucket.org/Torr_Samaho/zandronum/pull-request/41 [^]'
User avatar (0008913)
Torr Samaho (administrator)
2014-06-08 12:40

 Pulled.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: Qent
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2011-07-28 20:42 Decay New Issue
2011-10-17 15:04 Evo Note Added: 0002261
2011-10-19 02:03 Qent Note Added: 0002265
2012-01-09 01:56 Qent Note Edited: 0002265 View Revisions
2013-06-08 05:31 Watermelon Note Added: 0006379
2013-09-18 16:49 Watermelon Assigned To => Watermelon
2013-09-18 16:49 Watermelon Status new => assigned
2013-09-18 17:04 Qent Note Added: 0007218
2013-09-18 17:10 Qent Note Edited: 0007218 View Revisions
2013-09-19 00:31 Toxicity Note Added: 0007235
2014-05-05 22:31 Watermelon Note Added: 0008710
2014-05-07 17:15 Watermelon Note Added: 0008731
2014-05-07 17:15 Watermelon Status assigned => needs testing
2014-05-07 17:15 Watermelon Status needs testing => needs review
2014-05-09 06:29 Torr Samaho Note Added: 0008749
2014-05-09 06:29 Torr Samaho Status needs review => needs testing
2014-05-09 06:30 Torr Samaho Product Version => 1.2
2014-05-09 06:30 Torr Samaho Target Version => 2.0
2014-05-11 20:33 Dusk Note Added: 0008784
2014-05-11 21:27 Watermelon Note Added: 0008786
2014-05-12 21:36 StrikerMan780 Note Added: 0008789
2014-05-17 21:43 Dusk Note Added: 0008802
2014-05-18 10:07 Konar6 Note Added: 0008808
2014-05-18 11:57 Dusk Note Added: 0008809
2014-05-18 11:58 Dusk Note Edited: 0008809 View Revisions
2014-06-07 22:53 Arco Note Added: 0008888
2014-06-07 22:53 Arco Status needs testing => resolved
2014-06-07 22:53 Arco Resolution open => fixed
2014-06-08 01:28 Dusk Note Added: 0008899
2014-06-08 01:28 Dusk Status resolved => feedback
2014-06-08 01:28 Dusk Resolution fixed => reopened
2014-06-08 07:43 Torr Samaho Note Added: 0008902
2014-06-08 12:24 Dusk Note Added: 0008912
2014-06-08 12:27 Dusk Status feedback => needs review
2014-06-08 12:40 Torr Samaho Note Added: 0008913
2014-06-08 12:41 Torr Samaho Status needs review => needs testing
2014-06-08 13:48 Dusk Status needs testing => resolved
2014-06-08 13:48 Dusk Resolution reopened => fixed
2018-09-30 22:42 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker