MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000537Zandronum[All Projects] Suggestionpublic2011-07-28 20:422018-09-30 22:42
ReporterDecay 
Assigned ToWatermelon 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.2 
Target Version2.0Fixed in Version 
Summary0000537: New compat flag: sv_bloodbrightness
DescriptionAs ST gets better with oldschool with each new release, I noticed a lot of competitive players complain about the lack of blood brightness on ST. I did a quick search on the forums and noticed a request similar to this was No'd prior to 97b. I think that it isn't an unreasonable request to have a compat flag that enforces a blood brightness that is higher than the current default (half). This flag would be off by default, allowing customization of blood brightness (sv_bloodbrightness 0). Most likely this would be activated only on competitive servers.
Steps To Reproduce
Additional InformationSorry if it's a duplicate, but I did run a quick check and found none.
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-07-28 20:42DecayNew Issue
2011-10-17 15:04EvoNote Added: 0002261
2011-10-19 02:03QentNote Added: 0002265
2012-01-09 01:56QentNote Edited: 0002265bug_revision_view_page.php?bugnote_id=2265#r1205
2013-06-08 05:31WatermelonNote Added: 0006379
2013-09-18 16:49WatermelonAssigned To => Watermelon
2013-09-18 16:49WatermelonStatusnew => assigned
2013-09-18 17:04QentNote Added: 0007218
2013-09-18 17:10QentNote Edited: 0007218bug_revision_view_page.php?bugnote_id=7218#r4037
2013-09-19 00:31ToxicityNote Added: 0007235
2014-05-05 22:31WatermelonNote Added: 0008710
2014-05-07 17:15WatermelonNote Added: 0008731
2014-05-07 17:15WatermelonStatusassigned => needs testing
2014-05-07 17:15WatermelonStatusneeds testing => needs review
2014-05-09 06:29Torr SamahoNote Added: 0008749
2014-05-09 06:29Torr SamahoStatusneeds review => needs testing
2014-05-09 06:30Torr SamahoProduct Version => 1.2
2014-05-09 06:30Torr SamahoTarget Version => 2.0
2014-05-11 20:33DuskNote Added: 0008784
2014-05-11 21:27WatermelonNote Added: 0008786
2014-05-12 21:36StrikerMan780Note Added: 0008789
2014-05-17 21:43DuskNote Added: 0008802
2014-05-18 10:07Konar6Note Added: 0008808
2014-05-18 11:57DuskNote Added: 0008809
2014-05-18 11:58DuskNote Edited: 0008809bug_revision_view_page.php?bugnote_id=8809#r4779
2014-06-07 22:53ArcoNote Added: 0008888
2014-06-07 22:53ArcoStatusneeds testing => resolved
2014-06-07 22:53ArcoResolutionopen => fixed
2014-06-08 01:28DuskNote Added: 0008899
2014-06-08 01:28DuskStatusresolved => feedback
2014-06-08 01:28DuskResolutionfixed => reopened
2014-06-08 07:43Torr SamahoNote Added: 0008902
2014-06-08 12:24DuskNote Added: 0008912
2014-06-08 12:27DuskStatusfeedback => needs review
2014-06-08 12:40Torr SamahoNote Added: 0008913
2014-06-08 12:41Torr SamahoStatusneeds review => needs testing
2014-06-08 13:48DuskStatusneeds testing => resolved
2014-06-08 13:48DuskResolutionreopened => fixed
2018-09-30 22:42Blzut3Statusresolved => closed

Notes
(0002261)
Evo   
2011-10-17 15:04   
Nice suggestion. Something high but not as taxing as vanilla would be the sweet spot.
(0002265)
Qent   
2011-10-19 02:03   
(edited on: 2012-01-09 01:56)
Is this already possible with mods, e.g. the flashbang effect in AOW2?

EDIT: Turns out it is sort of, but not really, and there are other issues.
(0006379)
Watermelon   
2013-06-08 05:31   
Thoughts on adding this as a compatflag, or dmflag?
(0007218)
Qent   
2013-09-18 17:04   
(edited on: 2013-09-18 17:10)
This cannot be a flag at all because it should have a floating point value.

Actually I'm not exactly sure what this should do. It could be interpreted as a minimum blood_fade_scalar which would be 0.0 for cooperative servers, 0.5 on most newschool servers, and 1.0 on oldschool servers.

I would still like to have this, though.
(0007235)
Toxicity   
2013-09-19 00:31   
I agree, it should be a scalar.
(0008710)
Watermelon   
2014-05-05 22:31   
Since this would be a default flag for vanilla compat, it would either be on (forcing 1.0) or off (user value used).

Thoughts on still going ahead with this?
(0008731)
Watermelon   
2014-05-07 17:15   
'https://bitbucket.org/ChrisKOmg/zandronum/commits/986af484a0c97dfebea81ea4d2e3e8a25db246d0 [^]'
(0008749)
Torr Samaho   
2014-05-09 06:29   
Pulled, rebased and reordered the history entries. Note: zandronum-history.txt first lists the additions (+), then the fixes (-) and then the misc stuff (!).
(0008784)
Dusk   
2014-05-11 20:33   
I really don't think this should be a compatibility flag. What are we being compatible with here? We are introducing a server-imposed restriction, so I think this should be a dmflag instead.
(0008786)
Watermelon   
2014-05-11 21:27   
Quote
<Dusk> i think we've kind of forgotten what compat flags are
<Dusk> they exist for making old wads function like they are expected
<Dusk> old wads/wads that were made for older ports


I think this is a pretty reasonable quote.

Thoughts on migrating anything that sneaked into the compat section into za_dmflags?
(0008789)
StrikerMan780   
2014-05-12 21:36   
or za_osflags / osflags (oldschool flags?)
(0008802)
Dusk   
2014-05-17 21:43   
Not directly related to the matter at hand but I think the following compatflags should also be made dmflags:
compat_instantrespawn -> sv_instantrespawn
compat_disabletaunts -> sv_notaunts
compat_disablestealthmonsters -> sv_nostealthmonsters
compat_nocrosshair -> sv_nocrosshair
compat_noland -> sv_noland
(0008808)
Konar6   
2014-05-18 10:07   
I oppose mass messing around with dmflags. This should have been accounted for when these flags were being implemented IMHO. Compatibility should be preserved now. What would we gain by switching them all around? There would be confusion and extra work, i.e. would this imply that I'd have to manually review all the dmflags in 160+ server configs I have? (I guess it's already happening with those zadmflags...?)
(0008809)
Dusk   
2014-05-18 11:57   
(edited on: 2014-05-18 11:58)
The flagsets are already being moved around and existing configurations doing "dmflags 1234567" are already invalidated. Hosts will have to recheck server configs in any case so now I think we have a one-time opportunity to fix naming/category errors in these flagsets.
(0008888)
Arco   
2014-06-07 22:53   
Works correctly.
(0008899)
Dusk   
2014-06-08 01:28   
Reopening, my concerns weren't addressed yet. I still think this should be a dmflag.
(0008902)
Torr Samaho   
2014-06-08 07:43   
I think this fits in both categories, i.e. compat and dm, but is probably a little better suited for the dmflags. So, feel free to make a patch that moves it to zadmflags and I'll pull it.
(0008912)
Dusk   
2014-06-08 12:24   
'https://bitbucket.org/Torr_Samaho/zandronum/pull-request/41 [^]'
(0008913)
Torr Samaho   
2014-06-08 12:40   
Pulled.