Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004517Zandronum[All Projects] Bugpublic2025-04-24 17:032025-04-26 04:27
Reporterunknownna 
Assigned ToKaminsky 
PrioritynormalSeverityfeatureReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version3.1 
Target VersionFixed in Version3.2 
Summary0004517: "Welcome to domination" announcer not supported?
DescriptionFrom looking at some of the announcers, it seems that several of them have a sound recorded for "welcome to domination", yet the entry definition for the sound doesn't seem to exist in any of them. What's going on here, was it never implemented properly? If it's been implemented, what's the ANCRINFO definition supposed to be?

There already seems to be "welcome" announcers for the following modes:

* CTF
* OneFlagCTF
* Skulltag
Attached Files

- Relationships

-  Notes
User avatar (0024504)
Kaminsky (developer)
2025-04-25 14:09

Since 3.2 added a "WelcomeSound" property to the GAMEMODE lump, it was easy enough to define one for domination:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/321 [^]'

I'm not sure if these announcers already defined the corresponding "WelcomeToDomination" entry in ANCRINFO, but if not, it should be easy for anyone to do anyways.
User avatar (0024509)
unknownna (updater)
2025-04-25 17:14

It seems to work, but every single announcer has be updated to add the following to ANCRINFO:

welcometodomination = <sound definition>


and add the following to SNDINFO:

<sound definiton> <sound filename>


It's strange that the sounds were recorded all the way back, yet never supported.

The following announcers must be updated, not sure if any of them are officially supported and included with Zandronum:

* ZanACG
* Skulltag 98a announcer
* George Exley announcer

ZanGeneric doesn't have the sound recorded, so it can't support it.

One issue I noticed: If the user selects an announcer without the domination sound existing, like ZanGeneric, the welcome sound is still played, but from one of the other announcers. What's going on here? Why does the sounds of another announcer play?
User avatar (0024511)
Kaminsky (developer)
2025-04-25 18:44

Quote from unknownna
The following announcers must be updated, not sure if any of them are officially supported and included with Zandronum:

* ZanACG
* Skulltag 98a announcer
* George Exley announcer


ZanACG is included with Zandronum, but not the other two. It shouldn't be any trouble to update it to support the "WelcomeToDomination" sound before 3.2's release, though.

Quote from unknownna
ZanGeneric doesn't have the sound recorded, so it can't support it.


I might just do some sentence splicing and make a "welcome to domination" sound for this announcer by using the "welcome to CTF/ST" and "(total) domination" sounds. It's not the prettiest solution, but it's better than nothing.

Quote from unknownna
One issue I noticed: If the user selects an announcer without the domination sound existing, like ZanGeneric, the welcome sound is still played, but from one of the other announcers. What's going on here? Why does the sounds of another announcer play?


Zandronum's built-in "default" announcer is composed of the first loaded sounds for each entry. If the announcer you're using doesn't support the entry being played (e.g. "WelcomeToDomination"), then it'll try using the default announcer instead, if the latter has it.

I'd say that as long as ZanACG and ZanGeneric both support "WelcomeToDomination", this should be okay.
User avatar (0024512)
unknownna (updater)
2025-04-25 18:48

Quote from Kaminsky
Zandronum's built-in "default" announcer is composed of the first loaded sounds for each entry. If the announcer you're using doesn't support the entry being played (e.g. "WelcomeToDomination"), then it'll try using the default announcer instead, if the latter has it.


If feels very bugged though, when you have a separate announcer voice doing the initial announcement while having another announcer voice selected. In that case, I'd just keep it silent if the sound doesn't exist in the selected announcer. At least it would feel cleaner and consolidated that way.

So "default" is just the first announcer if loads by chance?
User avatar (0024513)
Kaminsky (developer)
2025-04-25 19:15
edited on: 2025-04-25 19:16

Quote from unknownna
If feels very bugged though, when you have a separate announcer voice doing the initial announcement while having another announcer voice selected. In that case, I'd just keep it silent if the sound doesn't exist in the selected announcer. At least it would feel cleaner and consolidated that way.


I'd rather not change the current behaviour right now, especially since it's clearly intentional (I think the intention was to ensure that at least some sound would play for each entry, if possible). If you think the current behaviour is erroneous and/or should be changed, then I'm okay if you want to make a new ticket for it.

Quote from unknownna
So "default" is just the first announcer if loads by chance?


It's not necessarily the first announcer, but whatever announcer(s) are the first to have an entry for whatever's being played. It could even be a combination of several loaded announcers, if necessary.

User avatar (0024516)
unknownna (updater)
2025-04-25 19:47

Quote from Kaminsky
It's not necessarily the first announcer, but whatever announcer(s) are the first to have an entry for whatever's being played. It could even be a combination of several loaded announcers, if necessary.


I see, thanks for the clarification.

Quote from Kaminsky
I'd rather not change the current behaviour right now, especially since it's clearly intentional (I think the intention was to ensure that at least some sound would play for each entry, if possible). If you think the current behaviour is erroneous and/or should be changed, then I'm okay if you want to make a new ticket for it.


I'll make a note of it and probably make a suggestion ticket for it some other time. It could perhaps be changed so it only plays any sounds it can find if "default" is selected.

Is there anything else to add, are you going to update the announcers on your own? do I need to test something else? If not, we can mark this as resolved.

For future reference, all new announcers made should additionally use "welcometodomination" in ANCRINFO.
User avatar (0024517)
Kaminsky (developer)
2025-04-25 20:04
edited on: 2025-04-25 20:04

Quote from unknownna
Is there anything else to add, are you going to update the announcers on your own? do I need to test something else? If not, we can mark this as resolved.


I'll definitely update the ZanACG and ZanGeneric announcers as soon as I can, since those are bundled with our installers. It should be easy enough to do, and I think I can test them out myself to make sure they work. Since the other announcers you mentioned aren't included in Zandronum, they'll need to be updated separately.

Thanks for testing and giving feedback!

Quote from unknownna
For future reference, all new announcers made should additionally use "welcometodomination" in ANCRINFO.


I agree. We can make a note of this on the Zandronum Wiki.

User avatar (0024519)
unknownna (updater)
2025-04-25 23:48

Agreed, sounds good.

I went ahead and investigated the old Skulltag announcers (found a link to them here) to see which ones started adding the "welcome to domination" sound, and it seems that it first appeared starting from the Skulltag 98a announcer.

So to close this, I patched the 98a announcer to support the domination welcome announcer and uploaded it to the TSPG site for anybody who comes across this and wants the updated announcer.
User avatar (0024520)
Kaminsky (developer)
2025-04-26 04:27

FYI, I updated those two announcers here:'https://foss.heptapod.net/zandronum/zandronum-installer-resources/-/merge_requests/3 [^]'

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2025-04-24 17:03 unknownna New Issue
2025-04-25 14:09 Kaminsky Note Added: 0024504
2025-04-25 14:09 Kaminsky Assigned To => Kaminsky
2025-04-25 14:09 Kaminsky Status new => needs review
2025-04-25 17:14 unknownna Note Added: 0024509
2025-04-25 17:14 unknownna Status needs review => feedback
2025-04-25 18:44 Kaminsky Note Added: 0024511
2025-04-25 18:48 unknownna Note Added: 0024512
2025-04-25 18:48 unknownna Status feedback => assigned
2025-04-25 19:15 Kaminsky Note Added: 0024513
2025-04-25 19:16 Kaminsky Note Edited: 0024513 View Revisions
2025-04-25 19:47 unknownna Note Added: 0024516
2025-04-25 20:04 Kaminsky Note Added: 0024517
2025-04-25 20:04 Kaminsky Note Edited: 0024517 View Revisions
2025-04-25 23:48 unknownna Note Added: 0024519
2025-04-25 23:48 unknownna Status assigned => resolved
2025-04-25 23:48 unknownna Fixed in Version => 3.2
2025-04-25 23:48 unknownna Resolution open => fixed
2025-04-26 04:27 Kaminsky Note Added: 0024520






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker