|
Notes |
|
|
|
|
|
|
|
It seems to work, but every single announcer has be updated to add the following to ANCRINFO:
welcometodomination = <sound definition>
and add the following to SNDINFO:
<sound definiton> <sound filename>
It's strange that the sounds were recorded all the way back, yet never supported.
The following announcers must be updated, not sure if any of them are officially supported and included with Zandronum:
* ZanACG
* Skulltag 98a announcer
* George Exley announcer
ZanGeneric doesn't have the sound recorded, so it can't support it.
One issue I noticed: If the user selects an announcer without the domination sound existing, like ZanGeneric, the welcome sound is still played, but from one of the other announcers. What's going on here? Why does the sounds of another announcer play? |
|
|
|
|
Quote from unknownna
The following announcers must be updated, not sure if any of them are officially supported and included with Zandronum:
* ZanACG
* Skulltag 98a announcer
* George Exley announcer
ZanACG is included with Zandronum, but not the other two. It shouldn't be any trouble to update it to support the "WelcomeToDomination" sound before 3.2's release, though.
Quote from unknownna
ZanGeneric doesn't have the sound recorded, so it can't support it.
I might just do some sentence splicing and make a "welcome to domination" sound for this announcer by using the "welcome to CTF/ST" and "(total) domination" sounds. It's not the prettiest solution, but it's better than nothing.
Quote from unknownna
One issue I noticed: If the user selects an announcer without the domination sound existing, like ZanGeneric, the welcome sound is still played, but from one of the other announcers. What's going on here? Why does the sounds of another announcer play?
Zandronum's built-in "default" announcer is composed of the first loaded sounds for each entry. If the announcer you're using doesn't support the entry being played (e.g. "WelcomeToDomination"), then it'll try using the default announcer instead, if the latter has it.
I'd say that as long as ZanACG and ZanGeneric both support "WelcomeToDomination", this should be okay. |
|
|
|
|
Quote from Kaminsky
Zandronum's built-in "default" announcer is composed of the first loaded sounds for each entry. If the announcer you're using doesn't support the entry being played (e.g. "WelcomeToDomination"), then it'll try using the default announcer instead, if the latter has it.
If feels very bugged though, when you have a separate announcer voice doing the initial announcement while having another announcer voice selected. In that case, I'd just keep it silent if the sound doesn't exist in the selected announcer. At least it would feel cleaner and consolidated that way.
So "default" is just the first announcer if loads by chance? |
|
|
|
(0024513)
|
|
Kaminsky
|
2025-04-25 19:15
(edited on: 2025-04-25 19:16) |
|
Quote from unknownna
If feels very bugged though, when you have a separate announcer voice doing the initial announcement while having another announcer voice selected. In that case, I'd just keep it silent if the sound doesn't exist in the selected announcer. At least it would feel cleaner and consolidated that way.
I'd rather not change the current behaviour right now, especially since it's clearly intentional (I think the intention was to ensure that at least some sound would play for each entry, if possible). If you think the current behaviour is erroneous and/or should be changed, then I'm okay if you want to make a new ticket for it.
Quote from unknownna
So "default" is just the first announcer if loads by chance?
It's not necessarily the first announcer, but whatever announcer(s) are the first to have an entry for whatever's being played. It could even be a combination of several loaded announcers, if necessary.
|
|
|
|
|
Quote from Kaminsky
It's not necessarily the first announcer, but whatever announcer(s) are the first to have an entry for whatever's being played. It could even be a combination of several loaded announcers, if necessary.
I see, thanks for the clarification.
Quote from Kaminsky
I'd rather not change the current behaviour right now, especially since it's clearly intentional (I think the intention was to ensure that at least some sound would play for each entry, if possible). If you think the current behaviour is erroneous and/or should be changed, then I'm okay if you want to make a new ticket for it.
I'll make a note of it and probably make a suggestion ticket for it some other time. It could perhaps be changed so it only plays any sounds it can find if "default" is selected.
Is there anything else to add, are you going to update the announcers on your own? do I need to test something else? If not, we can mark this as resolved.
For future reference, all new announcers made should additionally use "welcometodomination" in ANCRINFO. |
|
|
|
|
Quote from unknownna
Is there anything else to add, are you going to update the announcers on your own? do I need to test something else? If not, we can mark this as resolved.
I'll definitely update the ZanACG and ZanGeneric announcers as soon as I can, since those are bundled with our installers. It should be easy enough to do, and I think I can test them out myself to make sure they work. Since the other announcers you mentioned aren't included in Zandronum, they'll need to be updated separately.
Thanks for testing and giving feedback!
Quote from unknownna
For future reference, all new announcers made should additionally use "welcometodomination" in ANCRINFO.
I agree. We can make a note of this on the Zandronum Wiki.
|
|
|
|
|
Agreed, sounds good.
I went ahead and investigated the old Skulltag announcers (found a link to them here) to see which ones started adding the "welcome to domination" sound, and it seems that it first appeared starting from the Skulltag 98a announcer.
So to close this, I patched the 98a announcer to support the domination welcome announcer and uploaded it to the TSPG site for anybody who comes across this and wants the updated announcer. |
|
|
|
|
|