0004233: Having no weapons and trying to access PLAYERSKIN_WEAPON property crashes

Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0004233

Zandronum

[All Projects] Bug

public

2024-04-18 12:48

2024-05-31 21:11

Reporter

BinaryCode

Assigned To

Kaminsky

Priority

normal

Severity

crash

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

3.2

Target Version

3.2

Fixed in Version

3.2

Summary

0004233: Having no weapons and trying to access PLAYERSKIN_WEAPON property crashes

Description

If you have no weapons (ie an ACS script doing ClearInventory), if the game calls GetPlayerSkin with the "PLAYERSKIN_WEAPON" property, it will crash.

Even if the script is trying to give another weapon after taking the player's weapons, if the function is called during that frame, it will crash.

Steps To Reproduce

Load the example file, then do these in the console:
Take Weapons
Pukename LogSkin

Additional Information

This commit is what is causing the crashes:
'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/81dfa87ddaafbe3de3aa6943a58cbc8067a86c34 [^]'

Attached Files

AltSkinCrash-Minimal.pk3 [^] (882 bytes) 2024-04-18 12:48

Relationships

Notes
(0023626) Kaminsky (developer) 2024-04-18 13:36	This has been fixed in this MR:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/110 [^]'

(0023627) Kaminsky (developer) 2024-04-19 13:00	This has been pushed in:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/d03880cb467f1feed45e52d22fd86f5d5a4edebc [^]'

(0023739) unknownna (updater) 2024-05-31 21:11	It doesn't crash any more.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2024-04-18 12:48	BinaryCode	New Issue
2024-04-18 12:48	BinaryCode	File Added: AltSkinCrash-Minimal.pk3
2024-04-18 13:36	Kaminsky	Note Added: 0023626
2024-04-18 13:36	Kaminsky	Assigned To	=> Kaminsky
2024-04-18 13:36	Kaminsky	Status	new => needs review
2024-04-18 13:36	Kaminsky	Product Version	=> 3.2
2024-04-18 13:36	Kaminsky	Target Version	=> 3.2
2024-04-19 13:00	Kaminsky	Note Added: 0023627
2024-04-19 13:00	Kaminsky	Status	needs review => needs testing
2024-05-31 21:11	unknownna	Note Added: 0023739
2024-05-31 21:11	unknownna	Status	needs testing => resolved
2024-05-31 21:11	unknownna	Resolution	open => fixed
2024-05-31 21:11	unknownna	Fixed in Version	=> 3.2

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.