MantisBT - Zandronum
View Issue Details
0004233Zandronum[All Projects] Bugpublic2024-04-18 12:482024-05-31 21:11
BinaryCode 
Kaminsky 
normalcrashalways
resolvedfixed 
3.2 
3.23.2 
0004233: Having no weapons and trying to access PLAYERSKIN_WEAPON property crashes
If you have no weapons (ie an ACS script doing ClearInventory), if the game calls GetPlayerSkin with the "PLAYERSKIN_WEAPON" property, it will crash.

Even if the script is trying to give another weapon after taking the player's weapons, if the function is called during that frame, it will crash.
Load the example file, then do these in the console:
Take Weapons
Pukename LogSkin
This commit is what is causing the crashes:
'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/81dfa87ddaafbe3de3aa6943a58cbc8067a86c34 [^]'
No tags attached.
? AltSkinCrash-Minimal.pk3 (882) 2024-04-18 12:48
https://zandronum.com/tracker/file_download.php?file_id=2968&type=bug
Issue History
2024-04-18 12:48BinaryCodeNew Issue
2024-04-18 12:48BinaryCodeFile Added: AltSkinCrash-Minimal.pk3
2024-04-18 13:36KaminskyNote Added: 0023626
2024-04-18 13:36KaminskyAssigned To => Kaminsky
2024-04-18 13:36KaminskyStatusnew => needs review
2024-04-18 13:36KaminskyProduct Version => 3.2
2024-04-18 13:36KaminskyTarget Version => 3.2
2024-04-19 13:00KaminskyNote Added: 0023627
2024-04-19 13:00KaminskyStatusneeds review => needs testing
2024-05-31 21:11unknownnaNote Added: 0023739
2024-05-31 21:11unknownnaStatusneeds testing => resolved
2024-05-31 21:11unknownnaResolutionopen => fixed
2024-05-31 21:11unknownnaFixed in Version => 3.2

Notes
(0023626)
Kaminsky   
2024-04-18 13:36   
This has been fixed in this MR:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/110 [^]'
(0023627)
Kaminsky   
2024-04-19 13:00   
This has been pushed in:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/d03880cb467f1feed45e52d22fd86f5d5a4edebc [^]'
(0023739)
unknownna   
2024-05-31 21:11   
It doesn't crash any more.