0004200: A_SpawnItemEx does not sync AAPTR_TARGET always

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0004200

Zandronum

[All Projects] Bug

public

2024-03-06 03:34

2024-04-08 23:16

Reporter

Trillster

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

3.1

Target Version

3.2

Fixed in Version

3.2

Summary

0004200: A_SpawnItemEx does not sync AAPTR_TARGET always

Description

Whenever a +MISSILE actor is spawned using A_SpawnItemEx, the AAPTR_TARGET actor pointer is not always synced to clients, compared to offline behavior and online A_FireCustomMissile behavior.

Steps To Reproduce

I've attached an example file which has a few test cases. First, you can use the file offline and run the following commands to see intended output:

summon OriginActor
give FireOriginActor
give SpawnOriginActor

You should see that every print statement correctly prints the player's actor class as the target.

Once you run those same commands online, you'll see that the "Client Target" logs with the "Spawned-" actors will be incorrect depending on which command you ran.

Additional Information

This also occurs in the latest 3.2 betas.

Attached Files

ClientTargetCarryoverFail.pk3 [^] (1,413 bytes) 2024-03-06 03:34

4200.patch [^] (2,126 bytes) 2024-03-07 02:42 [Show Content] [Hide Content]

# HG changeset patch
# User Trillster
# Date 1709779247 18000
#      Wed Mar 06 21:40:47 2024 -0500
# Node ID abdce7be4a57c3561f73838ba6f36e56593f09c6
# Parent  2f59d4a1f4d10d32e639890b6963fe96620512d8
Fixed: A_SpawnItemEx didn't always sync AAPTR_TARGET to clients (addresses 4200).

diff -r 2f59d4a1f4d1 -r abdce7be4a57 docs/zandronum-history.txt
--- a/docs/zandronum-history.txt	Mon Mar 04 09:34:51 2024 -0600
+++ b/docs/zandronum-history.txt	Wed Mar 06 21:40:47 2024 -0500
@@ -133,6 +133,7 @@
 -	- Fixed: STRFTIME would crash Zandronum if a negative was passed into the first argument (addresses 4144). [Ru5tK1ng]
 -	- Fixed: the server would freeze after running for long enough (e.g. 24 days on Windows) due to an integer overflow in SERVER_Tick. [Kaminsky]
 -	- Fixed: the SendToCommunicator special didn't stop the previous sound when online. [DrinkyBird]
+-	- Fixed: A_SpawnItemEx didn't always sync AAPTR_TARGET to clients (addresses 4200). [Trillster]
 !	- The result value of GAMEEVENT_MEDALS event scripts can now be used to determine whether or not the player receives the medal. [Kaminsky]
 !	- GAMEMODE flags are now validated after all GAMEMODE lumps have been parsed instead of after each one. The internal game mode name (e.g. "TeamLMS") is now printed with the error message instead of the actual name. [Kaminsky]
 !	- Added an extra check to ensure that game modes have a (short) name. [Kaminsky]
diff -r 2f59d4a1f4d1 -r abdce7be4a57 src/thingdef/thingdef_codeptr.cpp
--- a/src/thingdef/thingdef_codeptr.cpp	Mon Mar 04 09:34:51 2024 -0600
+++ b/src/thingdef/thingdef_codeptr.cpp	Wed Mar 06 21:40:47 2024 -0500
@@ -2656,8 +2656,9 @@
 				SERVERCOMMANDS_SetThingTranslation( mo );
 
 			// [BB] To properly handle actor-actor bouncing, the client must know the target.
-			if ( mo->BounceFlags != BOUNCE_None )
-				SERVERCOMMANDS_SetThingTarget ( mo );
+			// if ( mo->BounceFlags != BOUNCE_None )
+			// [TRSR] It's preferable for the client to always know the target.
+			SERVERCOMMANDS_SetThingTarget ( mo );
 
 			// [BB] Set scale if necessary.
 			SERVERCOMMANDS_UpdateThingScaleNotAtDefault ( mo );

4200_2.patch [^] (2,092 bytes) 2024-03-30 19:47 [Show Content] [Hide Content]

# HG changeset patch
# User Trillster
# Date 1711827629 14400
#      Sat Mar 30 15:40:29 2024 -0400
# Node ID 5d72fa552084554cb2fc5dd830e5ce53baa7872a
# Parent  2f59d4a1f4d10d32e639890b6963fe96620512d8
A_SpawnItemEx now always syncs AAPTR_TARGET for +MISSILE actors (addresses 4200).

diff -r 2f59d4a1f4d1 -r 5d72fa552084 docs/zandronum-history.txt
--- a/docs/zandronum-history.txt	Mon Mar 04 09:34:51 2024 -0600
+++ b/docs/zandronum-history.txt	Sat Mar 30 15:40:29 2024 -0400
@@ -133,6 +133,7 @@
 -	- Fixed: STRFTIME would crash Zandronum if a negative was passed into the first argument (addresses 4144). [Ru5tK1ng]
 -	- Fixed: the server would freeze after running for long enough (e.g. 24 days on Windows) due to an integer overflow in SERVER_Tick. [Kaminsky]
 -	- Fixed: the SendToCommunicator special didn't stop the previous sound when online. [DrinkyBird]
+-	- Fixed: A_SpawnItemEx now always syncs AAPTR_TARGET for +MISSILE actors (addresses 4200). [Trillster]
 !	- The result value of GAMEEVENT_MEDALS event scripts can now be used to determine whether or not the player receives the medal. [Kaminsky]
 !	- GAMEMODE flags are now validated after all GAMEMODE lumps have been parsed instead of after each one. The internal game mode name (e.g. "TeamLMS") is now printed with the error message instead of the actual name. [Kaminsky]
 !	- Added an extra check to ensure that game modes have a (short) name. [Kaminsky]
diff -r 2f59d4a1f4d1 -r 5d72fa552084 src/thingdef/thingdef_codeptr.cpp
--- a/src/thingdef/thingdef_codeptr.cpp	Mon Mar 04 09:34:51 2024 -0600
+++ b/src/thingdef/thingdef_codeptr.cpp	Sat Mar 30 15:40:29 2024 -0400
@@ -2655,8 +2655,9 @@
 			if ( mo->Translation )
 				SERVERCOMMANDS_SetThingTranslation( mo );
 
+			// [TRSR] It is useful to always sync the AAPTR_TARGET field for missiles.
 			// [BB] To properly handle actor-actor bouncing, the client must know the target.
-			if ( mo->BounceFlags != BOUNCE_None )
+			if ( mo->flags & MF_MISSILE || mo->BounceFlags != BOUNCE_None )
 				SERVERCOMMANDS_SetThingTarget ( mo );
 
 			// [BB] Set scale if necessary.

Relationships

Notes
(0023306) Trillster (reporter) 2024-03-07 02:44	I've uploaded a patch which fixes this issue. I'm not certain if there's any bad ramifications with A_SpawnItemEx always syncing AAPTR_TARGET, but it does make the client behavior match offline.

(0023511) Trillster (reporter) 2024-03-30 19:47	To mitigate any potential performance concerns, I've uploaded a modified patch which applies this change only for +MISSILE actors. Although it's possible that the initial patch could be fine with testing, after further thought, I'm personally content with only missile actors, since that's mainly where I've seen this issue have impact.

(0023530) Ru5tK1ng (updater) 2024-04-07 20:36	Patch was merged in:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/24cb4e787ef6cc79501ae1862b7717065b2eb7cd [^]'

(0023562) Ru5tK1ng (updater) 2024-04-08 23:16	Using the latest 3.2 beta, I didn't find any issue and the change was tested previously by Trillster.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2024-03-06 03:34	Trillster	New Issue
2024-03-06 03:34	Trillster	File Added: ClientTargetCarryoverFail.pk3
2024-03-07 02:42	Trillster	File Added: 4200.patch
2024-03-07 02:44	Trillster	Note Added: 0023306
2024-03-07 03:50	Ru5tK1ng	Status	new => needs review
2024-03-30 19:47	Trillster	File Added: 4200_2.patch
2024-03-30 19:47	Trillster	Note Added: 0023511
2024-04-07 20:36	Ru5tK1ng	Note Added: 0023530
2024-04-07 20:36	Ru5tK1ng	Status	needs review => needs testing
2024-04-07 20:36	Ru5tK1ng	Target Version	=> 3.2
2024-04-08 23:16	Ru5tK1ng	Note Added: 0023562
2024-04-08 23:16	Ru5tK1ng	Status	needs testing => resolved
2024-04-08 23:16	Ru5tK1ng	Resolution	open => fixed
2024-04-08 23:16	Ru5tK1ng	Fixed in Version	=> 3.2

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.