0000411: Players automatically pick up items upon spawn in (Team)Possession/Terminator

Notes
(0001478) unknownna (updater) 2011-04-26 08:17	This practically means that you pick up the same items twice.

(0001494) unknownna (updater) 2011-04-28 12:16 edited on: 2011-04-28 12:18	This also happens in the Terminator game mode.

(0001516) Torr Samaho (administrator) 2011-04-30 22:57 edited on: 2011-04-30 23:01	Oh, boy. The persons who wrote the possession artifact spawning code apparently had no idea what they were doing (or tried not to think while writing it ;)). And no, it wasn't me who wrote this code :-P. This should fix the issue and also should ensure that a free spawning spot is used if available. I also got rid of some more code duplication (will this ever end?). Note that I didn't touch Terminator yet. Considering the copy and paste coding style that was used before I came to Skulltag, I'm sure I'll need to do the same things for Terminator. Afterwards, the code will be better and shorter though. So, enough ranting for now ;-), please test if Possession works properly now. Please test the whole game mode to ensure that the removal of the duplicate code doesn't have any side effects.

(0001520) unknownna (updater) 2011-05-01 03:01	It fixed the pick up issue. But I noticed in D2DUEL7 that I couldn't find the hellstone anymore. The hellstone appeared outside the map boundaries, sometimes at a coordinate of: x: 0 y: 0 There are 4 deathmatch player starts in the map. 3 bots were in the game. So when the player starts are taken by bots/players, the hellstone is spawned somewhere outside.

(0001524) Torr Samaho (administrator) 2011-05-01 12:24	I see, there was a small bug in the new code. Please test if this fixes the outside of map spawning problems.

(0001526) unknownna (updater) 2011-05-01 13:03	It seems to work now.

(0001532) Torr Samaho (administrator) 2011-05-01 16:43	Good. This also makes terminator use the new artifact spawning code.

(0001534) unknownna (updater) 2011-05-01 17:54	It fixed the issue.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2011-04-26 08:13	unknownna	New Issue
2011-04-26 08:13	unknownna	File Added: possession_pickup_test_01.wad
2011-04-26 08:17	unknownna	Note Added: 0001478
2011-04-28 12:16	unknownna	Note Added: 0001494
2011-04-28 12:18	unknownna	Note Edited: 0001494	View Revisions
2011-04-28 13:04	unknownna	Summary	Players automatically pick up items upon spawn in (Team)Possession => Players automatically pick up items upon spawn in (Team)Possession/Terminator
2011-04-28 13:04	unknownna	Description Updated	View Revisions
2011-04-30 22:57	Torr Samaho	Note Added: 0001516
2011-04-30 23:01	Torr Samaho	Note Edited: 0001516	View Revisions
2011-04-30 23:02	Torr Samaho	Assigned To	=> Torr Samaho
2011-04-30 23:02	Torr Samaho	Status	new => feedback
2011-05-01 03:01	unknownna	Note Added: 0001520
2011-05-01 03:01	unknownna	Status	feedback => assigned
2011-05-01 03:04	unknownna	File Added: Screenshot_Doom_20110501_044233.png
2011-05-01 12:24	Torr Samaho	Note Added: 0001524
2011-05-01 12:27	Torr Samaho	Status	assigned => feedback
2011-05-01 13:03	unknownna	Note Added: 0001526
2011-05-01 13:03	unknownna	Status	feedback => assigned
2011-05-01 16:43	Torr Samaho	Note Added: 0001532
2011-05-01 17:10	Torr Samaho	Status	assigned => feedback
2011-05-01 17:54	unknownna	Note Added: 0001534
2011-05-01 17:54	unknownna	Status	feedback => assigned
2011-05-01 17:55	Torr Samaho	Status	assigned => resolved
2011-05-01 17:55	Torr Samaho	Fixed in Version	=> 1.0
2011-05-01 17:55	Torr Samaho	Resolution	open => fixed
2012-05-01 19:51	unknownna	Relationship added	related to 0000829
2012-06-09 13:22	Torr Samaho	Category	General => Bug
2018-09-30 19:53	Blzut3	Status	resolved => closed