MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000411Zandronum[All Projects] Bugpublic2011-04-26 08:132018-09-30 19:53
Reporterunknownna 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version98d 
Target VersionFixed in Version1.0 
Summary0000411: Players automatically pick up items upon spawn in (Team)Possession/Terminator
DescriptionIt seems that players are hard coded to automatically pick up items upon spawn in (Team)Possession/Terminator.
Steps To Reproduce1. Start Skulltag with the example WAD loaded.
2. "possession 1; map map01" in the console.
Additional Information
TagsNo tags attached.
Relationships
related to 0000829closed Dusk Players automatically pick up items upon spawn after changemap map changes in Coop/Survival 
Attached Files? possession_pickup_test_01.wad (800) 2011-04-26 08:13
/tracker/file_download.php?file_id=277&type=bug
png Screenshot_Doom_20110501_044233.png (39,858) 2011-05-01 03:04
/tracker/file_download.php?file_id=297&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-04-26 08:13unknownnaNew Issue
2011-04-26 08:13unknownnaFile Added: possession_pickup_test_01.wad
2011-04-26 08:17unknownnaNote Added: 0001478
2011-04-28 12:16unknownnaNote Added: 0001494
2011-04-28 12:18unknownnaNote Edited: 0001494bug_revision_view_page.php?bugnote_id=1494#r779
2011-04-28 13:04unknownnaSummaryPlayers automatically pick up items upon spawn in (Team)Possession => Players automatically pick up items upon spawn in (Team)Possession/Terminator
2011-04-28 13:04unknownnaDescription Updatedbug_revision_view_page.php?rev_id=783#r783
2011-04-30 22:57Torr SamahoNote Added: 0001516
2011-04-30 23:01Torr SamahoNote Edited: 0001516bug_revision_view_page.php?bugnote_id=1516#r794
2011-04-30 23:02Torr SamahoAssigned To => Torr Samaho
2011-04-30 23:02Torr SamahoStatusnew => feedback
2011-05-01 03:01unknownnaNote Added: 0001520
2011-05-01 03:01unknownnaStatusfeedback => assigned
2011-05-01 03:04unknownnaFile Added: Screenshot_Doom_20110501_044233.png
2011-05-01 12:24Torr SamahoNote Added: 0001524
2011-05-01 12:27Torr SamahoStatusassigned => feedback
2011-05-01 13:03unknownnaNote Added: 0001526
2011-05-01 13:03unknownnaStatusfeedback => assigned
2011-05-01 16:43Torr SamahoNote Added: 0001532
2011-05-01 17:10Torr SamahoStatusassigned => feedback
2011-05-01 17:54unknownnaNote Added: 0001534
2011-05-01 17:54unknownnaStatusfeedback => assigned
2011-05-01 17:55Torr SamahoStatusassigned => resolved
2011-05-01 17:55Torr SamahoFixed in Version => 1.0
2011-05-01 17:55Torr SamahoResolutionopen => fixed
2012-05-01 19:51unknownnaRelationship addedrelated to 0000829
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2018-09-30 19:53Blzut3Statusresolved => closed

Notes
(0001478)
unknownna   
2011-04-26 08:17   
This practically means that you pick up the same items twice.
(0001494)
unknownna   
2011-04-28 12:16   
(edited on: 2011-04-28 12:18)
This also happens in the Terminator game mode.
(0001516)
Torr Samaho   
2011-04-30 22:57   
(edited on: 2011-04-30 23:01)
Oh, boy. The persons who wrote the possession artifact spawning code apparently had no idea what they were doing (or tried not to think while writing it ;)). And no, it wasn't me who wrote this code :-P. This should fix the issue and also should ensure that a free spawning spot is used if available. I also got rid of some more code duplication (will this ever end?). Note that I didn't touch Terminator yet. Considering the copy and paste coding style that was used before I came to Skulltag, I'm sure I'll need to do the same things for Terminator. Afterwards, the code will be better and shorter though. So, enough ranting for now ;-), please test if Possession works properly now. Please test the whole game mode to ensure that the removal of the duplicate code doesn't have any side effects.
(0001520)
unknownna   
2011-05-01 03:01   
It fixed the pick up issue. But I noticed in D2DUEL7 that I couldn't find the hellstone anymore. The hellstone appeared outside the map boundaries, sometimes at a coordinate of:

x: 0
y: 0

There are 4 deathmatch player starts in the map. 3 bots were in the game. So when the player starts are taken by bots/players, the hellstone is spawned somewhere outside.
(0001524)
Torr Samaho   
2011-05-01 12:24   
I see, there was a small bug in the new code. Please test if this fixes the outside of map spawning problems.
(0001526)
unknownna   
2011-05-01 13:03   
It seems to work now.
(0001532)
Torr Samaho   
2011-05-01 16:43   
Good. This also makes terminator use the new artifact spawning code.
(0001534)
unknownna   
2011-05-01 17:54   
It fixed the issue.