MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0004072DoomseekerUIpublic2022-12-31 02:302024-11-03 19:13
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritylowSeveritytweakReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.3.3 
Target Version1.4.0Fixed in Version1.4.0 
Summary0004072: Ambiguous "Clear" button Create Game
DescriptionThe left-aligned "Clear" button in Create Game window is meant to clear the "Additional WADs and files" list, but it could be misunderstood for a reset button to clear all fields in the window (e.g. server name). If the WAD list is empty when the user presses the button for the first time in their life ever, the user may misunderstand that the button is functionally broken and does nothing ever.
There's no tooltip on hover to explain what the button does.
Steps To ReproduceCreate game (Ctrl + S). Fill in a server name, make sure the additional WADs and files list is empty. Press "Clear". Nothing happens (it would clear the additional WADs list in this case).
Additional Information
$ git describe --tags
1.3.3-111-gc21f2267

Source:'https://bitbucket.org/Doomseeker/doomseeker/src/c21f2267f91b8041e3d2f60d32ad0e3d1ff2219e [^]'
TagsNo tags attached.
Relationships
Attached Filespng 2022-12-31-022439_maim.png (54,672) 2022-12-31 02:30
https://zandronum.com/tracker/file_download.php?file_id=2803&type=bug
png

jpg ds_2022-12-31-1149_creategame.jpg (85,365) 2022-12-31 10:49
https://zandronum.com/tracker/file_download.php?file_id=2814&type=bug
jpg

png ds-20230115-left-align-buttons.png (5,729) 2023-01-15 22:22
https://zandronum.com/tracker/file_download.php?file_id=2834&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-12-31 02:30WubTheCaptainNew Issue
2022-12-31 02:30WubTheCaptainFile Added: 2022-12-31-022439_maim.png
2022-12-31 03:30WubTheCaptainNote Added: 0022595
2022-12-31 03:30WubTheCaptainNote Edited: 0022595bug_revision_view_page.php?bugnote_id=22595#r13843
2022-12-31 03:32WubTheCaptainNote Added: 0022596
2022-12-31 03:38WubTheCaptainNote Added: 0022597
2022-12-31 03:38WubTheCaptainNote Edited: 0022597bug_revision_view_page.php?bugnote_id=22597#r13845
2022-12-31 03:40WubTheCaptainNote Edited: 0022597bug_revision_view_page.php?bugnote_id=22597#r13846
2022-12-31 04:21WubTheCaptainNote Added: 0022603
2022-12-31 10:49ZalewaFile Added: ds_2022-12-31-1149_creategame.jpg
2022-12-31 10:54ZalewaNote Added: 0022608
2022-12-31 10:54ZalewaAssigned To => Zalewa
2022-12-31 10:54ZalewaStatusnew => needs review
2022-12-31 10:54ZalewaTarget Version => 1.4.0
2023-01-05 12:22ZalewaNote Added: 0022653
2023-01-05 12:22ZalewaStatusneeds review => needs testing
2023-01-15 22:22ZalewaFile Added: ds-20230115-left-align-buttons.png
2023-01-15 22:24ZalewaNote Added: 0022701
2023-02-19 14:14ZalewaStatusneeds testing => resolved
2023-02-19 14:14ZalewaFixed in Version => 1.4.0
2023-02-19 14:14ZalewaResolutionopen => fixed
2024-11-03 19:13ZalewaStatusresolved => closed

Notes
(0022595)
WubTheCaptain   
2022-12-31 03:30   
Honestly, I had to ask: Does this "Clear" button even need to exist as is? Pressing "Ctrl + A" in the list selects all the list items, so does click the topmost list item + Shift-click the lowest one, then remove. The only thing missing is that right clicking the list doesn't present an option to select all list items.
If something else, I'd much rather prefer a full "Reset" button in the very bottom left that resets everything in the window to default, fresh values.
(0022596)
WubTheCaptain   
2022-12-31 03:32   
Heck, you can even mouse click-drag in the empty space of the list to select multiple WADS/files with a mouse.
(0022597)
WubTheCaptain   
2022-12-31 03:38   
(edited on: 2022-12-31 03:40)
If the existing "Clear" button should continue to exist, sure, but I'd like to have the whole additional files widget grouped on a darker background (like the Rules tab does) please.
(0022603)
WubTheCaptain   
2022-12-31 04:21   
Related to 0004078, caused me (an user) to misunderstand what "Clear" buttons generally do. One clears textboxes, another doesn't.
(0022608)
Zalewa   
2022-12-31 10:54   
I altered the layout so that the buttons pertaining this list are laid out vertically:'https://bitbucket.org/Doomseeker/doomseeker/commits/5c9f5729c7c672670c0e357feb83e83194b8a016 [^]'
See: ds_2022-12-31-1149_creategame.jpg

Quote from WubTheCaptain
I'd like to have the whole additional files widget grouped on a darker background (like the Rules tab does)

The darker background depends on the OS theme. Windows 10 doesn't do that.

The elements in the Rules tab are placed inside a group box. I first tried to do the same here, but the group box requires some padding to look fine, and this extra padding was squashing the list too much. It didn't look good. Laying out the buttons vertically to the side of the list should achieve the same grouping effect without stealing the precious real estate.

I've also made the list respond to the delete, minus and plus keyboard keys.
(0022653)
Zalewa   
2023-01-05 12:22   
Beta package for Windows available at the beta auto-update channel and at:
'https://devbuilds.drdteam.org/doomseeker/doomseeker-1.3.3~beta-230105-1140_windows.zip [^]'

Please test if the buttons are fine now.
(0022701)
Zalewa   
2023-01-15 22:24   
I had to remove the forced left text-align of the buttons because it was producing really awkward-looking buttons in some themes (see KDE theme in ds-20230115-left-align-buttons.png, Mate theme was even worse).

'https://bitbucket.org/Doomseeker/doomseeker/commits/98bc2e929518c8a012334faab777a2c2a8e59b79 [^]'