Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003979Zandronum[All Projects] Suggestionpublic2022-02-22 14:492022-09-06 18:44
ReporterKaminsky 
Assigned ToKaminsky 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version3.2 
Target Version3.2Fixed in Version3.2 
Summary0003979: "resetmap" CCMD and associated vote type
DescriptionThe following commit:'http://hg.osdn.net/view/zandronum/zandronum-stable/rev/7e1f112cea14 [^]' adds the "resetmap" CCMD to 3.2, which behaves exactly like the "ResetMap" ACS function:'https://wiki.zandronum.com/ResetMap [^]'

This also includes a new corresponding vote type that can be disabled with the "sv_noresetmapvote" CVar.
Attached Filespatch file icon 10804.patch [^] (1,088 bytes) 2022-02-24 08:56 [Show Content]

- Relationships

-  Notes
User avatar (0022144)
DrinkyBird (developer)
2022-02-23 06:33

 Excerpt from Discord a few days ago:
Quote

[04:53] DrinkyBird: not sure whether to default sv_noresetmapvote to true or false
[04:55] Kaminsky: Nice, feel free to share it during next meeting. Personally, I'd default the CVar to false like the rest.
[04:56] Kaminsky: Unless there's a reason why you think it should default to true.


I accidentally left it as true in the patch, should maybe change it to false?
User avatar (0022146)
Kaminsky (developer)
2022-02-23 18:21

 I'd go ahead and create a mini patch that changes the default value to false, since it doesn't seem like it'd be risky to allow "resetmap" votes by default.

For "sv_noflagvote", the only other vote type disabled by default, I did this because most server hosts probably aren't okay with players changing gameplay settings with a vote, especially when they aren't aware of its existence. But if they're okay with this, they can disable the CVar at anytime.
User avatar (0022148)
DrinkyBird (developer)
2022-02-24 08:56

 In that case - super simple patch attached.

I tested the rest of the functionality, and it seems work correctly.
User avatar (0022360)
WaTaKiD (updater)
2022-09-06 16:30

 tested using ZandroDev3.2-220904-2011windows-x86_64 on windows offline, online, and a tspg linux server

resetmap and callvote resetmap seemed to work just fine

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2022-02-22 14:49 Kaminsky New Issue
2022-02-22 14:50 Kaminsky Status new => needs testing
2022-02-23 06:33 DrinkyBird Note Added: 0022144
2022-02-23 18:21 Kaminsky Note Added: 0022146
2022-02-24 08:56 DrinkyBird File Added: 10804.patch
2022-02-24 08:56 DrinkyBird Note Added: 0022148
2022-09-06 16:30 WaTaKiD Note Added: 0022360
2022-09-06 18:44 Kaminsky Status needs testing => resolved
2022-09-06 18:44 Kaminsky Fixed in Version => 3.2
2022-09-06 18:44 Kaminsky Resolution open => fixed
2022-09-06 18:44 Kaminsky Assigned To => Kaminsky




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker