0003880: Odamex: Update to protocol version 7

Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0003880

Doomseeker

public

2021-02-19 04:56

2021-08-10 05:48

Reporter

AlexMax

Assigned To

Pol M

Priority

normal

Severity

tweak

Reproducibility

N/A

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

1.3.2

Fixed in Version

1.3.2

Summary

0003880: Odamex: Update to protocol version 7

Description

I did some research on the Odamex plugin for Doomseeker, and it appears that it uses an outdated query protocol version 5.

We are now up to version 7. I was not around for these bumps, but from what I can tell, each bump includes two incredibly minor changes, and rather than try to explain it in a bug report, I'd rather just link to the protocol reader directly out of our source tree.

'https://github.com/odamex/odamex/blob/0.8.3/odalpapi/net_packet.cpp#L330 [^]'

The two spots marked with QRYNEWINFO seem to be the sum total of changes. In order to activate these changes, you need to bump SERVER_CHALLENGE on your end,. specifically bumping the 5 to a 7.

Additional Information

This is not a 0.9 change, so regardless if you do it now or after 0.9 is released, you can see the results. The reason I would like this protocol update is to make the "revision" part of the popup more useful; since our move to git we broadcast our revision as a string and being able to see the revision in Odalaunch has proven to be incredibly useful. Plus, the way it looks right now looks...kind of broken.

Attached Files

doomseeker_La8Gt7hapB.png [^] (15,701 bytes) 2021-02-19 04:56

Relationships

Notes
(0021604) WubTheCaptain (reporter) 2021-03-03 23:57	Thanks. Looks like those didn't exist in Odamex tag 0.7.0 source, but were present since tag 0.8.0. The file to patch in Doomseeker is doomseeker/src/plugins/odamex/odamexserver.cpp. Looks like: Version 6 added Info.TimeLimit (sv_timelimit); Version 7 added Info.VersionRevStr.

(0021612) Pol M (developer) 2021-06-15 11:44	Hey, sorry for not checking by! I'll make sure to check this out once personal stuff clears! Thank you for telling us!

(0021618) Blzut3 (administrator) 2021-06-28 23:19	Addressed as part of 0003878.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2021-02-19 04:56	AlexMax	New Issue
2021-02-19 04:56	AlexMax	File Added: doomseeker_La8Gt7hapB.png
2021-03-03 23:57	WubTheCaptain	Note Added: 0021604
2021-03-03 23:57	WubTheCaptain	Status	new => confirmed
2021-03-03 23:58	WubTheCaptain	Severity	feature => tweak
2021-06-15 11:44	Pol M	Note Added: 0021612
2021-06-27 13:03	Pol M	Assigned To	=> Pol M
2021-06-27 13:03	Pol M	Status	confirmed => assigned
2021-06-28 19:56	Pol M	Status	assigned => needs review
2021-06-28 23:19	Blzut3	Note Added: 0021618
2021-06-28 23:19	Blzut3	Status	needs review => needs testing
2021-08-07 16:43	Blzut3	Fixed in Version	=> 1.3.2
2021-08-07 16:43	Blzut3	Target Version	=> 1.3.2
2021-08-08 10:35	Zalewa	Status	needs testing => resolved
2021-08-08 10:35	Zalewa	Resolution	open => fixed
2021-08-10 05:48	WubTheCaptain	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.