MantisBT - Doomseeker
View Issue Details
0003880DoomseekerUIpublic2021-02-19 04:562021-08-10 05:48
AlexMax 
Pol M 
normaltweakN/A
closedfixed 
 
1.3.21.3.2 
0003880: Odamex: Update to protocol version 7
I did some research on the Odamex plugin for Doomseeker, and it appears that it uses an outdated query protocol version 5.

We are now up to version 7. I was not around for these bumps, but from what I can tell, each bump includes two incredibly minor changes, and rather than try to explain it in a bug report, I'd rather just link to the protocol reader directly out of our source tree.

'https://github.com/odamex/odamex/blob/0.8.3/odalpapi/net_packet.cpp#L330 [^]'

The two spots marked with QRYNEWINFO seem to be the sum total of changes. In order to activate these changes, you need to bump SERVER_CHALLENGE on your end,. specifically bumping the 5 to a 7.
This is not a 0.9 change, so regardless if you do it now or after 0.9 is released, you can see the results. The reason I would like this protocol update is to make the "revision" part of the popup more useful; since our move to git we broadcast our revision as a string and being able to see the revision in Odalaunch has proven to be incredibly useful. Plus, the way it looks right now looks...kind of broken.
No tags attached.
png doomseeker_La8Gt7hapB.png (15,701) 2021-02-19 04:56
https://zandronum.com/tracker/file_download.php?file_id=2640&type=bug
png
Issue History
2021-02-19 04:56AlexMaxNew Issue
2021-02-19 04:56AlexMaxFile Added: doomseeker_La8Gt7hapB.png
2021-03-03 23:57WubTheCaptainNote Added: 0021604
2021-03-03 23:57WubTheCaptainStatusnew => confirmed
2021-03-03 23:58WubTheCaptainSeverityfeature => tweak
2021-06-15 11:44Pol MNote Added: 0021612
2021-06-27 13:03Pol MAssigned To => Pol M
2021-06-27 13:03Pol MStatusconfirmed => assigned
2021-06-28 19:56Pol MStatusassigned => needs review
2021-06-28 23:19Blzut3Note Added: 0021618
2021-06-28 23:19Blzut3Statusneeds review => needs testing
2021-08-07 16:43Blzut3Fixed in Version => 1.3.2
2021-08-07 16:43Blzut3Target Version => 1.3.2
2021-08-08 10:35ZalewaStatusneeds testing => resolved
2021-08-08 10:35ZalewaResolutionopen => fixed
2021-08-10 05:48WubTheCaptainStatusresolved => closed

Notes
(0021604)
WubTheCaptain   
2021-03-03 23:57   
Thanks. Looks like those didn't exist in Odamex tag 0.7.0 source, but were present since tag 0.8.0.
The file to patch in Doomseeker is doomseeker/src/plugins/odamex/odamexserver.cpp.

Looks like:
  • Version 6 added Info.TimeLimit (sv_timelimit);
  • Version 7 added Info.VersionRevStr.
(0021612)
Pol M   
2021-06-15 11:44   
Hey, sorry for not checking by! I'll make sure to check this out once personal stuff clears! Thank you for telling us!
(0021618)
Blzut3   
2021-06-28 23:19   
Addressed as part of 0003878.