Zandronum Chat on our Discord Server Get the latest version: 3.2.1
Source Code
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003807Doomseeker[All Projects] Cleanuppublic2020-06-07 03:292020-06-07 19:47
ReporterWubTheCaptain 
Assigned To 
PrioritynoneSeveritytweakReproducibilitysometimes
StatusconfirmedResolutionopen 
PlatformOSOS Version
Product Version1.3.1 
Target VersionFixed in Version 
Summary0003807: Some for(...; ...; ...) loops are not range-based loops (C++11), but C-style
DescriptionMost of Doomseeker is written in C++, but there are for loops that are C-style (inherited from C++98).

Let's modernize to C++11 and beyond?
Steps To Reproduce
$ grep -r "for (" src/ | wc -l
968
$ grep -r "for (" src/ | grep "&" | grep ":" | wc -l
283
$ grep -r "for(" src/ | wc -l
16


The ones with "for(" were all third-party dependencies, however. Not accounting for any C files, if there are any.
Additional Information'https://clang.llvm.org/extra/clang-tidy/checks/modernize-loop-convert.html [^]'
Attached Files

- Relationships
child of 0003803confirmed C++11 support 

-  Notes
User avatar (0021379)
Pol M (developer)
2020-06-07 19:46

 Sure, no problem. That said, sometimes c-style for loops are necessary, so don't be surprised if we can't simply use them everywhere.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2020-06-07 03:29 WubTheCaptain New Issue
2020-06-07 03:29 WubTheCaptain Relationship added child of 0003803
2020-06-07 03:29 WubTheCaptain Steps to Reproduce Updated View Revisions
2020-06-07 03:31 WubTheCaptain Reproducibility have not tried => sometimes
2020-06-07 19:46 Pol M Note Added: 0021379
2020-06-07 19:47 Pol M Status new => confirmed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker