Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003734Doomseeker[All Projects] Bugpublic2020-01-22 06:592020-02-13 01:54
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritynormalSeverityblockReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSMicrosoft WindowsOS Version
Product Version1.3 
Target Version1.3.1Fixed in Version1.3.1 
Summary0003734: Missing complete corresponding source for Doomseeker 1.3 on Windows after issue 0003728
DescriptionA shortcut was taken at 0003728:0021091:
Quote from Zalewa
The fix is deployed for Windows to the stable and beta update channels, the DRD Team site and silently to Doomseeker's official site. I replaced the SRB2 plugin in the zip for version 1.3.

The binary build for Windows isn't a complete corresponding to the 1.3 source distribution anymore: 1.3 sources (provided) can't be used to built the distributed Windows build (doomseeker-1.3_windows.zip). This could theoretically cause a copyright infringement for redistributors under the LGPL license.
The fix here would be releasing Doomseeker 1.3.1 (or 1.3.0.1) with the complete corresponding source code.
(It's also sometimes confusing for users which version of Doomseeker 1.3 they have, with the SRB2 plugin patch or without.)
Steps To Reproduce
Quote from Index of /files
      doomseeker-1.3.tar.xz   2019-07-28 17:56  3.9M  
      doomseeker-1.3.tar.x..> 2019-07-28 17:57  310   
      doomseeker-1.3_macos..> 2019-07-28 17:56   18M  
      doomseeker-1.3_windo..> 2020-01-19 03:26   14M  

ships with 1.3 +https://bitbucket.org/Doomseeker/doomseeker/commits/b623ab1412ab1fefde469c9f298e94c8087e6368 [^]
https://bitbucket.org/Doomseeker/doomseeker/src/b623ab1412ab1fefde469c9f298e94c8087e6368/src/plugins/srb2/srb2server.cpp [^]
https://bitbucket.org/Doomseeker/doomseeker/src/1.3/src/plugins/srb2/srb2server.cpp [^]
Additional Information
Quote
$ git shortlog src/plugins/srb2/srb2server.cpp
Braden Obrzut (2):
      - Rename strings.h to strings.hpp to avoid conflict with glibc (specifically 2.26 since string.h 
now includes it).
      - Relicensed Doomseeker and plugins to LGPLv2.1+. This simplifies are distribution in regards to 
linking against different versions of Qt. I in good faith believe I have obtained permission from all 
contributors who have made copyrightable contributions.

Pol Marcet Sardà (1):
      - Change NULL into nullptr.

Zalewa (8):
      - SRB2: Skeleton plugin. Can contact master server.
      - SRB2: Query servers for detailed info and properly display them on the server list.
      - SRB2: Enforce looking for WADs in "<srb2dir>/DOWNLOAD" directory if all other 
directories fail. - No need for #ifdef Q_OS_MAC before checking for QFileInfo::isBundle(). According 
to doc, method always returns false on non-Mac systems.
      - SRB2: Reset server info before querying; fixes problem with known servers not refreshing properly. 
- SRB2: Read server info in little-endian format.
      - Normalize line endings in source files to the ones that were already dominant in each file.
      
- Uncrustify .cpp files in accordance to the proposed uncrustify configuration
      - Replace all Qt's foreach with C++'s range-for
      SRB2 server can have no WADs at all, anticipate that; should fix 0003728


https://www.gnu.org/licenses/old-licenses/lgpl-2.1.en.html [^]
Attached Filespatch file icon 0001-SRB2-server-can-have-no-WADs-at-all-anticipate-that-.patch [^] (2,117 bytes) 2020-01-22 07:24 [Show Content]

- Relationships
related to 0003728closedZalewa Doomseeker randomly crashes when loading the server list 
related to 0003742resolvedZalewa Doomseeker 1.3.1 for Windows needs to be released 

-  Notes
User avatar (0021130)
WubTheCaptain (developer)
2020-01-27 22:16
edited on: 2020-01-27 22:16

0003735:0021124:
Quote from Zalewa
I'll bring back the SRB2 plugin in the 1.3 Windows package to its original state after 1.3.1 release is complete (0003734).


User avatar (0021153)
WubTheCaptain (developer)
2020-01-30 12:47

Quote from Index of /files
      doomseeker-1.3.1.tar.xz 2020-01-29 17:25  3.9M  
      doomseeker-1.3.1.tar..> 2020-01-29 17:25  310   
      doomseeker-1.3.1_mac..> 2020-01-29 18:12   18M  
      doomseeker-1.3.1_win..> 2020-01-27 13:23   14M  
      doomseeker-1.3.tar.xz   2019-07-28 17:56  3.9M  
      doomseeker-1.3.tar.x..> 2019-07-28 17:57  310   
      doomseeker-1.3_macos..> 2019-07-28 17:56   18M  
      doomseeker-1.3_windo..> 2020-01-19 03:26   14M  
User avatar (0021190)
Zalewa (developer)
2020-02-09 11:26

Old .zip restored for 1.3.
https://doomseeker.drdteam.org/files/doomseeker-1.3_windows.zip [^]
User avatar (0021198)
WubTheCaptain (developer)
2020-02-13 01:50
edited on: 2020-02-13 01:52

$ sha256sum doomseeker-1.3_windows.zip
9a4134ce843ddbb05bd69d1b9da7edeb49935275ddab5dc38b35c80c3defe327 doomseeker-1.3_windows.zip
$ sha256sum doomseeker.exe
79e927b3b86361dc304ab3cacafa9136cce543247612378e3aacf1003a5f9e36 doomseeker.exe


User avatar (0021199)
WubTheCaptain (developer)
2020-02-13 01:54

Quote from Index of /files
      doomseeker-1.3.tar.xz   2019-07-28 17:56  3.9M  
      doomseeker-1.3.tar.x..> 2019-07-28 17:57  310   
      doomseeker-1.3_macos..> 2019-07-28 17:56   18M  
      doomseeker-1.3_windo..> 2020-02-09 03:25   14M  


I didn't test if it's the actual version (I'm using GNU/Linux), but I'm hoping so – resolved.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2020-01-22 06:59 WubTheCaptain New Issue
2020-01-22 06:59 WubTheCaptain Assigned To => Zalewa
2020-01-22 06:59 WubTheCaptain Status new => assigned
2020-01-22 07:00 WubTheCaptain Status assigned => new
2020-01-22 07:00 WubTheCaptain Status new => assigned
2020-01-22 07:00 WubTheCaptain Description Updated View Revisions
2020-01-22 07:00 WubTheCaptain Status assigned => new
2020-01-22 07:01 WubTheCaptain Severity minor => block
2020-01-22 07:01 WubTheCaptain Status new => assigned
2020-01-22 07:02 WubTheCaptain Status assigned => new
2020-01-22 07:05 WubTheCaptain Relationship added related to 0003728
2020-01-22 07:16 WubTheCaptain File Added: 0001-SRB2-server-can-have-no-WADs-at-all-anticipate-that-.patch
2020-01-22 07:20 WubTheCaptain File Deleted: 0001-SRB2-server-can-have-no-WADs-at-all-anticipate-that-.patch
2020-01-22 07:20 WubTheCaptain File Added: 0001-SRB2-server-can-have-no-WADs-at-all-anticipate-that-.patch
2020-01-22 07:21 WubTheCaptain File Deleted: 0001-SRB2-server-can-have-no-WADs-at-all-anticipate-that-.patch
2020-01-22 07:21 WubTheCaptain File Added: 0001-SRB2-server-can-have-no-WADs-at-all-anticipate-that-.patch
2020-01-22 07:22 WubTheCaptain File Deleted: 0001-SRB2-server-can-have-no-WADs-at-all-anticipate-that-.patch
2020-01-22 07:24 WubTheCaptain File Added: 0001-SRB2-server-can-have-no-WADs-at-all-anticipate-that-.patch
2020-01-27 20:27 WubTheCaptain Status new => confirmed
2020-01-27 20:27 WubTheCaptain Target Version => 1.3.1
2020-01-27 21:43 WubTheCaptain Relationship added related to 0003742
2020-01-27 22:16 WubTheCaptain Note Added: 0021130
2020-01-27 22:16 WubTheCaptain Note Edited: 0021130 View Revisions
2020-01-27 22:16 WubTheCaptain Note Edited: 0021130 View Revisions
2020-01-30 12:47 WubTheCaptain Note Added: 0021153
2020-01-30 12:47 WubTheCaptain Status confirmed => assigned
2020-01-30 16:53 WubTheCaptain OS => Microsoft Windows
2020-02-09 11:26 Zalewa Note Added: 0021190
2020-02-09 11:26 Zalewa Status assigned => needs testing
2020-02-13 01:50 WubTheCaptain Note Added: 0021198
2020-02-13 01:52 WubTheCaptain Note Edited: 0021198 View Revisions
2020-02-13 01:54 WubTheCaptain Note Added: 0021199
2020-02-13 01:54 WubTheCaptain Status needs testing => resolved
2020-02-13 01:54 WubTheCaptain Fixed in Version => 1.3.1
2020-02-13 01:54 WubTheCaptain Resolution open => fixed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2020 MantisBT Team
Powered by Mantis Bugtracker