0003734: Missing complete corresponding source for Doomseeker 1.3 on Windows after issue #3728

MantisBT - Doomseeker

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0003734

Doomseeker

[All Projects] Bug

public

2020-01-22 06:59

2021-08-07 16:53

Reporter

WubTheCaptain

Assigned To

Zalewa

Priority

normal

Severity

block

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Microsoft Windows

OS Version

Product Version

1.3

Target Version

1.3.1

Fixed in Version

1.3.1

Summary

0003734: Missing complete corresponding source for Doomseeker 1.3 on Windows after issue /tracker/view.php?id=3728

Description

A shortcut was taken at 0003728:0021091:

Quote from Zalewa
The fix is deployed for Windows to the stable and beta update channels, the DRD Team site and silently to Doomseeker's official site. I replaced the SRB2 plugin in the zip for version 1.3.

The binary build for Windows isn't a complete corresponding to the 1.3 source distribution anymore: 1.3 sources (provided) can't be used to built the distributed Windows build (doomseeker-1.3_windows.zip). This could theoretically cause a copyright infringement for redistributors under the LGPL license.
The fix here would be releasing Doomseeker 1.3.1 (or 1.3.0.1) with the complete corresponding source code.
(It's also sometimes confusing for users which version of Doomseeker 1.3 they have, with the SRB2 plugin patch or without.)

Steps To Reproduce

Quote from Index of /files

      doomseeker-1.3.tar.xz   2019-07-28 17:56  3.9M  
      doomseeker-1.3.tar.x..> 2019-07-28 17:57  310   
      doomseeker-1.3_macos..> 2019-07-28 17:56   18M  
      doomseeker-1.3_windo..> 2020-01-19 03:26   14M

ships with 1.3 +'https://bitbucket.org/Doomseeker/doomseeker/commits/b623ab1412ab1fefde469c9f298e94c8087e6368 [^]'
'https://bitbucket.org/Doomseeker/doomseeker/src/b623ab1412ab1fefde469c9f298e94c8087e6368/src/plugins/srb2/srb2server.cpp [^]'
'https://bitbucket.org/Doomseeker/doomseeker/src/1.3/src/plugins/srb2/srb2server.cpp [^]'

Additional Information

Quote

$ git shortlog src/plugins/srb2/srb2server.cpp
Braden Obrzut (2):
      - Rename strings.h to strings.hpp to avoid conflict with glibc (specifically 2.26 since string.h 
now includes it).
      - Relicensed Doomseeker and plugins to LGPLv2.1+. This simplifies are distribution in regards to 
linking against different versions of Qt. I in good faith believe I have obtained permission from all 
contributors who have made copyrightable contributions.

Pol Marcet Sardà (1):
      - Change NULL into nullptr.

Zalewa (8):
      - SRB2: Skeleton plugin. Can contact master server.
      - SRB2: Query servers for detailed info and properly display them on the server list.
      - SRB2: Enforce looking for WADs in "<srb2dir>/DOWNLOAD" directory if all other 
directories fail. - No need for #ifdef Q_OS_MAC before checking for QFileInfo::isBundle(). According 
to doc, method always returns false on non-Mac systems.
      - SRB2: Reset server info before querying; fixes problem with known servers not refreshing properly. 
- SRB2: Read server info in little-endian format.
      - Normalize line endings in source files to the ones that were already dominant in each file.
      
- Uncrustify .cpp files in accordance to the proposed uncrustify configuration
      - Replace all Qt's foreach with C++'s range-for
      SRB2 server can have no WADs at all, anticipate that; should fix 0003728

'https://www.gnu.org/licenses/old-licenses/lgpl-2.1.en.html [^]'

Tags

No tags attached.

Relationships

related to	0003728	closed	Zalewa	Doomseeker randomly crashes when loading the server list
related to	0003742	closed	Zalewa	Doomseeker 1.3.1 for Windows needs to be released

Attached Files

0001-SRB2-server-can-have-no-WADs-at-all-anticipate-that-.patch (2,117) 2020-01-22 07:24
/tracker/file_download.php?file_id=2522&type=bug

Issue History

Date Modified

Username

Field

Change

2020-01-22 06:59