Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003731DoomseekerUIpublic2020-01-19 13:172024-11-03 19:11
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritynoneSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.3 
Target Version1.4.0Fixed in Version1.4.0 
Summary0003731: An up-to-date IP2C database can still be manually "updated" from the UI (even if there's no reason to do so)
DescriptionThe "UPDATE!" button is always enabled, even if there's no reason to click on it. It's expected the button would be disabled if there's no reason to update.
Steps To ReproduceFile → Update IP2C. Play around with its UI, using system IP2C database and user database as indicated in the screenshots.
Attached Filespng file icon 2020-01-19-131424_maim.png [^] (29,222 bytes) 2020-01-19 13:17


png file icon 2020-01-19-131259_maim.png [^] (29,991 bytes) 2020-01-19 13:17


jpg file icon doomseeker-ip2c-uptodate_20221110.jpg [^] (17,839 bytes) 2022-11-10 21:55

- Relationships

-  Notes
User avatar (0021098)
Zalewa (developer)
2020-01-19 13:29

 The title of the button should be something like "Download again" in such case.
User avatar (0021100)
WubTheCaptain (reporter)
2020-01-19 13:45
edited on: 2020-01-19 13:51

 But the local file hashes are checked to match against the remote, so what is the use case for "download again" here in OP's specific scenarios?
User avatar (0022485)
Zalewa (developer)
2022-11-10 22:02

 I decided to do this as requested and the dialog box will now have a simplified appearance if the database is up-to-date. The drawback is when the update is allowed, then the box has a lot more widgets and will auto-expand vertically, which isn't the best user experience. But, if I keep the size of the box the same, regardless of the contents/state, then the up-to-date box gets a lot of blank space and appears empty. Actually, on the attached screen "doomseeker-ip2c-uptodate_20221110.jpg" you can already see that there's a bit of empty vertical space. Some of it is normally taken by a progress bar that pops up at start at then disappears. I opted not to shrink the dialog box when this happens.

Still, I think I can do a slightly better job with reducing even this vertical blank space, but the auto-expand effect in case of possible update will be even more prominent.

For now, this is the commit for this ticket:'https://bitbucket.org/Doomseeker/doomseeker/commits/f5de0f9bda0e38bd146cf50e1cc455507dcbe925 [^]'
User avatar (0022486)
Zalewa (developer)
2022-11-11 10:41

 A bug has creeped in the previous commit where the UI didn't offer to download the DB if there was no DB at all:'https://bitbucket.org/Doomseeker/doomseeker/commits/5750e11a5b7604794342e82736519234925677d3 [^]'

And the cosmetic issues should be solved here:'https://bitbucket.org/Doomseeker/doomseeker/commits/6b183a6bf57529a022d76ac3669d4d950a3b8c37 [^]' (word-wrapping QLabels are eurghhh).
User avatar (0022492)
WubTheCaptain (reporter)
2022-11-11 15:33
edited on: 2022-11-11 15:35
Quote
IP2C database file was not found. Use the update button if you want to download the newest database.

Copyedit maybe required, because the button text was changed from "UPDATE!" to "DOWNLOAD!".
$ git describe --tags
1.3.3-49-gd7638cb2
User avatar (0022493)
WubTheCaptain (reporter)
2022-11-11 15:38

 Commit 6b183a6 incorrectly states it updates the button text to "DOWNLOAD!", however that was actually done in the previous commit 5750e11. 🙂
User avatar (0022494)
Zalewa (developer)
2022-11-11 19:58

 meh, stupid mistake, again
User avatar (0022500)
WubTheCaptain (reporter)
2022-11-18 02:07
Quote from WubTheCaptain
Quote
IP2C database file was not found. Use the update button if you want to download the newest database.

Copyedit maybe required, because the button text was changed from "UPDATE!" to "DOWNLOAD!".
$ git describe --tags
1.3.3-49-gd7638cb2

So, will the text remain to refer to an "update button", although it's been renamed?
User avatar (0022575)
Zalewa (developer)
2022-12-30 18:33
edited on: 2022-12-31 08:35

 Ok, the text problem mentioned in 0003731:0022492 should be fixed now:'https://bitbucket.org/Doomseeker/doomseeker/commits/61fe58742955921f22beaece053abea826f4aab9 [^]'

I've also normalized the text in the install buttons to use natural capitalization (as per 0003676)
User avatar (0022580)
WubTheCaptain (reporter)
2022-12-30 23:33
Quote from Zalewa
Ok, the text problem mentioned in 0003731:0022493

Correction: 0003731:0022492 (and 0003731:0022500) should be fixed now. Which in itself looks fine to me.
User avatar (0022652)
Zalewa (developer)
2023-01-05 12:21

 Beta package for Windows available at the beta auto-update channel and at:
'https://devbuilds.drdteam.org/doomseeker/doomseeker-1.3.3~beta-230105-1140_windows.zip [^]'

Please verify that only the correctly named buttons appear when the database is gone completely (Download) and when its checksum mismatches (Update).
User avatar (0022696)
Zalewa (developer)
2023-01-14 13:25

 I've looked at this box enough. It's fixed.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2020-01-19 13:17 WubTheCaptain New Issue
2020-01-19 13:17 WubTheCaptain File Added: 2020-01-19-131424_maim.png
2020-01-19 13:17 WubTheCaptain File Added: 2020-01-19-131259_maim.png
2020-01-19 13:18 WubTheCaptain Summary An up-to-date IP2C database can still be manually updated from the UI (even if there's no reason to do so) => An up-to-date IP2C database can still be manually "updated" from the UI (even if there's no reason to do so)
2020-01-19 13:29 Zalewa Note Added: 0021098
2020-01-19 13:45 WubTheCaptain Note Added: 0021100
2020-01-19 13:45 WubTheCaptain Status new => acknowledged
2020-01-19 13:51 WubTheCaptain Note Edited: 0021100 View Revisions
2022-09-10 14:57 Zalewa Target Version => 1.4.0
2022-11-10 21:55 Zalewa File Added: doomseeker-ip2c-uptodate_20221110.jpg
2022-11-10 21:56 Zalewa Assigned To => Zalewa
2022-11-10 21:56 Zalewa Status acknowledged => assigned
2022-11-10 22:02 Zalewa Note Added: 0022485
2022-11-11 10:41 Zalewa Note Added: 0022486
2022-11-11 10:41 Zalewa Status assigned => needs review
2022-11-11 15:33 WubTheCaptain Note Added: 0022492
2022-11-11 15:34 WubTheCaptain Note Edited: 0022492 View Revisions
2022-11-11 15:35 WubTheCaptain Note Edited: 0022492 View Revisions
2022-11-11 15:38 WubTheCaptain Note Added: 0022493
2022-11-11 19:58 Zalewa Note Added: 0022494
2022-11-11 19:58 Zalewa Status needs review => needs testing
2022-11-18 02:07 WubTheCaptain Note Added: 0022500
2022-12-30 16:35 Zalewa Status needs testing => assigned
2022-12-30 18:33 Zalewa Note Added: 0022575
2022-12-30 18:33 Zalewa Status assigned => needs review
2022-12-30 23:33 WubTheCaptain Note Added: 0022580
2022-12-31 08:35 Zalewa Note Edited: 0022575 View Revisions
2023-01-05 12:21 Zalewa Note Added: 0022652
2023-01-05 12:21 Zalewa Status needs review => needs testing
2023-01-14 13:25 Zalewa Note Added: 0022696
2023-01-14 13:25 Zalewa Status needs testing => resolved
2023-01-14 13:25 Zalewa Fixed in Version => 1.4.0
2023-01-14 13:25 Zalewa Resolution open => fixed
2024-11-03 19:11 Zalewa Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker