Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003554Doomseeker[All Projects] Bugpublic2018-10-13 12:122018-10-27 22:53
ReporterZalewa 
Assigned ToZalewa 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.1 
Target Version1.2Fixed in Version1.2 
Summary0003554: Translations for SRB2 and Turok 2 Ex plugins do not load
DescriptionThis happens because translation files are discovered by plugins canonical names, which in turn are derived from plugins human-readable names. The rules of derivation are simple and boil down to lowercasing all letters and removal of whitespace.

This works for Zandronum and Odamex plugins, because filenames of their translation files are "zandronum_*.qm" and "odamex_*.qm" respectively. In case of Turok 2 Ex and SRB2, the plugin's readable names are too different from the names of the translation files. "Turok 2 Remaster" doesn't match "turok2ex_*.qm" and "Sonic Robo Blast 2" doesn't match "srb2_*.qm".

While this problem may be resolved by changing the filenames, I think a more appropriate solution is to allow plugins to explicitly specify their canonical names.
Attached Files

- Relationships

-  Notes
User avatar (0020091)
Zalewa (developer)
2018-10-13 12:48

 Commit that introduces EP_CanonicalName plugin setting:
'https://bitbucket.org/Doomseeker/doomseeker/commits/39e2e219c8a706087e10975272b0196399ecaa51 [^]'
User avatar (0020092)
WubTheCaptain (reporter)
2018-10-13 13:45

 Needs changelog.
User avatar (0020094)
Zalewa (developer)
2018-10-13 14:16

 Changelog updated:'https://bitbucket.org/Doomseeker/doomseeker/commits/d8e7f2b27981ebfb13e41c5b93857216514a0e00 [^]'
User avatar (0020098)
WubTheCaptain (reporter)
2018-10-13 16:04

 I guess EP_CanonicalName will be automatically documented, though I wonder if that needs a mention in the changelog.
User avatar (0020099)
Zalewa (developer)
2018-10-13 16:16
Quote from WubTheCaptain
I guess EP_CanonicalName will be automatically documented, though I wonder if that needs a mention in the changelog.

We haven't been including plugin API changes in the changelog so far. There are some mentions of the changes in Wadseeker's API, however. Keeping a changelog on the API could be reconsidered, but I don't know if mixing the plugin API changes with end-user changes is a good idea. End-user normally doesn't care about the internal API. Further considerations in this regard are more fitting to 0003517.
User avatar (0020110)
WubTheCaptain (reporter)
2018-10-13 18:08

 I remember seeing this issue few days ago before Zalewa reported it, but never got to test it.

Anyway, should be good now:

[18:06:56] Loading translations definitions
[18:06:56] Reading localizations definitions file: translations.def
[18:06:56] Loading translation "es_ES".
[18:06:56] Found translation 'qtbase_es_ES' in dir '/usr/share/qt5/translations'.
[18:06:56] Found translation 'qtmultimedia_es_ES' in dir '/usr/share/qt5/translations'.
[18:06:56] Found translation 'es_ES' in dir '/tmp/doomseeker/translations'.
[18:06:56] Found translation 'odamex_es_ES' in dir '/tmp/doomseeker/translations'.
[18:06:56] Loaded translation for plugin odamex
[18:06:56] Found translation 'srb2_es_ES' in dir '/tmp/doomseeker/translations'.
[18:06:56] Loaded translation for plugin srb2
[18:06:56] Found translation 'turok2ex_es_ES' in dir '/tmp/doomseeker/translations'.
[18:06:56] Loaded translation for plugin turok2ex
[18:06:56] Found translation 'zandronum_es_ES' in dir '/tmp/doomseeker/translations'.
[18:06:56] Loaded translation for plugin zandronum
[18:06:56] Traducción cargada.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2018-10-13 12:12 Zalewa New Issue
2018-10-13 12:12 Zalewa Status new => assigned
2018-10-13 12:12 Zalewa Assigned To => Zalewa
2018-10-13 12:48 Zalewa Note Added: 0020091
2018-10-13 12:48 Zalewa Status assigned => needs testing
2018-10-13 13:42 WubTheCaptain Product Version => 1.1
2018-10-13 13:45 WubTheCaptain Note Added: 0020092
2018-10-13 13:45 WubTheCaptain Status needs testing => needs review
2018-10-13 14:16 Zalewa Note Added: 0020094
2018-10-13 16:04 WubTheCaptain Note Added: 0020098
2018-10-13 16:04 WubTheCaptain Status needs review => needs testing
2018-10-13 16:16 Zalewa Note Added: 0020099
2018-10-13 18:08 WubTheCaptain Note Added: 0020110
2018-10-13 18:08 WubTheCaptain Status needs testing => resolved
2018-10-13 18:08 WubTheCaptain Fixed in Version => 1.2
2018-10-13 18:08 WubTheCaptain Resolution open => fixed
2018-10-27 22:53 WubTheCaptain Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker