MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003554Doomseeker[All Projects] Bugpublic2018-10-13 12:122018-10-27 22:53
ReporterZalewa 
Assigned ToZalewa 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.1 
Target Version1.2Fixed in Version1.2 
Summary0003554: Translations for SRB2 and Turok 2 Ex plugins do not load
DescriptionThis happens because translation files are discovered by plugins canonical names, which in turn are derived from plugins human-readable names. The rules of derivation are simple and boil down to lowercasing all letters and removal of whitespace.

This works for Zandronum and Odamex plugins, because filenames of their translation files are "zandronum_*.qm" and "odamex_*.qm" respectively. In case of Turok 2 Ex and SRB2, the plugin's readable names are too different from the names of the translation files. "Turok 2 Remaster" doesn't match "turok2ex_*.qm" and "Sonic Robo Blast 2" doesn't match "srb2_*.qm".

While this problem may be resolved by changing the filenames, I think a more appropriate solution is to allow plugins to explicitly specify their canonical names.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-10-13 12:12ZalewaNew Issue
2018-10-13 12:12ZalewaStatusnew => assigned
2018-10-13 12:12ZalewaAssigned To => Zalewa
2018-10-13 12:48ZalewaNote Added: 0020091
2018-10-13 12:48ZalewaStatusassigned => needs testing
2018-10-13 13:42WubTheCaptainProduct Version => 1.1
2018-10-13 13:45WubTheCaptainNote Added: 0020092
2018-10-13 13:45WubTheCaptainStatusneeds testing => needs review
2018-10-13 14:16ZalewaNote Added: 0020094
2018-10-13 16:04WubTheCaptainNote Added: 0020098
2018-10-13 16:04WubTheCaptainStatusneeds review => needs testing
2018-10-13 16:16ZalewaNote Added: 0020099
2018-10-13 18:08WubTheCaptainNote Added: 0020110
2018-10-13 18:08WubTheCaptainStatusneeds testing => resolved
2018-10-13 18:08WubTheCaptainFixed in Version => 1.2
2018-10-13 18:08WubTheCaptainResolutionopen => fixed
2018-10-27 22:53WubTheCaptainStatusresolved => closed

Notes
(0020091)
Zalewa   
2018-10-13 12:48   
Commit that introduces EP_CanonicalName plugin setting:
'https://bitbucket.org/Doomseeker/doomseeker/commits/39e2e219c8a706087e10975272b0196399ecaa51 [^]'
(0020092)
WubTheCaptain   
2018-10-13 13:45   
Needs changelog.
(0020094)
Zalewa   
2018-10-13 14:16   
Changelog updated:'https://bitbucket.org/Doomseeker/doomseeker/commits/d8e7f2b27981ebfb13e41c5b93857216514a0e00 [^]'
(0020098)
WubTheCaptain   
2018-10-13 16:04   
I guess EP_CanonicalName will be automatically documented, though I wonder if that needs a mention in the changelog.
(0020099)
Zalewa   
2018-10-13 16:16   
Quote from WubTheCaptain
I guess EP_CanonicalName will be automatically documented, though I wonder if that needs a mention in the changelog.

We haven't been including plugin API changes in the changelog so far. There are some mentions of the changes in Wadseeker's API, however. Keeping a changelog on the API could be reconsidered, but I don't know if mixing the plugin API changes with end-user changes is a good idea. End-user normally doesn't care about the internal API. Further considerations in this regard are more fitting to 0003517.
(0020110)
WubTheCaptain   
2018-10-13 18:08   
I remember seeing this issue few days ago before Zalewa reported it, but never got to test it.

Anyway, should be good now:

[18:06:56] Loading translations definitions
[18:06:56] Reading localizations definitions file: translations.def
[18:06:56] Loading translation "es_ES".
[18:06:56] Found translation 'qtbase_es_ES' in dir '/usr/share/qt5/translations'.
[18:06:56] Found translation 'qtmultimedia_es_ES' in dir '/usr/share/qt5/translations'.
[18:06:56] Found translation 'es_ES' in dir '/tmp/doomseeker/translations'.
[18:06:56] Found translation 'odamex_es_ES' in dir '/tmp/doomseeker/translations'.
[18:06:56] Loaded translation for plugin odamex
[18:06:56] Found translation 'srb2_es_ES' in dir '/tmp/doomseeker/translations'.
[18:06:56] Loaded translation for plugin srb2
[18:06:56] Found translation 'turok2ex_es_ES' in dir '/tmp/doomseeker/translations'.
[18:06:56] Loaded translation for plugin turok2ex
[18:06:56] Found translation 'zandronum_es_ES' in dir '/tmp/doomseeker/translations'.
[18:06:56] Loaded translation for plugin zandronum
[18:06:56] Traducción cargada.