|Anonymous | Login | Signup for a new account||2019-06-26 20:56 UTC|
|My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0003534||Doomseeker||[All Projects] Bug||public||2018-10-06 09:23||2018-10-13 16:54|
|Target Version||1.2||Fixed in Version||1.2|
|Summary||0003534: Qt4's assumption of Latin-1 encoding decodes UTF-8 characters in Doomseeker built with Qt4 incorrectly (language configuration)|
|Description||"Español" gets garbled into "EspanÃ±ol" (or similar) in configuration, because of UTF-8 characters not being expected in Doomseeker built with Qt4. Support for UTF-8 characters would need to be explicitly added in Qt4.|
See attached screenshot.
|Steps To Reproduce||Grab a "recent" source of Doomseeker 1.2~beta from Mercurial tip (where development happens), with Spanish translation built-in.|
To build Doomseeker with Qt4, do:
cmake -DFORCE_QT4=YES $DOOMSEEKER_SRC make -j$(nproc) # or just make -j4 for example, there's no nproc(1) on OpenBSD
where $DOOMSEEKER_SRC is the location of source code.
Launch Doomseeker and navigate to:
|Additional Information||Not reproducible in Qt5, because Qt5 expects UTF-8 and UTF-8 only.|
|Attached Files|| 2018-10-06-091643_534x118_scrot.png [^] (13,922 bytes) 2018-10-06 09:23
edited on: 2018-10-06 18:49
QString contains a constructor that allows to implicitly convert to its type a QByteArray, which in this case is provided from QIODevice::readLine(). The reason why this "works" "properly" in Qt5 and doesn't in Qt4 becomes apparent when you compare the documentation for this constructor for both versions of Qt and notice that in Qt4 it uses "fromAscii()" to convert to string type and in Qt5 it uses "fromUtf8()".
An explicit call to QString::fromUtf8() should fix the problem:https://bitbucket.org/Doomseeker/doomseeker/commits/657feabd0feb968f3ac330ac9009921c8dab3608 [^]
|Zalewa's patch works with both Debian GNU/Linux and OpenBSD built with Qt4.|
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
|Supporters:||No one explicitly supports this issue yet.|
|2018-10-06 09:23||WubTheCaptain||New Issue|
|2018-10-06 09:23||WubTheCaptain||Status||new => assigned|
|2018-10-06 09:23||WubTheCaptain||Assigned To||=> Zalewa|
|2018-10-06 09:23||WubTheCaptain||File Added: 2018-10-06-091643_534x118_scrot.png|
|2018-10-06 09:24||WubTheCaptain||Relationship added||related to 0003503|
|2018-10-06 09:25||WubTheCaptain||Description Updated||View Revisions|
|2018-10-06 09:25||WubTheCaptain||Additional Information Updated||View Revisions|
|2018-10-06 09:27||WubTheCaptain||Relationship added||child of 0003486|
|2018-10-06 18:48||Zalewa||Note Added: 0019961|
|2018-10-06 18:48||Zalewa||Status||assigned => needs testing|
|2018-10-06 18:49||Zalewa||Note Edited: 0019961||View Revisions|
|2018-10-06 19:02||WubTheCaptain||Note Added: 0019962|
|2018-10-06 19:02||WubTheCaptain||Status||needs testing => resolved|
|2018-10-06 19:02||WubTheCaptain||Fixed in Version||=> 1.2|
|2018-10-06 19:02||WubTheCaptain||Resolution||open => fixed|
|2018-10-13 16:54||WubTheCaptain||Status||resolved => closed|
Questions or other issues? Contact Us.
|Copyright © 2000 - 2019 MantisBT Team|