|Anonymous | Login | Signup for a new account||2019-08-22 09:28 UTC|
|My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0003518||Doomseeker||[All Projects] Bug||public||2018-09-24 19:29||2018-10-27 22:54|
|Target Version||1.2||Fixed in Version||1.2|
|Summary||0003518: /bin/bash is not portable for running Zandronum testing from Doomseeker; this doesn't work with OpenBSD's base operating system|
|Description||/bin/bash is not POSIX-portable. This means running Zandronum testing binaries requires installing bash as a package, or manually changing Doomseeker's generated #!/bin/bash shell scripts to use a POSIX sh interpreter #!/bin/sh (or equivalent).|
Changing Doomseeker's script generation code from #!/bin/bash to #!/bin/sh should remain compatible with bash and POSIX sh.
|Steps To Reproduce||src/plugins/zandronum/zandronumbinaries.cpp creates the script.|
// Create Unix script file content = "#!/bin/bash\n"; [...]
For this issue to occur in practice:
|Additional Information||Not sure if this is a bug or a suggestion. The suggestion is "Remove /bin/bash dependency from Zandronum testing binary shell scripts", and this is the bug behind it.|
I make assumptions Zandronum can be run on OpenBSD, and bash is not available on the operating system (although it is available as a package to install by the superuser/system administrator on OpenBSD).
OpenBSD uses Korn shell (ksh), which is POSIX sh compatible with additions.
|Attached Files||0001-Use-POSIX-sh-scripts-for-Zandronum-testing-releases.patch [^] (1,157 bytes) 2018-09-29 15:42 [Show Content]|
|This is a trivial change so setting target to 1.2.|
|Patch attached, patch by me, needs testing if merged (not sure if this is all that's required).|
|Reattached patch with an additional commit message paragraph explaining /bin/sh can be symlinked somewhere else, and that's fine too.|
Merged and verified on Linux.
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
|Supporters:||No one explicitly supports this issue yet.|
|Opponents:||No one explicitly opposes this issue yet.|
|2018-09-24 19:29||WubTheCaptain||New Issue|
|2018-09-24 19:32||WubTheCaptain||Description Updated||View Revisions|
|2018-09-24 19:35||WubTheCaptain||Relationship added||child of 0003499|
|2018-09-24 19:36||WubTheCaptain||Relationship replaced||related to 0003499|
|2018-09-24 19:41||Zalewa||Status||new => acknowledged|
|2018-09-24 19:42||WubTheCaptain||Additional Information Updated||View Revisions|
|2018-09-24 19:44||WubTheCaptain||Additional Information Updated||View Revisions|
|2018-09-24 20:13||WubTheCaptain||Severity||minor => tweak|
|2018-09-29 07:11||Blzut3||Note Added: 0019804|
|2018-09-29 07:11||Blzut3||Target Version||=> 1.2|
|2018-09-29 15:30||WubTheCaptain||Assigned To||=> WubTheCaptain|
|2018-09-29 15:30||WubTheCaptain||Status||acknowledged => assigned|
|2018-09-29 15:37||WubTheCaptain||File Added: 0001-Use-POSIX-sh-scripts-for-Zandronum-testing-releases.patch|
|2018-09-29 15:37||WubTheCaptain||Note Added: 0019824|
|2018-09-29 15:37||WubTheCaptain||Status||assigned => needs review|
|2018-09-29 15:42||WubTheCaptain||File Deleted: 0001-Use-POSIX-sh-scripts-for-Zandronum-testing-releases.patch|
|2018-09-29 15:42||WubTheCaptain||File Added: 0001-Use-POSIX-sh-scripts-for-Zandronum-testing-releases.patch|
|2018-09-29 15:43||WubTheCaptain||Note Added: 0019825|
|2018-09-30 07:05||Blzut3||Note Added: 0019837|
|2018-09-30 07:05||Blzut3||Status||needs review => resolved|
|2018-09-30 07:05||Blzut3||Fixed in Version||=> 1.2|
|2018-09-30 07:05||Blzut3||Resolution||open => fixed|
|2018-10-27 22:54||WubTheCaptain||Status||resolved => closed|
Questions or other issues? Contact Us.
|Copyright © 2000 - 2019 MantisBT Team|