0003518: /bin/bash is not portable for running Zandronum testing from Doomseeker; this doesn't work with OpenBSD's base operating system

MantisBT - Doomseeker

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0003518

Doomseeker

[All Projects] Bug

public

2018-09-24 19:29

2018-10-27 22:54

Reporter

WubTheCaptain

Assigned To

WubTheCaptain

Priority

normal

Severity

tweak

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OpenBSD

OS Version

6.4-current

Product Version

1.1

Target Version

1.2

Fixed in Version

1.2

Summary

0003518: /bin/bash is not portable for running Zandronum testing from Doomseeker; this doesn't work with OpenBSD's base operating system

Description

/bin/bash is not POSIX-portable. This means running Zandronum testing binaries requires installing bash as a package, or manually changing Doomseeker's generated #!/bin/bash shell scripts to use a POSIX sh interpreter #!/bin/sh (or equivalent).

Changing Doomseeker's script generation code from #!/bin/bash to #!/bin/sh should remain compatible with bash and POSIX sh.

Steps To Reproduce

src/plugins/zandronum/zandronumbinaries.cpp creates the script.

// Create Unix script file
content  = "#!/bin/bash\n";
[...]

For this issue to occur in practice:

Zandronum engine plugin needs to be loaded in Doomseeker.
In Configuration (F5) → Zandronum, "Testing Releases" needs to be enabled and a valid path (configured correctly).
A server running a testing release of Zandronum must be available in Doomseeker's server browser.
The directory for Zandronum testing releases must be void of the specific Zandronum testing release run on the server, to download the release and (more importantly) generate the shell script to run this testing release from Doomseeker.
The user must not have bash installed in their operating system (in example, from OpenBSD ports).
Joining the Zandronum testing release server fails due to lack of bash dependency, unless /bin/bash is somehow symlinked to /bin/sh or another shell. (It isn't by default, and doesn't make much sense to do so.)

Additional Information

Not sure if this is a bug or a suggestion. The suggestion is "Remove /bin/bash dependency from Zandronum testing binary shell scripts", and this is the bug behind it.

I make assumptions Zandronum can be run on OpenBSD, and bash is not available on the operating system (although it is available as a package to install by the superuser/system administrator on OpenBSD).

OpenBSD uses Korn shell (ksh), which is POSIX sh compatible with additions.

Tags

No tags attached.

Relationships

related to

0003499

assigned

Pol M

Port Doomseeker to OpenBSD

Attached Files

0001-Use-POSIX-sh-scripts-for-Zandronum-testing-releases.patch (1,157) 2018-09-29 15:42
/tracker/file_download.php?file_id=2417&type=bug

Issue History

Date Modified

Username

Field

Change

2018-09-24 19:29