Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003316Zandronum[All Projects] Bugpublic2017-10-28 01:452024-03-12 06:25
ReporterLeonard 
Assigned ToLeonard 
PrioritynormalSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version3.0 
Target Version3.1Fixed in Version3.1 
Summary0003316: Unlagged is off by one tic every time
DescriptionThis affects both ping and tic-based unlagged.
As is explained in issue 0003315, P_PlayerThink is called before any mobj ticks and therefore moves.
However, the recording of players positions is done way after their bodies moved for the specified tic:
UNLAGGED_Tick (which calls UNLAGGED_RecordPlayer) is called in G_Ticker while the player's movements are processed in SERVER_Tick (which is what calls G_Ticker afterwards).
This means that the unlagged positions are recorded one tick too late.
Steps To ReproduceUsing the test wad and the debug commit referenced in 0002859:0018627:
-host a server on MAP01 (no need to enable sv_unlagged_debugactors)
-connect and join 2 clients
-align the clients horizontally
-make sure you test this with client 0 so as to not run into issue 0003315
-make sure to have cl_ticsperupdate on 1 so as to not run into 0003317
-shoot the other client
-if you have no latency to the server, you will hit however if you have at least one tic of latency (you may emulate the ping) you will always miss
-whenever you have at least one tic of latency, you are forced to aim right ahead of the player to land a hit (this may explain 0001705:0008281)
Additional InformationWith the fix, using the steps to reproduce above, your hits will always land both with ping and gametic-based unlagged.
Attached Files

- Relationships
parent of 0002859resolvedLeonard Gametic-based unlagged seemingly goes out of sync often compared to ping-based unlagged 

-  Notes
User avatar (0018634)
Leonard (developer)
2017-10-28 14:42

 PR.
User avatar (0018636)
Torr Samaho (administrator)
2017-10-28 16:47

 Thanks! I added your patch.
User avatar (0023373)
unknownna (updater)
2024-03-12 06:25

 In 3.1 you can now hit the other player compared to before, where you had to aim ahead by quite a bit. This confirms that it's no longer off by 1 tic. Well done.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: DrinkyBird
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2017-10-28 01:45 Leonard New Issue
2017-10-28 01:45 Leonard Status new => assigned
2017-10-28 01:45 Leonard Assigned To => Leonard
2017-10-28 01:56 Leonard Steps to Reproduce Updated View Revisions
2017-10-28 14:42 Leonard Note Added: 0018634
2017-10-28 14:42 Leonard Status assigned => needs review
2017-10-28 16:47 Torr Samaho Note Added: 0018636
2017-10-28 16:47 Torr Samaho Status needs review => needs testing
2017-11-08 01:01 Leonard Relationship added parent of 0002859
2024-03-12 06:25 unknownna Note Added: 0023373
2024-03-12 06:25 unknownna Status needs testing => resolved
2024-03-12 06:25 unknownna Fixed in Version => 3.1
2024-03-12 06:25 unknownna Resolution open => fixed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker