|Anonymous | Login | Signup for a new account||2018-07-18 06:56 UTC|
|My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0003307||Doomseeker||[All Projects] Bug||public||2017-10-22 18:27||2017-11-04 14:30|
|Platform||OS||Debian GNU/Linux||OS Version||buster/sid|
|Target Version||1.2||Fixed in Version||1.2|
|Summary||0003307: Player slots style appearance may change to "marines" in a non-free build after a Doomseeker build without "marines" is executed|
|Description||The user's configuration of player slots style may forcibly change the appearance to "marines", the top (and default?) option if switching between Doomseeker builds.|
It should keep the previous choice of the user, e.g. "blocks" or "numbers" if chosen.
|Steps To Reproduce|
|Additional Information||1.2 hasn't been released yet. Tested with build from commit de91fa3.|
|I was actually aware that going back to the older version will reset the setting to the one that is at index 0 in the combo box. I reused the same setting in doomseeker.ini to avoid bloating the .ini with garbage. In old version this setting stored an int, after the change it stores a string. When you run an old version it will fail to convert the string to a number and return 0 instead. I didn't think this was a serious problem, but if for any reason you think so, I can change the configuration class to save the new setting under a different name. With this, going back to an older version of Doomseeker will restore the setting to the value from before the update, which will be unexpected to the user just the same, so basically this is a tomato-tomahto situation.|
I believe the current behavior is a bug from Debian's policy perspective.
Quote from Debian Policy Manual v18.104.22.168, section 10.7.3. Behavior
Consider packages doomseeker and doomseeker-nonfree, then "upgrading" from the prior to latter.
|Oh yeah, I actually understand what you're talking about now. Close this as won't fix because of configuration file change? Would be good to document this change of behavior somewhere though.|
edited on: 2017-10-22 18:53
Yeah, we'll document it in CHANGELOG.md, which gets updated once for every few commits.
We might want to develop a habit of updating it with all commits, but commits don't directly translate to the changelog.
With all things said and done I could technically implement a backward mapping of strings to indices (so, "marines" -> 0, "blocks" -> 1, "numeric" -> 2) and save it in the configuration under the old name. This would allow to smoothly downgrade Doomseeker.
However, such code is harder to test than it sounds, it's useful in exactly one, rare situation and in result it can break in unexpected ways when software evolves. Weighing in costs & benefits, I'd say this case is too unimportant to spend more time on it.
|If this doesn't reproduce in Doomseeker 1.2 but only Doomseeker 1.1, I'm okay with a note in CHANGELOG.md being enough.|
|Version incompatibility notice added to CHANGELOG.md:https://bitbucket.org/Doomseeker/doomseeker/commits/46c40dfceb726d4b9ff21473cfd2d8826a61b585 [^]|
|Thank you. That should be good.|
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
|Supporters:||No one explicitly supports this issue yet.|
|Opponents:||No one explicitly opposes this issue yet.|
|2017-10-22 18:27||WubTheCaptain||New Issue|
|2017-10-22 18:32||WubTheCaptain||Summary||Player slots style appearance may change to "marines" after a non-free Doomseeker build without "marines" is executed => Player slots style appearance may change to "marines" in a non-free build after a Doomseeker build without "marines" is executed|
|2017-10-22 18:36||Zalewa||Note Added: 0018587|
|2017-10-22 18:37||WubTheCaptain||Description Updated||View Revisions|
|2017-10-22 18:44||WubTheCaptain||Note Added: 0018588|
|2017-10-22 18:44||WubTheCaptain||Status||new => acknowledged|
|2017-10-22 18:46||WubTheCaptain||Status||acknowledged => feedback|
|2017-10-22 18:51||WubTheCaptain||Note Added: 0018589|
|2017-10-22 18:51||WubTheCaptain||Status||feedback => new|
|2017-10-22 18:53||Zalewa||Note Added: 0018590|
|2017-10-22 18:53||Zalewa||Note Edited: 0018590||View Revisions|
|2017-10-22 18:58||Zalewa||Note Added: 0018591|
|2017-10-22 19:19||WubTheCaptain||Note Added: 0018593|
|2017-10-22 19:19||WubTheCaptain||Status||new => feedback|
|2017-10-22 19:37||WubTheCaptain||Target Version||=> 1.2|
|2017-10-22 23:49||WubTheCaptain||Status||feedback => acknowledged|
|2017-11-04 03:11||WubTheCaptain||Note Added: 0018756|
|2017-11-04 03:11||WubTheCaptain||Status||acknowledged => needs review|
|2017-11-04 03:13||WubTheCaptain||Assigned To||=> Zalewa|
|2017-11-04 09:03||Zalewa||Note Added: 0018757|
|2017-11-04 14:30||WubTheCaptain||Note Added: 0018763|
|2017-11-04 14:30||WubTheCaptain||Status||needs review => resolved|
|2017-11-04 14:30||WubTheCaptain||Fixed in Version||=> 1.2|
|2017-11-04 14:30||WubTheCaptain||Resolution||open => fixed|
Questions or other issues? Contact Us.
|Copyright © 2000 - 2018 MantisBT Team|