MantisBT - Doomseeker |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0003307 | Doomseeker | [All Projects] Bug | public | 2017-10-22 18:27 | 2018-10-06 18:19 |
|
| Reporter | WubTheCaptain | |
| Assigned To | Zalewa | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | Debian GNU/Linux | OS Version | buster/sid |
| Product Version | 1.2 | |
| Target Version | 1.2 | Fixed in Version | 1.2 | |
|
| Summary | 0003307: Player slots style appearance may change to "marines" in a non-free build after a Doomseeker build without "marines" is executed |
| Description | The user's configuration of player slots style may forcibly change the appearance to "marines", the top (and default?) option if switching between Doomseeker builds.
It should keep the previous choice of the user, e.g. "blocks" or "numbers" if chosen. |
| Steps To Reproduce |
- Start Doomseeker 1.1 (or Doomseeker 1.2 built with DOOMSEEKER_INSTALL_NONFREE enabled). This build should have the "marines" style available.
- Press the F5 key to open the configuration or find Options → Configuration from the top crate navigation.
- Navigate to "Appearance" settings.
- Under "Player slots style", select any other option but "marines" (e.g. blocks or numbers).
- Hit "Apply" or "OK" to save the settings.
- Exit Doomseeker.
- Start Doomseeker 1.2 built without DOOMSEEKER_INSTALL_NONFREE (no marines).
- Exit Doomseeker.
- Start Doomseeker 1.1 (or Doomseeker 1.2 built with DOOMSEEKER_INSTALL_NONFREE enabled). This build should have the "marines" style available.
- Notice the player slots style has changed to "marines" automatically.
|
| Additional Information | 1.2 hasn't been released yet. Tested with build from commit de91fa3.
- https://bitbucket.org/Doomseeker/doomseeker/commits/bc86aca9433ba2f7bab27ac527220296bb10ec8c
- https://bitbucket.org/Doomseeker/doomseeker/commits/34c18c972380f1c3cf0cb9a9aa78333bce1951b2
|
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2017-10-22 18:27 | WubTheCaptain | New Issue | |
| 2017-10-22 18:32 | WubTheCaptain | Summary | Player slots style appearance may change to "marines" after a non-free Doomseeker build without "marines" is executed => Player slots style appearance may change to "marines" in a non-free build after a Doomseeker build without "marines" is executed |
| 2017-10-22 18:36 | Zalewa | Note Added: 0018587 | |
| 2017-10-22 18:37 | WubTheCaptain | Description Updated | bug_revision_view_page.php?rev_id=11173#r11173 |
| 2017-10-22 18:44 | WubTheCaptain | Note Added: 0018588 | |
| 2017-10-22 18:44 | WubTheCaptain | Status | new => acknowledged |
| 2017-10-22 18:46 | WubTheCaptain | Status | acknowledged => feedback |
| 2017-10-22 18:51 | WubTheCaptain | Note Added: 0018589 | |
| 2017-10-22 18:51 | WubTheCaptain | Status | feedback => new |
| 2017-10-22 18:53 | Zalewa | Note Added: 0018590 | |
| 2017-10-22 18:53 | Zalewa | Note Edited: 0018590 | bug_revision_view_page.php?bugnote_id=18590#r11175 |
| 2017-10-22 18:58 | Zalewa | Note Added: 0018591 | |
| 2017-10-22 19:19 | WubTheCaptain | Note Added: 0018593 | |
| 2017-10-22 19:19 | WubTheCaptain | Status | new => feedback |
| 2017-10-22 19:37 | WubTheCaptain | Target Version | => 1.2 |
| 2017-10-22 23:49 | WubTheCaptain | Status | feedback => acknowledged |
| 2017-11-04 03:11 | WubTheCaptain | Note Added: 0018756 | |
| 2017-11-04 03:11 | WubTheCaptain | Status | acknowledged => needs review |
| 2017-11-04 03:13 | WubTheCaptain | Assigned To | => Zalewa |
| 2017-11-04 09:03 | Zalewa | Note Added: 0018757 | |
| 2017-11-04 14:30 | WubTheCaptain | Note Added: 0018763 | |
| 2017-11-04 14:30 | WubTheCaptain | Status | needs review => resolved |
| 2017-11-04 14:30 | WubTheCaptain | Fixed in Version | => 1.2 |
| 2017-11-04 14:30 | WubTheCaptain | Resolution | open => fixed |
| 2018-10-06 18:19 | WubTheCaptain | Status | resolved => closed |
|
Notes |
|
|
(0018587)
|
|
Zalewa
|
|
2017-10-22 18:36
|
|
|
I was actually aware that going back to the older version will reset the setting to the one that is at index 0 in the combo box. I reused the same setting in doomseeker.ini to avoid bloating the .ini with garbage. In old version this setting stored an int, after the change it stores a string. When you run an old version it will fail to convert the string to a number and return 0 instead. I didn't think this was a serious problem, but if for any reason you think so, I can change the configuration class to save the new setting under a different name. With this, going back to an older version of Doomseeker will restore the setting to the value from before the update, which will be unexpected to the user just the same, so basically this is a tomato-tomahto situation. |
|
|
|
|
I believe the current behavior is a bug from Debian's policy perspective.
Quote from Debian Policy Manual v4.1.1.1, section 10.7.3. Behavior
Configuration file handling must conform to the following behavior:
- local changes must be preserved during a package upgrade, and
- configuration files must be preserved when the package is removed, and only deleted when the package is purged.
Consider packages doomseeker and doomseeker-nonfree, then "upgrading" from the prior to latter. |
|
|
|
|
|
Oh yeah, I actually understand what you're talking about now. Close this as won't fix because of configuration file change? Would be good to document this change of behavior somewhere though. |
|
|
|
(0018590)
|
|
Zalewa
|
|
2017-10-22 18:53
|
|
Quote
Would be good to document this change of behavior somewhere though.
Yeah, we'll document it in CHANGELOG.md, which gets updated once for every few commits.
We might want to develop a habit of updating it with all commits, but commits don't directly translate to the changelog.
|
|
|
|
(0018591)
|
|
Zalewa
|
|
2017-10-22 18:58
|
|
With all things said and done I could technically implement a backward mapping of strings to indices (so, "marines" -> 0, "blocks" -> 1, "numeric" -> 2) and save it in the configuration under the old name. This would allow to smoothly downgrade Doomseeker.
However, such code is harder to test than it sounds, it's useful in exactly one, rare situation and in result it can break in unexpected ways when software evolves. Weighing in costs & benefits, I'd say this case is too unimportant to spend more time on it. |
|
|
|
|
|
If this doesn't reproduce in Doomseeker 1.2 but only Doomseeker 1.1, I'm okay with a note in CHANGELOG.md being enough. |
|
|
|
|
|
|
|
(0018757)
|
|
Zalewa
|
|
2017-11-04 09:03
|
|
|
|
|
|
|
Thank you. That should be good. |
|