Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003295Doomseeker[All Projects] Suggestionpublic2017-10-07 09:402017-10-24 00:42
ReporterWubTheCaptain 
Assigned ToWubTheCaptain 
PrioritynormalSeveritytrivialReproducibilityN/A
StatusclosedResolutiondenied 
PlatformOSOS Version
Product Version1.1 
Target Version1.2Fixed in Version 
Summary0003295: Rename LICENSE files to COPYING
DescriptionCurrently, Doomseeker has license text in files named LICENSE and LICENSE.json.

It's a GNU release convention to have the license texts in a file called COPYING. Sometimes you also find the LGPL text in a file called COPYING.LESSER.

I propose Doomseeker to adopt GNU's terminology for the files to possibly satisfy both worlds/release practices.
Steps To Reproduce
$ mv LICENSE COPYING
$ mv LICENSE.json COPYING.json
$ # Commit to Mercurial, done.
Additional Informationhttps://www.gnu.org/prep/standards/standards.html#Releases [^]
Attached Filespatch file icon 0001-rename-license-files-to-copying.patch [^] (58,187 bytes) 2017-10-22 21:25 [Show Content]

- Relationships
related to 0003247assignedWubTheCaptain Doomseeker's manual page (mdoc/nroff) is missing or incomplete 
related to 0003237assignedZalewa Non-free files and copyright issues in source archive 
related to 0003308closedWubTheCaptain Include a copy of the GNU GPL license, regardless of release under the GNU LGPL 
related to 0003309feedbackWubTheCaptain FixedFtpReply and FixedNetworkAccessManager have missing license files 

-  Notes
User avatar (0018457)
WubTheCaptain (developer)
2017-10-07 09:41

I've tagged this to target version 1.2 because I'd like to know which convention to follow with the manual pages and copyright notice.
User avatar (0018462)
Zalewa (developer)
2017-10-07 10:46

I have no objections.
User avatar (0018599)
WubTheCaptain (developer)
2017-10-22 21:26
edited on: 2017-10-22 21:26

Patch attached. First time using Mercurial.

User avatar (0018600)
WubTheCaptain (developer)
2017-10-22 21:30

I did also notice, tools/updateinstaller/tools/win32-configs/doomseeker-core.js talks about non-existent LICENSE.txt, LICENSE.json.txt and LICENSE.updater.txt files. Huh.
User avatar (0018601)
WubTheCaptain (developer)
2017-10-22 21:33

The following files refer to a file named "LICENSE.LGPL":


  • src/wadseeker/protocols/fixedftpreply.h

  • src/wadseeker/protocols/fixedftpreply.cpp

  • src/wadseeker/protocols/fixednetworkaccessmanager.h

  • src/wadseeker/protocols/fixednetworkaccessmanager.cpp



Do we also need to include a duplicate copy in such file?
User avatar (0018602)
Zalewa (developer)
2017-10-22 21:39

1. I think Mercurial needs to be explicitly told to track file renames:http://hgtip.com/tips/advanced/2009-09-30-detecting-renames-automatically/ [^] . If you don't do this, you'll lose history continuity for the renamed files.

2. The license files are actually being installed by CMakeLists.txt, at least for Windows builds. If you rename them without adjusting CMakeLists.txt, you essentially break 'make install'.

3. There's now interesting incosistency between COPYING.json and COPYING.LESSER. COPYING.LESSER is a standard name for a file containing LGPL license, however COPYING.json file contains a BSD license for the JSON library, which is baked into Doomseeker. Considering that COPYING.LESSER is a standard and COPYING.json follows the same naming pattern, even though it is something that we made up, then one, at a glance, could incorrectly assume that COPYING.json is some kind of a generic "json" license. I might be blowing the problem out of proportions, though.
User avatar (0018603)
Zalewa (developer)
2017-10-22 21:41

Quote
Do we also need to include a duplicate [LICENSE.LGPL] copy in such file?

I think it will be better to adjust the headers instead.
User avatar (0018605)
WubTheCaptain (developer)
2017-10-22 21:49

Quote from Zalewa
I think it will be better to adjust the headers instead.


No can do, under LGPLv2.1 section 1:

Quote from GNU Lesser General Public License, version 2.1
keep intact all the notices that refer to this License and to the absence of any warranty


We can add a notice the file is located somewhere else, however. I will do that.
User avatar (0018611)
WubTheCaptain (developer)
2017-10-22 22:43

Can we remove LICENSE.json from the root? We satisfy the conditions by including the copyright notice in the source file header and in the about dialog of Doomseeker. There's a distinction between "retaining" the copyright notice for source code and "reproducing" the copyright notice, so it should be fine in the about dialog.

If not, what do you propose the LICENSE.json file to be named?
User avatar (0018612)
WubTheCaptain (developer)
2017-10-22 22:51

I should read more and type less. The about dialog isn't the full copyright notice.

Do you still have a proposal for the filename?
User avatar (0018617)
Blzut3 (administrator)
2017-10-23 04:18

Per my comment in 0003308 the COPYING.LESSER convention is an LGPLv3 thing related to LGPLv3 referencing the GPLv3 vs including the full text. Since we're using v2.1 there's nothing that needs to be done there.
User avatar (0018618)
WubTheCaptain (developer)
2017-10-23 13:03

We could've named it lgpl-2.1.txt, but that's out of scope for this ticket's suggestion. I'm thinking the FDL license file (if adopted for manuals) may be called fdl-1.3.txt.

Per Blzut3, closing.
User avatar (0018620)
Blzut3 (administrator)
2017-10-24 00:42

Were all other points in the ticket addressed? I was only referring to LICENSE -> COPYING.LESSER instead of just COPYING.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2017-10-07 09:40 WubTheCaptain New Issue
2017-10-07 09:41 WubTheCaptain Note Added: 0018457
2017-10-07 09:41 WubTheCaptain Relationship added related to 0003247
2017-10-07 10:46 Zalewa Note Added: 0018462
2017-10-22 21:21 WubTheCaptain Relationship added related to 0003308
2017-10-22 21:25 WubTheCaptain File Added: 0001-rename-license-files-to-copying.patch
2017-10-22 21:26 WubTheCaptain Note Added: 0018599
2017-10-22 21:26 WubTheCaptain Assigned To => WubTheCaptain
2017-10-22 21:26 WubTheCaptain Status new => needs review
2017-10-22 21:26 WubTheCaptain Note Edited: 0018599 View Revisions
2017-10-22 21:30 WubTheCaptain Note Added: 0018600
2017-10-22 21:33 WubTheCaptain Note Added: 0018601
2017-10-22 21:34 WubTheCaptain Relationship added related to 0003237
2017-10-22 21:39 Zalewa Note Added: 0018602
2017-10-22 21:41 Zalewa Note Added: 0018603
2017-10-22 21:46 WubTheCaptain Status needs review => assigned
2017-10-22 21:49 WubTheCaptain Note Added: 0018605
2017-10-22 22:10 WubTheCaptain Relationship added related to 0003309
2017-10-22 22:43 WubTheCaptain Note Added: 0018611
2017-10-22 22:43 WubTheCaptain Status assigned => feedback
2017-10-22 22:51 WubTheCaptain Note Added: 0018612
2017-10-22 22:51 WubTheCaptain Status feedback => assigned
2017-10-22 23:47 WubTheCaptain Status assigned => feedback
2017-10-23 04:18 Blzut3 Note Added: 0018617
2017-10-23 13:03 WubTheCaptain Note Added: 0018618
2017-10-23 13:03 WubTheCaptain Status feedback => assigned
2017-10-23 13:03 WubTheCaptain Status assigned => closed
2017-10-23 13:03 WubTheCaptain Resolution open => denied
2017-10-24 00:42 Blzut3 Note Added: 0018620






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker