0000329: Some medal issues

(0003583)
MP2E (reporter)
2012-05-07 10:08

'https://bitbucket.org/MP2E/skulltag/changeset/b27855378823 [^]'

Partially fixed, expect next fix for explosive weapons not giving accuracy/precision soon.

(0003586)
unknownna (updater)
2012-05-07 13:15

I found another bug: You're not awarded Impressive / Most Impressive medals if your target is invulnerable through invulnerabilitysphere or respawn protection.

Quote from unknownna
Accuracy / Precision medals are never given with the rocket launcher / grenade launcher / BFG10K.

Perhaps it's the intended behavior, but since the wiki states that all weapons except the railgun is supposed to award these medals, I included it in the report. How come the railgun doesn't award those medals?

'http://wiki.skulltag.net/Medals [^]'

(0003590)
MP2E (reporter)
2012-05-08 00:05

Railgun gives you the "Impressive!" and "Most Impressive!" medals, and Accuracy is actually one hit above that. Seeing as it's more difficult to hit someone with a railgun consecutively they put it in it's own consecutive hit "tier" so to speak.

Rockets, grenades, and BFG10K shots are definitely supposed to give you accuracy medals from a few references I've seen in the code, I'm not sure where it's breaking yet.

(0003596)
unknownna (updater)
2012-05-08 03:29
edited on: 2012-05-08 03:29

Quote from Wiki

Perfect

Defeating your opponent in a duel without being fragged once [...]

The medal is awarded if your opponent has zero/negative frags regardless of whether you've died or not. Should I create a new ticket for this?

BTW: Can somebody put MP2E into the developer group on the tracker?

(0003611)
MP2E (reporter)
2012-05-10 08:43

'https://bitbucket.org/MP2E/skulltag/changeset/21324ce1342b [^]'
'https://bitbucket.org/MP2E/skulltag/changeset/cb3e91360e1a [^]'

Second commit just amends the first, fixes Impressive and Most Impressive not showing up when shooting invulnerable players. Also I'd say don't create a new ticket at this point since it's entitled "Some medal issues" and I'm going to address them anyway.

The RL/BFG10K/GL Accuracy bug is still stumping me at the moment I'd expect a bugfix for the Perfect medal first

(0003612)
MP2E (reporter)
2012-05-10 10:49
edited on: 2012-05-10 11:34

'https://bitbucket.org/MP2E/skulltag/changeset/8a845fc5b084 [^]'

Fixes Perfection medal, now only awards medal when the losing player correctly did not get any frags throughout the match.

Whew! One more commit(or 2, :P) and this should be fixed.

EDIT: Simplified
'https://bitbucket.org/MP2E/skulltag/changeset/9d4f2da2c367 [^]'

(0003613)
MP2E (reporter)
2012-05-10 12:25

'https://bitbucket.org/MP2E/skulltag/changeset/eb6897266073 [^]'

Accuracy and precision now work as intended, and I updated Skulltag Version History.txt to reflect my changes. All of the changesets are in the bug_329 branch, it may be easier to pull that branch and merge at this point(after review of course :P).

This bug is considered closed by me unless any problems with the revisions are found.

(0003614)
unknownna (updater)
2012-05-10 18:03

Regarding the perfect medal: According to the wiki, you're supposed to be awarded the perfect medal in LMS if you don't lose any health before winning a round. But if you have your handicap set to a value higher than 0, you're awarded the victory medal instead.

And even if you lose health and are supposed to be awarded the victory medal, you can still earn the perfect medal if you somehow manage to pick up some health, e.g., a soulsphere that isn't spawned by the map.

(0003615)
legion (reporter)
2012-05-12 02:38

Earning a medal in ctf while carrying the flag will obscure the flag from view if medals are on.

Since this said "medal issues" I thought I might as well throw this out there.

(0003621)
MP2E (reporter)
2012-05-14 02:13

This last perfect medal bug is tricky, I found the bug quickly but I'm not exactly sure what the best method of fixing it is as the server doesn't seem to store any knowledge of the player being damaged in the past or not. Not sure where this should go to avoid cluttering up the code more. I'll post something as soon as I come up with a good fix, though.

Hmm from the quick glance I gave the medal drawing code it looks like carrier icons(aka flag carrier) should not be obscured, I'll look into it.

(0003623)
Torr Samaho (administrator)
2012-05-14 17:24

>'https://bitbucket.org/MP2E/skulltag/changeset/eb6897266073 [^]' [^]

> Accuracy and precision now work as intended,

This fix didn't work as intended. A single explosion could increase ulConsecutiveHits multiple times and missing with an explosion didn't reset ulConsecutiveHits. I adapted the fix to fix this issues and added it. Couldn't pull since I would have to pull all the fixes at once and the fix I used actually reverts your fix and puts the code you added at a different position. I'm still planning to move to pulling instead of manually porting the fixes though. We'll just need to discuss the details on how fixes should be prepared so that I can pull them.

> BTW: Can somebody put MP2E into the developer group on the tracker?

Done :).

(0003624)
Torr Samaho (administrator)
2012-05-14 17:27

>'https://bitbucket.org/MP2E/skulltag/changeset/21324ce1342b [^]'

You are changing ZDoom code here. Is this intended? If so, should this code also be changed in ZDoom?

(0003626)
Torr Samaho (administrator)
2012-05-14 19:24

>'https://bitbucket.org/MP2E/skulltag/changeset/9d4f2da2c367 [^]'

I think the logic here does not take into account effects that can kill a player that don't award (or subtract) a frag to anybody. For instance if a monsters kills a player, this check doesn't work.

(0003628)
MP2E (reporter)
2012-05-14 19:32
edited on: 2012-05-14 19:42

Thanks, I actually wondered if ulConsecutiveHits would break in some way but in the testing I did(admittedly only with the railgun) it worked.

2nd commit: That was on accident. It was part of a debugging function I thought I'd deleted all of. Deleted in the commit after it.

3rd commit: Very true, I don't think we have to worry about monsters in duels but perhaps any ACS scripts affecting deaths without affecting frags could break this logic. I'm going to have to rethink this..

(0003631)
Torr Samaho (administrator)
2012-05-14 19:54
edited on: 2012-05-14 19:55

Quote from MP2E
2nd commit: That was on accident. It was part of a debugging function I thought I'd deleted all of. Deleted in the commit after it.

You removed the ZDoom code block

// Invulnerable things completely block the shot
    if (res.Actor->flags2 & MF2_INVULNERABLE)
    {
        return false;
    }

and as far as I can see you didn't add it again.

(0003632)
MP2E (reporter)
2012-05-14 19:57

Ah reason being was that it was blocking the handled logic in Skulltag to deal with invulnerable players. P_RailAttack was never called in the instance of shooting an invulnerable player otherwise.

(0003633)
Torr Samaho (administrator)
2012-05-14 20:04

I didn't check this in detail, but I guess if you remove it, you change the behavior of the rail. The comment in the removed block seems to say that the rail stops at an invulnerable target, i.e. anything behind an invulnerable target is not hit.

(0003638)
MP2E (reporter)
2012-05-16 02:31

I'm going to create a new branch and look through these changes a lot more carefully :P

(0003699)
Torr Samaho (administrator)
2012-06-09 12:46

>https://bitbucket.org/MP2E/skulltag/changeset/b27855378823

Note: When you introduce new members in player_t, you have to properly initialize, reset and copy them (see the implementation of the other members).

For this fix no new member in player_t was necessary though. When reviewing your patch I had a slightly different and since I didn't hear from you about this for a while, I went ahead and implemented a different fix:'https://bitbucket.org/Torr_Samaho/zandronum/changeset/5167b204d18d [^]'

(0003751)
MP2E (reporter)
2012-06-13 02:29

That works much better than my fix, sorry for the lateness of any responses and the lack of activity. I am currently in-between homes(moving) and in-between careers. I'll make it a priority to polish off the rest of these bugs soon

(0005194)
unknownna (updater)
2012-10-24 22:40
edited on: 2012-10-24 22:41

I'm not too sure if rocket explosions should award you accuracy and precision medals. BFG rays don't award you medals. And I noticed that you're not awarded medals with rocket/grenade/plasma/BFG shots when you have a spread rune unless all the 3 projectiles hit the player. And you're never awarded medals with the BFG10K.

Only registered users can voice their support. Click here to register, or here to log in.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Notes
(0003583) MP2E (reporter) 2012-05-07 10:08	'https://bitbucket.org/MP2E/skulltag/changeset/b27855378823 [^]' Partially fixed, expect next fix for explosive weapons not giving accuracy/precision soon.

(0003586) unknownna (updater) 2012-05-07 13:15	I found another bug: You're not awarded Impressive / Most Impressive medals if your target is invulnerable through invulnerabilitysphere or respawn protection. Quote from unknownna Accuracy / Precision medals are never given with the rocket launcher / grenade launcher / BFG10K. Perhaps it's the intended behavior, but since the wiki states that all weapons except the railgun is supposed to award these medals, I included it in the report. How come the railgun doesn't award those medals? 'http://wiki.skulltag.net/Medals [^]'

(0003590) MP2E (reporter) 2012-05-08 00:05	Railgun gives you the "Impressive!" and "Most Impressive!" medals, and Accuracy is actually one hit above that. Seeing as it's more difficult to hit someone with a railgun consecutively they put it in it's own consecutive hit "tier" so to speak. Rockets, grenades, and BFG10K shots are definitely supposed to give you accuracy medals from a few references I've seen in the code, I'm not sure where it's breaking yet.

(0003596) unknownna (updater) 2012-05-08 03:29 edited on: 2012-05-08 03:29	Quote from Wiki Perfect Defeating your opponent in a duel without being fragged once [...] The medal is awarded if your opponent has zero/negative frags regardless of whether you've died or not. Should I create a new ticket for this? BTW: Can somebody put MP2E into the developer group on the tracker?

(0003611) MP2E (reporter) 2012-05-10 08:43	'https://bitbucket.org/MP2E/skulltag/changeset/21324ce1342b [^]' 'https://bitbucket.org/MP2E/skulltag/changeset/cb3e91360e1a [^]' Second commit just amends the first, fixes Impressive and Most Impressive not showing up when shooting invulnerable players. Also I'd say don't create a new ticket at this point since it's entitled "Some medal issues" and I'm going to address them anyway. The RL/BFG10K/GL Accuracy bug is still stumping me at the moment I'd expect a bugfix for the Perfect medal first

(0003612) MP2E (reporter) 2012-05-10 10:49 edited on: 2012-05-10 11:34	'https://bitbucket.org/MP2E/skulltag/changeset/8a845fc5b084 [^]' Fixes Perfection medal, now only awards medal when the losing player correctly did not get any frags throughout the match. Whew! One more commit(or 2, :P) and this should be fixed. EDIT: Simplified 'https://bitbucket.org/MP2E/skulltag/changeset/9d4f2da2c367 [^]'

(0003613) MP2E (reporter) 2012-05-10 12:25	'https://bitbucket.org/MP2E/skulltag/changeset/eb6897266073 [^]' Accuracy and precision now work as intended, and I updated Skulltag Version History.txt to reflect my changes. All of the changesets are in the bug_329 branch, it may be easier to pull that branch and merge at this point(after review of course :P). This bug is considered closed by me unless any problems with the revisions are found.

(0003614) unknownna (updater) 2012-05-10 18:03	Regarding the perfect medal: According to the wiki, you're supposed to be awarded the perfect medal in LMS if you don't lose any health before winning a round. But if you have your handicap set to a value higher than 0, you're awarded the victory medal instead. And even if you lose health and are supposed to be awarded the victory medal, you can still earn the perfect medal if you somehow manage to pick up some health, e.g., a soulsphere that isn't spawned by the map.

(0003615) legion (reporter) 2012-05-12 02:38	Earning a medal in ctf while carrying the flag will obscure the flag from view if medals are on. Since this said "medal issues" I thought I might as well throw this out there.

(0003621) MP2E (reporter) 2012-05-14 02:13	This last perfect medal bug is tricky, I found the bug quickly but I'm not exactly sure what the best method of fixing it is as the server doesn't seem to store any knowledge of the player being damaged in the past or not. Not sure where this should go to avoid cluttering up the code more. I'll post something as soon as I come up with a good fix, though. Hmm from the quick glance I gave the medal drawing code it looks like carrier icons(aka flag carrier) should not be obscured, I'll look into it.

(0003623) Torr Samaho (administrator) 2012-05-14 17:24	>'https://bitbucket.org/MP2E/skulltag/changeset/eb6897266073 [^]' [^] > Accuracy and precision now work as intended, This fix didn't work as intended. A single explosion could increase ulConsecutiveHits multiple times and missing with an explosion didn't reset ulConsecutiveHits. I adapted the fix to fix this issues and added it. Couldn't pull since I would have to pull all the fixes at once and the fix I used actually reverts your fix and puts the code you added at a different position. I'm still planning to move to pulling instead of manually porting the fixes though. We'll just need to discuss the details on how fixes should be prepared so that I can pull them. > BTW: Can somebody put MP2E into the developer group on the tracker? Done :).

(0003624) Torr Samaho (administrator) 2012-05-14 17:27	>'https://bitbucket.org/MP2E/skulltag/changeset/21324ce1342b [^]' You are changing ZDoom code here. Is this intended? If so, should this code also be changed in ZDoom?

(0003626) Torr Samaho (administrator) 2012-05-14 19:24	>'https://bitbucket.org/MP2E/skulltag/changeset/9d4f2da2c367 [^]' I think the logic here does not take into account effects that can kill a player that don't award (or subtract) a frag to anybody. For instance if a monsters kills a player, this check doesn't work.

(0003628) MP2E (reporter) 2012-05-14 19:32 edited on: 2012-05-14 19:42	Thanks, I actually wondered if ulConsecutiveHits would break in some way but in the testing I did(admittedly only with the railgun) it worked. 2nd commit: That was on accident. It was part of a debugging function I thought I'd deleted all of. Deleted in the commit after it. 3rd commit: Very true, I don't think we have to worry about monsters in duels but perhaps any ACS scripts affecting deaths without affecting frags could break this logic. I'm going to have to rethink this..

(0003631) Torr Samaho (administrator) 2012-05-14 19:54 edited on: 2012-05-14 19:55	Quote from MP2E 2nd commit: That was on accident. It was part of a debugging function I thought I'd deleted all of. Deleted in the commit after it. You removed the ZDoom code block // Invulnerable things completely block the shot if (res.Actor->flags2 & MF2_INVULNERABLE) { return false; } and as far as I can see you didn't add it again.

(0003632) MP2E (reporter) 2012-05-14 19:57	Ah reason being was that it was blocking the handled logic in Skulltag to deal with invulnerable players. P_RailAttack was never called in the instance of shooting an invulnerable player otherwise.

(0003633) Torr Samaho (administrator) 2012-05-14 20:04	I didn't check this in detail, but I guess if you remove it, you change the behavior of the rail. The comment in the removed block seems to say that the rail stops at an invulnerable target, i.e. anything behind an invulnerable target is not hit.

(0003638) MP2E (reporter) 2012-05-16 02:31	I'm going to create a new branch and look through these changes a lot more carefully :P

(0003699) Torr Samaho (administrator) 2012-06-09 12:46	>https://bitbucket.org/MP2E/skulltag/changeset/b27855378823 Note: When you introduce new members in player_t, you have to properly initialize, reset and copy them (see the implementation of the other members). For this fix no new member in player_t was necessary though. When reviewing your patch I had a slightly different and since I didn't hear from you about this for a while, I went ahead and implemented a different fix:'https://bitbucket.org/Torr_Samaho/zandronum/changeset/5167b204d18d [^]'

(0003751) MP2E (reporter) 2012-06-13 02:29	That works much better than my fix, sorry for the lateness of any responses and the lack of activity. I am currently in-between homes(moving) and in-between careers. I'll make it a priority to polish off the rest of these bugs soon

(0005194) unknownna (updater) 2012-10-24 22:40 edited on: 2012-10-24 22:41	I'm not too sure if rocket explosions should award you accuracy and precision medals. BFG rays don't award you medals. And I noticed that you're not awarded medals with rocket/grenade/plasma/BFG shots when you have a spread rune unless all the 3 projectiles hit the player. And you're never awarded medals with the BFG10K.

Issue History
Date Modified	Username	Field	Change
2011-03-16 22:54	unknownna	New Issue
2011-03-26 03:01	unknownna	Relationship added	related to 0000348
2011-04-30 05:37	unknownna	Relationship added	related to 0000419
2012-05-01 12:09	unknownna	Relationship added	related to 0000825
2012-05-07 10:08	MP2E	Note Added: 0003583
2012-05-07 13:15	unknownna	Note Added: 0003586
2012-05-07 13:15	unknownna	Status	new => assigned
2012-05-08 00:05	MP2E	Note Added: 0003590
2012-05-08 03:29	unknownna	Note Added: 0003596
2012-05-08 03:29	unknownna	Note Edited: 0003596	View Revisions
2012-05-08 03:29	unknownna	Note Edited: 0003596	View Revisions
2012-05-10 08:43	MP2E	Note Added: 0003611
2012-05-10 10:49	MP2E	Note Added: 0003612
2012-05-10 11:34	MP2E	Note Edited: 0003612	View Revisions
2012-05-10 11:34	MP2E	Note Edited: 0003612	View Revisions
2012-05-10 12:25	MP2E	Note Added: 0003613
2012-05-10 17:46	unknownna	Status	assigned => needs review
2012-05-10 18:03	unknownna	Note Added: 0003614
2012-05-12 02:38	legion	Note Added: 0003615
2012-05-14 02:13	MP2E	Note Added: 0003621
2012-05-14 17:24	Torr Samaho	Note Added: 0003623
2012-05-14 17:27	Torr Samaho	Note Added: 0003624
2012-05-14 19:24	Torr Samaho	Note Added: 0003626
2012-05-14 19:32	MP2E	Note Added: 0003628
2012-05-14 19:42	MP2E	Note Edited: 0003628	View Revisions
2012-05-14 19:54	Torr Samaho	Note Added: 0003631
2012-05-14 19:55	Torr Samaho	Note Edited: 0003631
2012-05-14 19:55	Torr Samaho	Note Edited: 0003631	View Revisions
2012-05-14 19:55	Torr Samaho	Note Revision Dropped: 3631: 0001988
2012-05-14 19:55	Torr Samaho	Note Revision Dropped: 3631: 0001989
2012-05-14 19:57	MP2E	Note Added: 0003632
2012-05-14 20:04	Torr Samaho	Note Added: 0003633
2012-05-14 21:06	Dusk	Assigned To	=> MP2E
2012-05-16 02:31	MP2E	Note Added: 0003638
2012-06-09 12:46	Torr Samaho	Note Added: 0003699
2012-06-09 12:47	Torr Samaho	Status	needs review => feedback
2012-06-09 13:22	Torr Samaho	Category	General => Bug
2012-06-13 02:29	MP2E	Note Added: 0003751
2012-10-24 22:40	unknownna	Note Added: 0005194
2012-10-24 22:40	unknownna	Status	feedback => assigned
2012-10-24 22:41	unknownna	Note Edited: 0005194	View Revisions