Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003164Zandronum[All Projects] Bugpublic2017-06-22 19:082018-09-30 21:43
ReporterKorshun 
Assigned ToDusk 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0003164: Noclipping spectators stop being noclip when another client connects
DescriptionIf a spectator is using noclip or noclip2 and a different client connects to the server, the spectator loses noclip.

This bug is not present in 2.1.2.
Steps To Reproduce1. run a real server
2. connect
3. "noclip" or "noclip2"
4. connect with a second instance of Zandronum
5. observe the first spectator is not noclip
Additional InformationCredits to TheMisterCat for discovering this bug.
Attached Filesdiff file icon 3164-fix.diff [^] (502 bytes) 2017-06-23 08:37 [Show Content]

- Relationships

-  Notes
User avatar (0017876)
Fused (reporter)
2017-06-22 19:13

Had this happen very often in WDI today. Although I'm not too sure if a client connected every time.
User avatar (0017883)
Dusk (developer)
2017-06-23 08:38
edited on: 2017-06-23 08:39

I attached a diff that seems to fix this on my end. Of course it's only a band-aid and we need to find out by bisecting what the real cause is. Will we do that for 3.0 I don't know.

However, I think the diff should be applied in any case because spectator noclip is clientside and shouldn't be affected by the server.

User avatar (0017888)
Ru5tK1ng (updater)
2017-06-23 15:29
edited on: 2017-06-23 16:10

The noclip bug occurred between the r150809 and r150819. I'm going to say it's most likely this commit: 'https://bitbucket.org/Torr_Samaho/zandronum/commits/017795c4cc45f5125b506288870a9e99ad5eded8 [^]'

Edit: this also involved changes to spectators as well: 'https://bitbucket.org/Torr_Samaho/zandronum/commits/381f296c9c7c043959b95d032881dae71a64114c [^]'

User avatar (0017909)
Torr Samaho (administrator)
2017-06-25 13:49

Dusk, the attached patch looks fine to me. Can somebody test it briefly?
User avatar (0017919)
Ru5tK1ng (updater)
2017-06-25 16:49

I couldn't reproduce the bug with that patch.
User avatar (0017926)
Torr Samaho (administrator)
2017-06-25 19:41

I pulled Dusk's patch.
User avatar (0017948)
Ru5tK1ng (updater)
2017-06-28 01:53

Seems to working fine on TSPG.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: Korshun Fused
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2017-06-22 19:08 Korshun New Issue
2017-06-22 19:13 Fused Note Added: 0017876
2017-06-22 19:48 Dusk Assigned To => Dusk
2017-06-22 19:48 Dusk Status new => confirmed
2017-06-22 19:48 Dusk Priority normal => high
2017-06-22 19:48 Dusk Target Version => 3.0
2017-06-22 21:26 fr-blood Note Added: 0017877
2017-06-22 21:27 fr-blood Note Deleted: 0017877
2017-06-23 08:37 Dusk File Added: 3164-fix.diff
2017-06-23 08:38 Dusk Note Added: 0017883
2017-06-23 08:39 Dusk Note Edited: 0017883 View Revisions
2017-06-23 08:40 Dusk Status confirmed => needs review
2017-06-23 15:29 Ru5tK1ng Note Added: 0017888
2017-06-23 15:34 Ru5tK1ng Note Edited: 0017888 View Revisions
2017-06-23 16:10 Ru5tK1ng Note Edited: 0017888 View Revisions
2017-06-25 13:49 Torr Samaho Note Added: 0017909
2017-06-25 13:49 Torr Samaho Status needs review => feedback
2017-06-25 16:49 Ru5tK1ng Note Added: 0017919
2017-06-25 19:41 Torr Samaho Note Added: 0017926
2017-06-25 19:42 Torr Samaho Status feedback => needs testing
2017-06-28 01:53 Ru5tK1ng Note Added: 0017948
2017-06-28 01:53 Ru5tK1ng Status needs testing => resolved
2017-06-28 01:53 Ru5tK1ng Resolution open => fixed
2017-06-28 01:53 Ru5tK1ng Fixed in Version => 3.0
2018-09-30 21:43 Blzut3 Status resolved => closed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker