MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003164Zandronum[All Projects] Bugpublic2017-06-22 19:082018-09-30 21:43
ReporterKorshun 
Assigned ToDusk 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0003164: Noclipping spectators stop being noclip when another client connects
DescriptionIf a spectator is using noclip or noclip2 and a different client connects to the server, the spectator loses noclip.

This bug is not present in 2.1.2.
Steps To Reproduce1. run a real server
2. connect
3. "noclip" or "noclip2"
4. connect with a second instance of Zandronum
5. observe the first spectator is not noclip
Additional InformationCredits to TheMisterCat for discovering this bug.
TagsNo tags attached.
Relationships
Attached Filesdiff 3164-fix.diff (502) 2017-06-23 08:37
/tracker/file_download.php?file_id=2131&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-06-22 19:08KorshunNew Issue
2017-06-22 19:13FusedNote Added: 0017876
2017-06-22 19:48DuskAssigned To => Dusk
2017-06-22 19:48DuskStatusnew => confirmed
2017-06-22 19:48DuskPrioritynormal => high
2017-06-22 19:48DuskTarget Version => 3.0
2017-06-22 21:26fr-bloodNote Added: 0017877
2017-06-22 21:27fr-bloodNote Deleted: 0017877
2017-06-23 08:37DuskFile Added: 3164-fix.diff
2017-06-23 08:38DuskNote Added: 0017883
2017-06-23 08:39DuskNote Edited: 0017883bug_revision_view_page.php?bugnote_id=17883#r10730
2017-06-23 08:40DuskStatusconfirmed => needs review
2017-06-23 15:29Ru5tK1ngNote Added: 0017888
2017-06-23 15:34Ru5tK1ngNote Edited: 0017888bug_revision_view_page.php?bugnote_id=17888#r10732
2017-06-23 16:10Ru5tK1ngNote Edited: 0017888bug_revision_view_page.php?bugnote_id=17888#r10733
2017-06-25 13:49Torr SamahoNote Added: 0017909
2017-06-25 13:49Torr SamahoStatusneeds review => feedback
2017-06-25 16:49Ru5tK1ngNote Added: 0017919
2017-06-25 19:41Torr SamahoNote Added: 0017926
2017-06-25 19:42Torr SamahoStatusfeedback => needs testing
2017-06-28 01:53Ru5tK1ngNote Added: 0017948
2017-06-28 01:53Ru5tK1ngStatusneeds testing => resolved
2017-06-28 01:53Ru5tK1ngResolutionopen => fixed
2017-06-28 01:53Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:43Blzut3Statusresolved => closed

Notes
(0017876)
Fused   
2017-06-22 19:13   
Had this happen very often in WDI today. Although I'm not too sure if a client connected every time.
(0017883)
Dusk   
2017-06-23 08:38   
(edited on: 2017-06-23 08:39)
I attached a diff that seems to fix this on my end. Of course it's only a band-aid and we need to find out by bisecting what the real cause is. Will we do that for 3.0 I don't know.

However, I think the diff should be applied in any case because spectator noclip is clientside and shouldn't be affected by the server.
(0017888)
Ru5tK1ng   
2017-06-23 15:29   
(edited on: 2017-06-23 16:10)
The noclip bug occurred between the r150809 and r150819. I'm going to say it's most likely this commit: 'https://bitbucket.org/Torr_Samaho/zandronum/commits/017795c4cc45f5125b506288870a9e99ad5eded8 [^]'

Edit: this also involved changes to spectators as well: 'https://bitbucket.org/Torr_Samaho/zandronum/commits/381f296c9c7c043959b95d032881dae71a64114c [^]'
(0017909)
Torr Samaho   
2017-06-25 13:49   
Dusk, the attached patch looks fine to me. Can somebody test it briefly?
(0017919)
Ru5tK1ng   
2017-06-25 16:49   
I couldn't reproduce the bug with that patch.
(0017926)
Torr Samaho   
2017-06-25 19:41   
I pulled Dusk's patch.
(0017948)
Ru5tK1ng   
2017-06-28 01:53   
Seems to working fine on TSPG.