0003050: Actor health above 32767 is incorrectly transmitted to clients and causes weapon sprite desync for players

Chat on our Discord Server Get the latest version: 3.2.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0003050

Zandronum

[All Projects] Bug

public

2017-04-09 13:06

2022-10-14 01:44

Reporter

Korshun

Assigned To

Dusk

Priority

normal

Severity

major

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

Microsoft

Windows

OS Version

XP/Vista/7

Product Version

2.1

Target Version

Fixed in Version

3.1

Summary

0003050: Actor health above 32767 is incorrectly transmitted to clients and causes weapon sprite desync for players

Description

Actor healths are apparently transmitted to clients as 16-bit signed integers, just like tids and inventory item counts were in 2.1.2.

Setting it to a value above 32767 may cause clients to think it's negative and desync weapon sprite while keeping the game playable.

This bug happens in both 2.1.2 and 3.0

Steps To Reproduce

1) load the attached wad which sets player health to 100000
2) note that the client thinks health is negative and breaks weapon sprite

Attached Files

hpdesync.wad [^] (349 bytes) 2017-04-09 13:06

Relationships

Notes
(0020714) Ivan (reporter) 2019-06-03 12:51	Anything planned to be done about this?

(0020718) Dusk (developer) 2019-06-04 18:43	I'll have to take a look into this.

(0021571) Torr Samaho (administrator) 2020-11-29 20:31	I added Kaminski's patch for this.

(0022443) WaTaKiD (updater) 2022-10-14 01:43	'https://hg.osdn.net/view/zandronum/zandronum-stable/rev/4a8b819263ca [^]' was added and ive found the example wad to work fine with quick tests on windows and tspg linux servers marking as resolved

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	Korshun JC Tenton Ivan eagle
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2017-04-09 13:06	Korshun	New Issue
2017-04-09 13:06	Korshun	File Added: hpdesync.wad
2017-04-09 13:55	WaTaKiD	Product Version	3.0-beta => 2.1
2019-06-03 12:51	Ivan	Note Added: 0020714
2019-06-04 18:43	Dusk	Note Added: 0020718
2019-06-04 18:43	Dusk	Assigned To	=> Dusk
2019-06-04 18:43	Dusk	Status	new => acknowledged
2020-11-29 20:31	Torr Samaho	Note Added: 0021571
2020-11-29 20:31	Torr Samaho	Status	acknowledged => needs testing
2022-10-14 01:43	WaTaKiD	Note Added: 0022443
2022-10-14 01:44	WaTaKiD	Status	needs testing => resolved
2022-10-14 01:44	WaTaKiD	Resolution	open => fixed
2022-10-14 01:44	WaTaKiD	Fixed in Version	=> 3.1

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.