Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002920Zandronum[All Projects] Bugpublic2016-11-13 16:112018-09-30 21:51
ReporterHexaDoken 
Assigned ToEdward-san 
PrioritynormalSeveritycrashReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002920: Crash under undetermined exact conditions
Descriptionnot sure what exactly is happening here, but I just got a bunch of crashes out of nowhere

there was a lot of wads loaded, and I did my best to narrow it down to two

'http://allfearthesentinel.net/download?file=tartaru5.wad [^]'
'http://www.mediafire.com/file/cawkug8jxcz73ak/31337guns_131116.wad [^]' - of my own making

I didn't really do much testing because of relative lack of time, but if anybody asks me to do something I'll try my best

crashlog attached
Steps To ReproduceHost server, map TAT06
Shoot the switch in the very front of you until it opens a bunch of rooms to your side, releasing a bunch of imps and a lot of barons
Collect weapons and try to fight back
Eventually the server will completely crash

doesn't seem to be linked to any specific weapon or anything, I'm not 100% sure on this
Attached Fileszip file icon CrashReport.zip [^] (15,611 bytes) 2016-11-13 16:11

- Relationships

-  Notes
User avatar (0016186)
Edward-san (developer)
2016-11-13 17:47
edited on: 2016-11-13 17:49

 Some notes:

1)The DummyPlayer is spawned near the start area where Player 7 spot is present (coordinates -384,-1856);
2)The weapon RapidFireRL spawns missiles called MiniMissile2 which deal 0 damage according to their definition;
3)If an actor is hit by a missile dealing 0 damage, P_GiveBody is called.

So, the crash happens because of the DummyPlayer being hit by a MiniMissile2 fired by a player.
User avatar (0016188)
Edward-san (developer)
2016-11-13 18:23
edited on: 2016-11-13 18:24

 The map is bugged, because real Player 7 spawn spot is swapped with its voodoo doll's spot. You can verify this in multiplayer offline mode by adding 7 bots and check the voodoo doll's spot (-576, 1600).

Still the crash is not good, but I wonder what's a good fix here.
User avatar (0016191)
Edward-san (developer)
2016-11-13 22:16

 'https://bitbucket.org/zandronum/zandronum-sandbox/commits/f3298a56519f9deed44c3ba6c85882f5bdb502a6 [^]'
User avatar (0016194)
Torr Samaho (administrator)
2016-11-14 19:54

 Please separate the new check from the existing checks. DummyPlayer is not a dead thing, so it follows a different logic. In the separate check, you won't need to check "actor->player != NULL" since COOP_GetVoodooDollDummyPlayer never returns NULL.
User avatar (0016195)
Edward-san (developer)
2016-11-14 20:12

 Done:'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/163/fixed-crash-with-the-voodoo-doll-being-hit/diff [^]'
User avatar (0016196)
Torr Samaho (administrator)
2016-11-14 20:33

 Thanks! Added.
User avatar (0016692)
Ru5tK1ng (updater)
2017-01-26 05:29

 Tested with r170122 and I couldn't get the crash to happen even after spamming the RapidFireRL on bots and other players. Seems the fix works without issue.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2016-11-13 16:11 HexaDoken New Issue
2016-11-13 16:11 HexaDoken File Added: CrashReport.zip
2016-11-13 17:06 Edward-san Assigned To => Edward-san
2016-11-13 17:06 Edward-san Status new => assigned
2016-11-13 17:47 Edward-san Note Added: 0016186
2016-11-13 17:49 Edward-san Note Edited: 0016186 View Revisions
2016-11-13 18:23 Edward-san Note Added: 0016188
2016-11-13 18:24 Edward-san Note Edited: 0016188 View Revisions
2016-11-13 22:16 Edward-san Note Added: 0016191
2016-11-13 22:16 Edward-san Status assigned => needs review
2016-11-14 19:54 Torr Samaho Note Added: 0016194
2016-11-14 20:12 Edward-san Note Added: 0016195
2016-11-14 20:33 Torr Samaho Note Added: 0016196
2016-11-14 20:34 Torr Samaho Status needs review => needs testing
2016-12-24 22:42 Dusk Target Version => 3.0
2017-01-26 05:29 Ru5tK1ng Note Added: 0016692
2017-01-26 05:29 Ru5tK1ng Status needs testing => resolved
2017-01-26 05:29 Ru5tK1ng Resolution open => fixed
2017-01-26 05:29 Ru5tK1ng Fixed in Version => 3.0
2018-09-30 21:51 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker