MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002920Zandronum[All Projects] Bugpublic2016-11-13 16:112018-09-30 21:51
ReporterHexaDoken 
Assigned ToEdward-san 
PrioritynormalSeveritycrashReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002920: Crash under undetermined exact conditions
Descriptionnot sure what exactly is happening here, but I just got a bunch of crashes out of nowhere

there was a lot of wads loaded, and I did my best to narrow it down to two

'http://allfearthesentinel.net/download?file=tartaru5.wad [^]'
'http://www.mediafire.com/file/cawkug8jxcz73ak/31337guns_131116.wad [^]' - of my own making

I didn't really do much testing because of relative lack of time, but if anybody asks me to do something I'll try my best

crashlog attached
Steps To ReproduceHost server, map TAT06
Shoot the switch in the very front of you until it opens a bunch of rooms to your side, releasing a bunch of imps and a lot of barons
Collect weapons and try to fight back
Eventually the server will completely crash

doesn't seem to be linked to any specific weapon or anything, I'm not 100% sure on this
Additional Information
TagsNo tags attached.
Relationships
Attached Fileszip CrashReport.zip (15,611) 2016-11-13 16:11
/tracker/file_download.php?file_id=1963&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-11-13 16:11HexaDokenNew Issue
2016-11-13 16:11HexaDokenFile Added: CrashReport.zip
2016-11-13 17:06Edward-sanAssigned To => Edward-san
2016-11-13 17:06Edward-sanStatusnew => assigned
2016-11-13 17:47Edward-sanNote Added: 0016186
2016-11-13 17:49Edward-sanNote Edited: 0016186bug_revision_view_page.php?bugnote_id=16186#r9855
2016-11-13 18:23Edward-sanNote Added: 0016188
2016-11-13 18:24Edward-sanNote Edited: 0016188bug_revision_view_page.php?bugnote_id=16188#r9857
2016-11-13 22:16Edward-sanNote Added: 0016191
2016-11-13 22:16Edward-sanStatusassigned => needs review
2016-11-14 19:54Torr SamahoNote Added: 0016194
2016-11-14 20:12Edward-sanNote Added: 0016195
2016-11-14 20:33Torr SamahoNote Added: 0016196
2016-11-14 20:34Torr SamahoStatusneeds review => needs testing
2016-12-24 22:42DuskTarget Version => 3.0
2017-01-26 05:29Ru5tK1ngNote Added: 0016692
2017-01-26 05:29Ru5tK1ngStatusneeds testing => resolved
2017-01-26 05:29Ru5tK1ngResolutionopen => fixed
2017-01-26 05:29Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:51Blzut3Statusresolved => closed

Notes
(0016186)
Edward-san   
2016-11-13 17:47   
(edited on: 2016-11-13 17:49)
Some notes:

1)The DummyPlayer is spawned near the start area where Player 7 spot is present (coordinates -384,-1856);
2)The weapon RapidFireRL spawns missiles called MiniMissile2 which deal 0 damage according to their definition;
3)If an actor is hit by a missile dealing 0 damage, P_GiveBody is called.

So, the crash happens because of the DummyPlayer being hit by a MiniMissile2 fired by a player.
(0016188)
Edward-san   
2016-11-13 18:23   
(edited on: 2016-11-13 18:24)
The map is bugged, because real Player 7 spawn spot is swapped with its voodoo doll's spot. You can verify this in multiplayer offline mode by adding 7 bots and check the voodoo doll's spot (-576, 1600).

Still the crash is not good, but I wonder what's a good fix here.
(0016191)
Edward-san   
2016-11-13 22:16   
'https://bitbucket.org/zandronum/zandronum-sandbox/commits/f3298a56519f9deed44c3ba6c85882f5bdb502a6 [^]'
(0016194)
Torr Samaho   
2016-11-14 19:54   
Please separate the new check from the existing checks. DummyPlayer is not a dead thing, so it follows a different logic. In the separate check, you won't need to check "actor->player != NULL" since COOP_GetVoodooDollDummyPlayer never returns NULL.
(0016195)
Edward-san   
2016-11-14 20:12   
Done:'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/163/fixed-crash-with-the-voodoo-doll-being-hit/diff [^]'
(0016196)
Torr Samaho   
2016-11-14 20:33   
Thanks! Added.
(0016692)
Ru5tK1ng   
2017-01-26 05:29   
Tested with r170122 and I couldn't get the crash to happen even after spamming the RapidFireRL on bots and other players. Seems the fix works without issue.