0002897: Player_SetTeam causes client to initially select fist rather than pistol with different switchonpickup settings online

Notes
(0016051) Ru5tK1ng (updater) 2016-10-18 20:16	I tried this with 2.1.2 and I never selected the fist when moving over the teleports. I double checked that ctf was true.

(0016055) unknownna (updater) 2016-10-19 08:29	This is caused by switchonpickup 0 (never) and switchonpickup 3 (use PWO) + pwo_switchonsameweight 0. If you have the pistol set higher than the fist with the PWO, the bug won't appear. In any case, the pistol is always brought up first offline regardless of the settings. It turns out that it has actually been broken ever since 1.0, as setting switchonpickup to 0 brings up the fist there as well. It's a regression since it works fine in Skulltag 98d. I think it got broken when we worked on the weapon sync issues way back.

(0023378) Ru5tK1ng (updater) 2024-03-12 20:32 edited on: 2024-03-13 04:40	'https://foss.heptapod.net/zandronum/zandronum-stable/-/blob/branch/default/src/p_interaction.cpp#L2355 [^]' Here's the difference. In single player this block is executed fully which results in no issue with the weapon pickup regardless of PWO settings. However for clients it's different. Because bUnarmed is never true on the clients, they have to wait for the server to send out the inventory which causes them to follow the same code trace as SP. When the server sends a command to reset the inventory followed by syncing the ammo, this is where it sort of falls apart if you don't have the 'right' PWO setting.

(0023379) Ru5tK1ng (updater) 2024-03-13 04:41	@Unknownna can you check this build out and see if anything breaks? 'https://www.mediafire.com/file/1wy05tv4ad7rsxx/zandronum_3.2_r240311-0546M.zip/file [^]' My testing worked out well but another pair of eyes helps for something like this.

(0023383) unknownna (updater) 2024-03-13 14:42	Hey, it seems that it still selects the fist if switchonpickup is 3 (PWO), and the fist and pistol preference have the same value. Offline, it selects the pistol as expected. It fixed the issue for switchonpickup 0 though.

(0023387) Ru5tK1ng (updater) 2024-03-13 20:16	It doesn't seem there is a good way to fix this. Offline is no issue because SP isn't a client and isn't subject to the item syncing. The problem is that the items are given one at a time to the client. To simulate this, do 'take all' then give yourself the fist then pistol and then do the reverse. You'll notice that different PWO settings will switch to the fist.

(0023388) Ru5tK1ng (updater) 2024-03-13 20:49	Try this build out: 'https://www.mediafire.com/file/mfld9obhs2j08gd/zandronum_3.2_r240311-0546M3.zip/file [^]'

(0023392) unknownna (updater) 2024-03-14 06:07	yeah, that seems to have fixed it. It now always selects the pistol as expected. Thanks!

(0023398) Ru5tK1ng (updater) 2024-03-14 16:23	Thanks for testing. Merge request 'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/57 [^]'

(0023486) Ru5tK1ng (updater) 2024-03-24 21:17	This was merged in:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/0913905b803e3332a480987aaf44c12bff08dba7 [^]'

(0023565) Ru5tK1ng (updater) 2024-04-08 23:42	Since this was tested by Unknownna previously, marking as resolved.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2016-10-15 14:38	unknownna	New Issue
2016-10-18 20:16	Ru5tK1ng	Note Added: 0016051
2016-10-18 20:16	Ru5tK1ng	Status	new => feedback
2016-10-19 08:29	unknownna	Note Added: 0016055
2016-10-19 08:29	unknownna	Status	feedback => new
2016-10-19 08:32	unknownna	Steps to Reproduce Updated	View Revisions
2016-10-19 08:32	unknownna	Additional Information Updated	View Revisions
2016-10-19 08:33	unknownna	Summary	Player_SetTeam causes client to initially select fist rather than pistol online => Player_SetTeam causes client to initially select fist rather than pistol with different switchonpickup settings online
2024-03-12 20:32	Ru5tK1ng	Note Added: 0023378
2024-03-12 20:32	Ru5tK1ng	Status	new => confirmed
2024-03-13 04:40	Ru5tK1ng	Note Edited: 0023378	View Revisions
2024-03-13 04:41	Ru5tK1ng	Note Added: 0023379
2024-03-13 04:41	Ru5tK1ng	Assigned To	=> Ru5tK1ng
2024-03-13 04:41	Ru5tK1ng	Status	confirmed => feedback
2024-03-13 14:42	unknownna	Note Added: 0023383
2024-03-13 14:42	unknownna	Status	feedback => assigned
2024-03-13 20:16	Ru5tK1ng	Note Added: 0023387
2024-03-13 20:49	Ru5tK1ng	Note Added: 0023388
2024-03-14 04:48	Ru5tK1ng	Status	assigned => feedback
2024-03-14 06:07	unknownna	Note Added: 0023392
2024-03-14 06:07	unknownna	Status	feedback => assigned
2024-03-14 16:23	Ru5tK1ng	Note Added: 0023398
2024-03-14 16:23	Ru5tK1ng	Assigned To	Ru5tK1ng =>
2024-03-14 16:23	Ru5tK1ng	Status	assigned => needs review
2024-03-24 21:17	Ru5tK1ng	Note Added: 0023486
2024-03-24 21:17	Ru5tK1ng	Status	needs review => needs testing
2024-03-24 21:17	Ru5tK1ng	Target Version	=> 3.2
2024-04-08 23:42	Ru5tK1ng	Note Added: 0023565
2024-04-08 23:42	Ru5tK1ng	Status	needs testing => resolved
2024-04-08 23:42	Ru5tK1ng	Resolution	open => fixed
2024-04-08 23:42	Ru5tK1ng	Fixed in Version	=> 3.2

Relationships